cmd/compile: remove FS debug hash form

The FS form was only necessary for reliable hashes in tests,
and for that we can use -trimpath.

Another potential concern would be temporary work directory
names leaking into the names of files generated by cgo and the
like, but we already make sure to avoid those to ensure
reproducible builds: the compiler never sees those paths.
So the FS form is not necessary for that either.

Change-Id: Idae2c6acb22ab64dfb33bb053244d23fbe153830
Reviewed-on: https://go-review.googlesource.com/c/go/+/493737
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>

1 files changed, 0 insertions, 8 deletions

diff --git a/src/cmd/compile/internal/base/hashdebug.go b/src/cmd/compile/internal/base/hashdebug.go
index 46adaaacd7..c99695642c 100644
--- a/src/cmd/compile/internal/base/hashdebug.go
+++ b/src/cmd/compile/internal/base/hashdebug.go
@@ -40,14 +40,6 @@ type HashDebug struct {
 	inlineSuffixOnly bool // for Pos hashes, remove all but the most inline position.
 }
 
-// SetFileSuffixOnly controls whether hashing and reporting use the entire
-// file path name, just the basename.  This makes hashing more consistent,
-// at the expense of being able to certainly locate the file.
-func (d *HashDebug) SetFileSuffixOnly(b bool) *HashDebug {
-	d.fileSuffixOnly = b
-	return d
-}
-
 // SetInlineSuffixOnly controls whether hashing and reporting use the entire
 // inline position, or just the most-inline suffix.  Compiler debugging tends
 // to want the whole inlining, debugging user problems (loopvarhash, e.g.)