diff options
| author | Ian Lance Taylor <iant@golang.org> | 2019-07-11 11:57:31 -0700 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2019-07-12 17:31:29 +0000 |
| commit | e831719469a5acfad7d8f73a976e2959815d0e27 (patch) | |
| tree | 11f0bac79bc77ec1a7c7e8d3d6afed658dc92066 /misc/cgo/errors/errors_test.go | |
| parent | 7942671a5856233ce63a265e1a1441b7a0ea82f5 (diff) | |
| download | go-e831719469a5acfad7d8f73a976e2959815d0e27.tar.xz | |
cmd/cgo: do not rewrite call if there are more args than parameters
We already skipped rewriting the call if there were fewer args than
parameters. But we can also get a cgo crash if there are more args,
if at least one of the extra args uses a name qualified with "C.".
Skip the rewrite, since the build will fail later anyhow.
Fixes #33061
Change-Id: I62ff3518b775b502ad10c2bacf9102db4c9a531c
Reviewed-on: https://go-review.googlesource.com/c/go/+/185797
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Diffstat (limited to 'misc/cgo/errors/errors_test.go')
| -rw-r--r-- | misc/cgo/errors/errors_test.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/misc/cgo/errors/errors_test.go b/misc/cgo/errors/errors_test.go index e6bac0fff4..1bdf843451 100644 --- a/misc/cgo/errors/errors_test.go +++ b/misc/cgo/errors/errors_test.go @@ -112,6 +112,7 @@ func TestReportsTypeErrors(t *testing.T) { "issue18452.go", "issue18889.go", "issue28721.go", + "issue33061.go", } { check(t, file) } |