From e831719469a5acfad7d8f73a976e2959815d0e27 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Thu, 11 Jul 2019 11:57:31 -0700 Subject: cmd/cgo: do not rewrite call if there are more args than parameters We already skipped rewriting the call if there were fewer args than parameters. But we can also get a cgo crash if there are more args, if at least one of the extra args uses a name qualified with "C.". Skip the rewrite, since the build will fail later anyhow. Fixes #33061 Change-Id: I62ff3518b775b502ad10c2bacf9102db4c9a531c Reviewed-on: https://go-review.googlesource.com/c/go/+/185797 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Andrew Bonventre --- misc/cgo/errors/errors_test.go | 1 + 1 file changed, 1 insertion(+) (limited to 'misc/cgo/errors/errors_test.go') diff --git a/misc/cgo/errors/errors_test.go b/misc/cgo/errors/errors_test.go index e6bac0fff4..1bdf843451 100644 --- a/misc/cgo/errors/errors_test.go +++ b/misc/cgo/errors/errors_test.go @@ -112,6 +112,7 @@ func TestReportsTypeErrors(t *testing.T) { "issue18452.go", "issue18889.go", "issue28721.go", + "issue33061.go", } { check(t, file) } -- cgit v1.3