diff options
| author | Russ Cox <rsc@golang.org> | 2010-07-15 16:43:06 -0700 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2010-07-15 16:43:06 -0700 |
| commit | ad665e4fde1878dbc8d3893bf8b4ddbe2f83ccff (patch) | |
| tree | 43ef5268be7d9ccdccb6fbe83bb75e1b6007b930 /lib | |
| parent | 4c0de303ceb049b171f3cc43a4651a3f5a91b1da (diff) | |
| download | go-ad665e4fde1878dbc8d3893bf8b4ddbe2f83ccff.tar.xz | |
codereview: don't run gofmt with an empty file list
R=gri
CC=golang-dev
https://golang.org/cl/1678054
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/codereview/codereview.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 750ae871ca..4aeff90678 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -694,6 +694,8 @@ def CheckGofmt(ui, repo, files, just_warn=False): cwd = os.getcwd() files = [RelativePath(repo.root + '/' + f, cwd) for f in files] files = [f for f in files if os.access(f, 0)] + if not files: + return try: cmd = subprocess.Popen(["gofmt", "-l"] + files, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True) cmd.stdin.close() |