diff options
| author | Damien Neil <dneil@google.com> | 2022-05-18 16:23:28 -0700 |
|---|---|---|
| committer | Damien Neil <dneil@google.com> | 2022-08-16 20:01:36 +0000 |
| commit | a55793835f16d0242be18aff4ec0bd13494175bd (patch) | |
| tree | d176c1b120a56875f1f33cf2c0b81f91f0084ff4 /api | |
| parent | 68005592b38027490a08972f13269406b2556a07 (diff) | |
| download | go-a55793835f16d0242be18aff4ec0bd13494175bd.tar.xz | |
net/http/httputil: add ReverseProxy.Rewrite
Add a new Rewrite hook to ReverseProxy, superseding the Director hook.
Director does not distinguish between the inbound and outbound request,
which makes it possible for headers added by Director to be inadvertently
removed before forwarding if they are listed in the inbound request's
Connection header. Rewrite accepts a value containing the inbound
and outbound requests, with hop-by-hop headers already removed from
the outbound request, avoiding this problem.
ReverseProxy's appends the client IP to the inbound X-Forwarded-For
header by default. Users must manually delete untrusted X-Forwarded-For
values. When used with a Rewrite hook, ReverseProxy now strips
X-Forwarded-* headers by default.
NewSingleHostReverseProxy creates a proxy that does not rewrite the
Host header of inbound requests. Changing this behavior is
cumbersome, as it requires wrapping the Director function created
by NewSingleHostReverseProxy. The Rewrite hook's ProxyRequest
parameter provides a SetURL method that provides equivalent
functionality to NewSingleHostReverseProxy, rewrites the Host
header by default, and can be more easily extended with additional
customizations.
Fixes #28168.
Fixes #50580.
Fixes #53002.
Change-Id: Ib84e2fdd1d52c610e3887af66f517d4a74e594d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/407214
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
Diffstat (limited to 'api')
| -rw-r--r-- | api/next/53002.txt | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/api/next/53002.txt b/api/next/53002.txt new file mode 100644 index 0000000000..b078fee55c --- /dev/null +++ b/api/next/53002.txt @@ -0,0 +1,6 @@ +pkg net/http/httputil, method (*ProxyRequest) SetURL(*url.URL) #53002 +pkg net/http/httputil, method (*ProxyRequest) SetXForwarded() #53002 +pkg net/http/httputil, type ProxyRequest struct #53002 +pkg net/http/httputil, type ProxyRequest struct, In *http.Request #53002 +pkg net/http/httputil, type ProxyRequest struct, Out *http.Request #53002 +pkg net/http/httputil, type ReverseProxy struct, Rewrite func(*ProxyRequest) #53002 |