diff options
| author | Michael Pratt <mpratt@google.com> | 2025-10-27 16:17:31 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-10-27 19:09:48 -0700 |
| commit | ff2ebf69c4f099adf90d6c6284f2b3fd2ff789f0 (patch) | |
| tree | eb943389e8463e95a9e19c891b3670a42e58db70 | |
| parent | 9a77aa4f083f7458a29c7c13adfe3d2ca8c864ea (diff) | |
| download | go-ff2ebf69c4f099adf90d6c6284f2b3fd2ff789f0.tar.xz | |
internal/runtime/gc/scan: correct size class size check
This check intends to skip size classes that are too big for scanSpan,
but it compares the size class index with a byte size. It must do the
conversion first.
For #73581.
Change-Id: I6a6a636c8d19fa3bf2a2b609870d67d33f47f66e
Reviewed-on: https://go-review.googlesource.com/c/go/+/715460
Auto-Submit: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
| -rw-r--r-- | src/internal/runtime/gc/scan/scan_test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/internal/runtime/gc/scan/scan_test.go b/src/internal/runtime/gc/scan/scan_test.go index 14a0f6f7f4..1208783b6f 100644 --- a/src/internal/runtime/gc/scan/scan_test.go +++ b/src/internal/runtime/gc/scan/scan_test.go @@ -114,7 +114,8 @@ func benchmarkScanSpanPackedAllSizeClasses(b *testing.B, nPages int) { if sc == 0 { continue } - if sc >= gc.MinSizeForMallocHeader { + size := gc.SizeClassToSize[sc] + if size >= gc.MinSizeForMallocHeader { break } b.Run(fmt.Sprintf("sizeclass=%d", sc), func(b *testing.B) { |