diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2026-03-31 18:53:51 +0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2026-03-31 10:58:57 -0700 |
| commit | f665ff8bc1ab2576d173cb69c3b2e87916dc74fd (patch) | |
| tree | 28d93dff4549cfb6b1efc0126f44c7885c429b62 | |
| parent | 9002bd9fa1a3b500ca570844ea563967268a3878 (diff) | |
| download | go-f665ff8bc1ab2576d173cb69c3b2e87916dc74fd.tar.xz | |
cmd/compile: fix wrong label loop during rangefunc rewrite
During the rangefunc rewrite, the compiler must correctly identify
the target of branch statements. When a label is defined within a
nested scope - such as inside a function literal or a closure - it
can shadow a label with the same name in the outer scope.
If the rewrite logic does not account for this shadowing, it may
incorrectly associate a branch with a nested label rather than the
intended loop label. Since the typechecker already guarantees that
labels are unique within their respective scopes, any duplicate label
name encountered must belong to a nested scope. These should be
skipped to ensure branch computing correctly targets the current
range-loop scope.
Fixes #78408
Change-Id: I4dce8a4d956f41b3a717a509f8c3f7478720be9f
Reviewed-on: https://go-review.googlesource.com/c/go/+/761420
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jakub Ciolek <jakub@ciolek.dev>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Keith Randall <khr@google.com>
| -rw-r--r-- | src/cmd/compile/internal/rangefunc/rewrite.go | 9 | ||||
| -rw-r--r-- | test/fixedbugs/issue78408.go | 18 |
2 files changed, 26 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/rangefunc/rewrite.go b/src/cmd/compile/internal/rangefunc/rewrite.go index 551e126af8..2421efbad8 100644 --- a/src/cmd/compile/internal/rangefunc/rewrite.go +++ b/src/cmd/compile/internal/rangefunc/rewrite.go @@ -994,7 +994,14 @@ func (r *rewriter) computeBranchNext() { l := n.Label.Value labels = append(labels, l) f := forStack[len(forStack)-1] - r.labelLoop[l] = f + if _, existed := r.labelLoop[l]; existed { + // The typechecker has already validated that labels are unique within this scope. + // If a duplicate label 'X' is encountered, it must reside in a nested scope + // (e.g., inside a function literal). Because nested labels do not affect + // the current control flow analysis, they can be safely ignored. + } else { + r.labelLoop[l] = f + } } } else { n := stack[len(stack)-1] diff --git a/test/fixedbugs/issue78408.go b/test/fixedbugs/issue78408.go new file mode 100644 index 0000000000..a43e5c23f1 --- /dev/null +++ b/test/fixedbugs/issue78408.go @@ -0,0 +1,18 @@ +// compile + +// Copyright 2026 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package p + +func F() { +A: + for range (func(func() bool))(nil) { + _ = func() { + A: + goto A + } + goto A + } +} |
