diff options
| author | Cherry Zhang <cherryyz@google.com> | 2021-04-20 21:07:23 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2021-04-21 14:16:01 +0000 |
| commit | e5bc4f2a77e497f30dce08014bc6addd8a7d9982 (patch) | |
| tree | e80b259bf22bfeb340281cadc7fb3c3c7525d7cf | |
| parent | daee726a0b7c932ed418e623ef29697c77d113a8 (diff) | |
| download | go-e5bc4f2a77e497f30dce08014bc6addd8a7d9982.tar.xz | |
cmd/compile: reenable name preservation on copies in expand_calls
This reverts CL 311829, and reenables CL 309330. The issue
should be fixed in the previous CL.
Change-Id: I69db0565c72470a1814f135d8f8ec62c781bfc5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/312094
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
| -rw-r--r-- | src/cmd/compile/internal/ssa/expand_calls.go | 18 | ||||
| -rw-r--r-- | test/live_regabi.go | 5 |
2 files changed, 9 insertions, 14 deletions
diff --git a/src/cmd/compile/internal/ssa/expand_calls.go b/src/cmd/compile/internal/ssa/expand_calls.go index 48e40bb00a..4d5376b344 100644 --- a/src/cmd/compile/internal/ssa/expand_calls.go +++ b/src/cmd/compile/internal/ssa/expand_calls.go @@ -1452,17 +1452,15 @@ func expandCalls(f *Func) { // Step 6: elide any copies introduced. // Update named values. - if false { // TODO: reeanable. It caused compiler OOMing on large input. - for _, name := range f.Names { - values := f.NamedValues[name] - for i, v := range values { - if v.Op == OpCopy { - a := v.Args[0] - for a.Op == OpCopy { - a = a.Args[0] - } - values[i] = a + for _, name := range f.Names { + values := f.NamedValues[name] + for i, v := range values { + if v.Op == OpCopy { + a := v.Args[0] + for a.Op == OpCopy { + a = a.Args[0] } + values[i] = a } } } diff --git a/test/live_regabi.go b/test/live_regabi.go index af14ede73f..2b0278ecb8 100644 --- a/test/live_regabi.go +++ b/test/live_regabi.go @@ -1,8 +1,5 @@ // errorcheckwithauto -0 -l -live -wb=0 -d=ssa/insert_resched_checks/off -// +build amd64,goexperiment.regabidefer,goexperiment.regabiargs,ignore - -// Disabled for now. The compiler sometimes has bad name-value association -// for args, causing args appears as autotmps. +// +build amd64,goexperiment.regabidefer,goexperiment.regabiargs // Copyright 2014 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style |