diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-02-02 10:19:30 -0500 |
|---|---|---|
| committer | Bryan Mills <bcmills@google.com> | 2022-02-03 16:53:55 +0000 |
| commit | bec8a108b324b2fc68eafeee7293a479813ec4e2 (patch) | |
| tree | 5c2a7532762f26b3e5ab1d3b2885a1551d8794d3 | |
| parent | fa4d9b8e2bc2612960c80474fca83a4c85a974eb (diff) | |
| download | go-bec8a108b324b2fc68eafeee7293a479813ec4e2.tar.xz | |
runtime: skip TestSegv failures with "morestack on g0" on darwin/amd64
This failure mode has been present since at least 2020-06-08. We have
enough information to diagnose it, and further failures don't seem to
be adding any new information at this point: they can only add noise,
both on the Go project's builders and in users' own modules (for
example, when run as part of 'go test all').
For #39457
Change-Id: I2379631da0c8af69598fa61c0cc5ac0ea6ba8267
Reviewed-on: https://go-review.googlesource.com/c/go/+/382395
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
| -rw-r--r-- | src/runtime/crash_cgo_test.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 9444554d37..dc8f6a7148 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -596,6 +596,9 @@ func TestSegv(t *testing.T) { t.Log(got) want := "SIGSEGV" if !strings.Contains(got, want) { + if runtime.GOOS == "darwin" && runtime.GOARCH == "amd64" && strings.Contains(got, "fatal: morestack on g0") { + testenv.SkipFlaky(t, 39457) + } t.Errorf("did not see %q in output", want) } |