diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2022-05-17 15:38:35 +0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-05-17 18:13:13 +0000 |
| commit | afd181cf0b69c3591d7e47ceca4fabf14434d77e (patch) | |
| tree | 97a99487ec3d682f9ecf7d20bb9d643d929135d0 | |
| parent | cc4957a5f6eba946f359ed9646ec3e5083a259a9 (diff) | |
| download | go-afd181cf0b69c3591d7e47ceca4fabf14434d77e.tar.xz | |
test,misc: fix builders that do not support plugin
CL 406358 added test that use -buildmode=plugin. But plugin mode only
supports on some os/arch pairs, so this CL moving the test to
misc/cgo/testplugin directory instead.
Updates #52937
Change-Id: Iad049443c1f6539f6af1988bebd4dff56c6e1bf9
Reviewed-on: https://go-review.googlesource.com/c/go/+/406774
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
| -rw-r--r-- | misc/cgo/testplugin/plugin_test.go | 4 | ||||
| -rw-r--r-- | misc/cgo/testplugin/testdata/issue52937/main.go (renamed from test/typeparam/issue52937.go) | 5 |
2 files changed, 4 insertions, 5 deletions
diff --git a/misc/cgo/testplugin/plugin_test.go b/misc/cgo/testplugin/plugin_test.go index 53e79a4626..74fb866f6f 100644 --- a/misc/cgo/testplugin/plugin_test.go +++ b/misc/cgo/testplugin/plugin_test.go @@ -296,6 +296,10 @@ func TestIssue44956(t *testing.T) { run(t, "./issue44956.exe") } +func TestIssue52937(t *testing.T) { + goCmd(t, "build", "-buildmode=plugin", "-o", "issue52937.so", "./issue52937/main.go") +} + func TestForkExec(t *testing.T) { // Issue 38824: importing the plugin package causes it hang in forkExec on darwin. diff --git a/test/typeparam/issue52937.go b/misc/cgo/testplugin/testdata/issue52937/main.go index efcb69a2c1..66f09effea 100644 --- a/test/typeparam/issue52937.go +++ b/misc/cgo/testplugin/testdata/issue52937/main.go @@ -1,8 +1,3 @@ -// build -buildmode=plugin - -//go:build !js -// +build !js - // Copyright 2022 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. |