diff options
| author | Elias Naur <elias.naur@gmail.com> | 2016-03-25 01:27:34 +0100 |
|---|---|---|
| committer | Elias Naur <elias.naur@gmail.com> | 2016-03-25 00:55:07 +0000 |
| commit | 95add73abf50dedec79b58ce4c58664eccfcca4d (patch) | |
| tree | 0d4bd8b3d85fc7f0782da7feb4d059dc466d9764 | |
| parent | 24ce64d1a967eb9c4f1a42e7371362b09920bd60 (diff) | |
| download | go-95add73abf50dedec79b58ce4c58664eccfcca4d.tar.xz | |
misc/cgo/testcarchive: fix build
I failed to rebase (and re-test) CL 21102 before submit, which meant
that two extra tests sneaked into testcarchive that still referenced
runtime.GOOS and runtime.GOARCH.
Convert the new tests.
While we're here, make sure pending tasks are flushed before running
the host tests. If not, the "##### misc/cgo/testcarchive" banner
and "PASS" won't show up in the all.bash output.
Change-Id: I41fc4ec9515f9a193fa052f7c31fac452153c897
Reviewed-on: https://go-review.googlesource.com/21106
Run-TryBot: Elias Naur <elias.naur@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
| -rw-r--r-- | misc/cgo/testcarchive/carchive_test.go | 12 | ||||
| -rw-r--r-- | src/cmd/dist/test.go | 1 |
2 files changed, 7 insertions, 6 deletions
diff --git a/misc/cgo/testcarchive/carchive_test.go b/misc/cgo/testcarchive/carchive_test.go index a853cba32b..6771ad3be1 100644 --- a/misc/cgo/testcarchive/carchive_test.go +++ b/misc/cgo/testcarchive/carchive_test.go @@ -227,11 +227,11 @@ func TestEarlySignalHandler(t *testing.T) { } func TestSignalForwarding(t *testing.T) { - switch runtime.GOOS { + switch GOOS { case "darwin": - switch runtime.GOARCH { + switch GOARCH { case "arm", "arm64": - t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", runtime.GOOS, runtime.GOARCH) + t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", GOOS, GOARCH) } case "windows": t.Skip("skipping signal test on Windows") @@ -277,11 +277,11 @@ func TestSignalForwarding(t *testing.T) { } func TestSignalForwardingExternal(t *testing.T) { - switch runtime.GOOS { + switch GOOS { case "darwin": - switch runtime.GOARCH { + switch GOARCH { case "arm", "arm64": - t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", runtime.GOOS, runtime.GOARCH) + t.Skipf("skipping on %s/%s; see https://golang.org/issue/13701", GOOS, GOARCH) } case "windows": t.Skip("skipping signal test on Windows") diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index d5bb1362fb..23d8c3939c 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -696,6 +696,7 @@ func (t *tester) registerHostTest(name, dirBanner, pkg string) { name: name, heading: dirBanner, fn: func(dt *distTest) error { + t.runPending(dt) return t.runHostTest(dirBanner, pkg) }, }) |