aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosh Bleecher Snyder <josharian@gmail.com>2014-09-11 12:47:17 -0700
committerJosh Bleecher Snyder <josharian@gmail.com>2014-09-11 12:47:17 -0700
commit8cc6cb2f17d7fac3cd180b60ab85beabe874b24d (patch)
tree5c015532cea2cf6658c52721bcf13c1bcbbcf7f1
parentfcb4cabba4efd78905939b7e0ceab2e9eb3c60a8 (diff)
downloadgo-8cc6cb2f17d7fac3cd180b60ab85beabe874b24d.tar.xz
test: return errors earlier in run.go
Fixes #8184. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/137510043
-rw-r--r--test/run.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/test/run.go b/test/run.go
index 483775d841..28882cf54c 100644
--- a/test/run.go
+++ b/test/run.go
@@ -626,6 +626,7 @@ func (t *test) run() {
out, err := runcmd(append([]string{"go", "run", t.goFileName()}, args...)...)
if err != nil {
t.err = err
+ return
}
if strings.Replace(string(out), "\r\n", "\n", -1) != t.expectedOutput() {
t.err = fmt.Errorf("incorrect output\n%s", out)
@@ -640,6 +641,7 @@ func (t *test) run() {
out, err := runcmd(append([]string{"go", "run", t.goFileName()}, args...)...)
if err != nil {
t.err = err
+ return
}
tfile := filepath.Join(t.tempDir, "tmp__.go")
if err := ioutil.WriteFile(tfile, out, 0666); err != nil {
@@ -649,6 +651,7 @@ func (t *test) run() {
out, err = runcmd("go", "run", tfile)
if err != nil {
t.err = err
+ return
}
if string(out) != t.expectedOutput() {
t.err = fmt.Errorf("incorrect output\n%s", out)
@@ -659,6 +662,7 @@ func (t *test) run() {
out, err := runcmd(append([]string{"go", "run", t.goFileName()}, args...)...)
if err != nil {
t.err = err
+ return
}
tfile := filepath.Join(t.tempDir, "tmp__.go")
err = ioutil.WriteFile(tfile, out, 0666)