diff options
| author | Oleksandr Redko <oleksandr.red+github@gmail.com> | 2024-03-03 21:52:16 +0200 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-03-04 17:32:49 +0000 |
| commit | 806ea41fce0aec85fc092ec268ebbc729ca0930f (patch) | |
| tree | a969a99c8fcab00a497dbe4ac01fb9c7d271a298 | |
| parent | 63c910a670731eee559f7264e5aaf4147094e550 (diff) | |
| download | go-806ea41fce0aec85fc092ec268ebbc729ca0930f.tar.xz | |
math/rand, math/rand/v2: rename receiver variables
According to the https://go.dev/wiki/CodeReviewComments#receiver-names
Change-Id: Ib8bc57cf6a680e5c75d7346b74e77847945f6939
Reviewed-on: https://go-review.googlesource.com/c/go/+/568635
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
| -rw-r--r-- | src/math/rand/rand_test.go | 10 | ||||
| -rw-r--r-- | src/math/rand/v2/rand_test.go | 10 |
2 files changed, 10 insertions, 10 deletions
diff --git a/src/math/rand/rand_test.go b/src/math/rand/rand_test.go index 9f074fea00..016cc69920 100644 --- a/src/math/rand/rand_test.go +++ b/src/math/rand/rand_test.go @@ -46,14 +46,14 @@ var testSeeds = []int64{1, 1754801282, 1698661970, 1550503961} // checkSimilarDistribution returns success if the mean and stddev of the // two statsResults are similar. -func (this *statsResults) checkSimilarDistribution(expected *statsResults) error { - if !nearEqual(this.mean, expected.mean, expected.closeEnough, expected.maxError) { - s := fmt.Sprintf("mean %v != %v (allowed error %v, %v)", this.mean, expected.mean, expected.closeEnough, expected.maxError) +func (sr *statsResults) checkSimilarDistribution(expected *statsResults) error { + if !nearEqual(sr.mean, expected.mean, expected.closeEnough, expected.maxError) { + s := fmt.Sprintf("mean %v != %v (allowed error %v, %v)", sr.mean, expected.mean, expected.closeEnough, expected.maxError) fmt.Println(s) return errors.New(s) } - if !nearEqual(this.stddev, expected.stddev, expected.closeEnough, expected.maxError) { - s := fmt.Sprintf("stddev %v != %v (allowed error %v, %v)", this.stddev, expected.stddev, expected.closeEnough, expected.maxError) + if !nearEqual(sr.stddev, expected.stddev, expected.closeEnough, expected.maxError) { + s := fmt.Sprintf("stddev %v != %v (allowed error %v, %v)", sr.stddev, expected.stddev, expected.closeEnough, expected.maxError) fmt.Println(s) return errors.New(s) } diff --git a/src/math/rand/v2/rand_test.go b/src/math/rand/v2/rand_test.go index c4b53fa93a..d223180fb6 100644 --- a/src/math/rand/v2/rand_test.go +++ b/src/math/rand/v2/rand_test.go @@ -50,14 +50,14 @@ var testSeeds = []uint64{1, 1754801282, 1698661970, 1550503961} // checkSimilarDistribution returns success if the mean and stddev of the // two statsResults are similar. -func (this *statsResults) checkSimilarDistribution(expected *statsResults) error { - if !nearEqual(this.mean, expected.mean, expected.closeEnough, expected.maxError) { - s := fmt.Sprintf("mean %v != %v (allowed error %v, %v)", this.mean, expected.mean, expected.closeEnough, expected.maxError) +func (sr *statsResults) checkSimilarDistribution(expected *statsResults) error { + if !nearEqual(sr.mean, expected.mean, expected.closeEnough, expected.maxError) { + s := fmt.Sprintf("mean %v != %v (allowed error %v, %v)", sr.mean, expected.mean, expected.closeEnough, expected.maxError) fmt.Println(s) return errors.New(s) } - if !nearEqual(this.stddev, expected.stddev, expected.closeEnough, expected.maxError) { - s := fmt.Sprintf("stddev %v != %v (allowed error %v, %v)", this.stddev, expected.stddev, expected.closeEnough, expected.maxError) + if !nearEqual(sr.stddev, expected.stddev, expected.closeEnough, expected.maxError) { + s := fmt.Sprintf("stddev %v != %v (allowed error %v, %v)", sr.stddev, expected.stddev, expected.closeEnough, expected.maxError) fmt.Println(s) return errors.New(s) } |