diff options
| author | Ian Lance Taylor <iant@golang.org> | 2022-08-05 18:36:02 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-08-08 21:09:03 +0000 |
| commit | 52dfdc5e1e6f4f8ddd99f238e37b6c255f5ab6bd (patch) | |
| tree | ef82ce4ea4abfa8c664dc1901832b6bc9da3c195 | |
| parent | 9a4685f22036b4e2577bb79dbfabd7c4e48146e3 (diff) | |
| download | go-52dfdc5e1e6f4f8ddd99f238e37b6c255f5ab6bd.tar.xz | |
mime: remove test ordering dependency
Arrange for tests that call setMimeInit to fully restore the old values,
by clearing the sync.Once that controls initialization.
Once we've done that, call initMime in initMimeUnixTest because
otherwise the test types loaded there will be cleared by the call to
initMime that previously was not being done.
For golang/go#51648
Change-Id: I8bf92b305fc4499337db06113817c9decdc5aedb
Reviewed-on: https://go-review.googlesource.com/c/go/+/421442
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
| -rw-r--r-- | src/mime/type_test.go | 5 | ||||
| -rw-r--r-- | src/mime/type_unix_test.go | 1 |
2 files changed, 5 insertions, 1 deletions
diff --git a/src/mime/type_test.go b/src/mime/type_test.go index f10e6343f9..d8368e8846 100644 --- a/src/mime/type_test.go +++ b/src/mime/type_test.go @@ -14,7 +14,10 @@ import ( func setMimeInit(fn func()) (cleanup func()) { once = sync.Once{} testInitMime = fn - return func() { testInitMime = nil } + return func() { + testInitMime = nil + once = sync.Once{} + } } func clearMimeTypes() { diff --git a/src/mime/type_unix_test.go b/src/mime/type_unix_test.go index 2e8f273fad..7b8db79d27 100644 --- a/src/mime/type_unix_test.go +++ b/src/mime/type_unix_test.go @@ -11,6 +11,7 @@ import ( ) func initMimeUnixTest(t *testing.T) { + once.Do(initMime) err := loadMimeGlobsFile("testdata/test.types.globs2") if err != nil { t.Fatal(err) |