diff options
| author | Ian Lance Taylor <iant@golang.org> | 2019-04-02 15:05:33 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2019-04-02 22:58:55 +0000 |
| commit | 2da9659158f87c1d3c0ccb7ff8aec7c1bafe570b (patch) | |
| tree | 4e8bfa0c3767c87184da27c370cc234bcd6dfb46 | |
| parent | fc7ac2e8c0499d047ce0120a2f5df23093df6c17 (diff) | |
| download | go-2da9659158f87c1d3c0ccb7ff8aec7c1bafe570b.tar.xz | |
misc/cgo/testcarchive: skip TestSignalForwardingExternal on darwin/amd64
On darwin/amd64 the runtime method sigctxt.fixsigcode changes SIGSEGV
signals so that they are never marked SI_USER. CL 169120 changed the
signal handler to call fixsigcode even when the signal is delivered to
a non-Go thread. This breaks TestSignalForwardingExternal, so skip it.
Change-Id: I6740fb5a8f4f854ca69793537a983a696da3b495
Reviewed-on: https://go-review.googlesource.com/c/go/+/170446
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
| -rw-r--r-- | misc/cgo/testcarchive/carchive_test.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/misc/cgo/testcarchive/carchive_test.go b/misc/cgo/testcarchive/carchive_test.go index b7f04356a9..5fbe9caafb 100644 --- a/misc/cgo/testcarchive/carchive_test.go +++ b/misc/cgo/testcarchive/carchive_test.go @@ -325,6 +325,8 @@ func TestSignalForwarding(t *testing.T) { func TestSignalForwardingExternal(t *testing.T) { if GOOS == "freebsd" || GOOS == "aix" { t.Skipf("skipping on %s/%s; signal always goes to the Go runtime", GOOS, GOARCH) + } else if GOOS == "darwin" && GOARCH == "amd64" { + t.Skipf("skipping on %s/%s: runtime does not permit SI_USER SIGSEGV", GOOS, GOARCH) } checkSignalForwardingTest(t) |