| Age | Commit message (Collapse) | Author |
|
Markdown files are no longer treated as Go templates by default.
Pages that need template processing must explicitly set
"template: true" in their front matter.
This prevents unintended HTML escaping of template-like syntax
(e.g., "<" and ">") in Markdown content.
Fixes golang/go#75552
Change-Id: If00328831cd6b119043d9c2055fd21076943e2c4
Reviewed-on: https://go-review.googlesource.com/c/website/+/733500
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|
|
We emit a <div class=markdown> around the whole output of goldmark,
so that CSS style rules can easily select them (without affecting
HTML tables in the spec, for example).
The default style for markdown tables now has thin grey lines,
grey headings, and a little padding.
Also, remove the FS middleware used to inject default.tmpl
into x/tools/gopls/doc, since that file is now actually present.
And add it to the fake data at _content/gopls/doc.
Fixes golang/go#67368
Change-Id: If91e702c394d73a181bd780711e8be6f661f2e59
Reviewed-on: https://go-review.googlesource.com/c/website/+/691616
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Alan Donovan <adonovan@google.com>
|
|
The go.dev/gopls endpoint serves the gopls/doc
directory at the latest release of gopls;
the tip.golang.dev/gopls endpoint serves the latest
x/tools commit.
The GOLANGORG_LOCAL_X_TOOLS environment variable specifies
a local directory, overriding the use of git,
for previewing local doc changes.
Also, a command to recursively check links within the
go.dev/gopls subtree.
Fixes golang/go#68977
Change-Id: I5d92e6f0e5fdbed721a57f0a1ace2ac98e562fc8
Reviewed-on: https://go-review.googlesource.com/c/website/+/685635
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
|
While running go test -vet=all I saw a failure from unreachable code,
which lead me to run deadcode on the entire repo.
Change-Id: I20a7cd83f54595d12d46d1bdb714975e1efaf5e3
Reviewed-on: https://go-review.googlesource.com/c/website/+/633895
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
|
Change-Id: I705e7f626e31cc42dbfa92a744195268beb5882f
Reviewed-on: https://go-review.googlesource.com/c/website/+/622155
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
|
The wiki pages have been copied to go.googlesource.com/wiki
and will be code reviewed using Gerrit, like other Go repos.
Unlike other Go repos, self-review will be permitted, and
there is no requirement for Googlers to be involved to make a change.
These relaxations are possible because the wiki has no production code.
The set of wiki +2'ers is a superset of the usual code +2'ers.
Fixes golang/go#61940.
Change-Id: I01823720091fbaa24e95e9c82abeaadba867a17c
Reviewed-on: https://go-review.googlesource.com/c/website/+/518297
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
|
If a markdown file has `template: false` in its metadata,
it will not be treated as a template.
Change-Id: I81599ea02b05ff7693f5f816293433df4988b64c
Reviewed-on: https://go-review.googlesource.com/c/website/+/537497
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|
|
OMIT lines may appear in code before or after the section intended to be
displayed in a code block, however in the case of playground code blocks
those lines are actually included. This change makes sure we always
filter out the OMIT lines when generating code blocks, and adds a test.
I noticed this when the playground snippets in the race detector blog
post (https://go.dev/blog/race-detector) gave this error:
package play: build constraints exclude all Go files in /tmp/sandbox2684341108
This is because those programs begin with the lines `// +build OMIT`,
which were never intended to be executed.
Change-Id: I5b0320da139741c789126f0c9d3dabc7044cd350
Reviewed-on: https://go-review.googlesource.com/c/website/+/466775
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
|
|
Now that the deploy happens with Go 1.19, it's viable to start using
these packages from the standard library instead of their backported
temporary copies.
Keeping Go 1.18 happy during its last two months of support requires
a tiny complication in pkgdoc package. An alternative path is to not
drop internal/backport/go/doc and all of its dependencies right away,
but getting to zero backported packages sooner was hard to resist...
For golang/go#51800.
Change-Id: Ieb7a137a033d6b6850dfc019c8c0c767756cc30d
Reviewed-on: https://go-review.googlesource.com/c/website/+/456522
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
|
|
Fixes breakage from CL 446115.
Change-Id: I54be08987e04d3baaabc22b0450b7492f44bbca2
Reviewed-on: https://go-review.googlesource.com/c/website/+/446655
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
|
|
Change-Id: I0754d18f4c3c3d5dfa0c34b4bc154a35ac20b917
Reviewed-on: https://go-review.googlesource.com/c/website/+/411794
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
|
|
Gofmt to update doc comments to the new formatting.
For golang/go#51082.
Change-Id: I3573e720b522fe41f726d2fb4e3b988ee883872d
Reviewed-on: https://go-review.googlesource.com/c/website/+/399608
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
|
|
Invoke the template named "html" using the usual html/template way
instead of invoking it as a function (via the tmplfunc package) to
work around https://github.com/rsc/tmplfunc/issues/1.
The package golang.org/x/tools/present imports "html/template" from
the standard library, so its HTML.HTML field of type template.HTML
isn't understood to be content from a trusted source by the internal
backported copy. Use type aliases for those special types to fix that.
Fixes golang/go#51989.
Updates rsc/tmplfunc#1.
Change-Id: Ib9609f41b17407e297ea3bb111f346188aa7a9b0
Reviewed-on: https://go-review.googlesource.com/c/website/+/396234
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
|
|
The filepath for the spec document changed and broke
the linkify step.
Fixes golang/go#50915
Change-Id: Ieafe9c665f4063fb9f9ddf74610925f123e2c249
Reviewed-on: https://go-review.googlesource.com/c/website/+/388859
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
|
|
Added documentation of .ts file transforms to web package doc.
Change-Id: I00830e9eea9234bd2867b5f62e8f714b9a0474a0
Reviewed-on: https://go-review.googlesource.com/c/website/+/376075
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <amedee@google.com>
Trust: Carlos Amedee <amedee@google.com>
|
|
- Added tsconfig file.
- Set esbuild target.
- Updated eslint rules for JSDoc.
Change-Id: I212bdd58a56540da26cccc8af319a8d98fa9f35a
Reviewed-on: https://go-review.googlesource.com/c/website/+/376074
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
|
|
To transform .ts files from any path on a site and to ensure
it works for all domains the transform logic is moved to the
web package.
Change-Id: I1ce62eb35dbdfb987ccc2f48e79c558bcdadfbbe
Reviewed-on: https://go-review.googlesource.com/c/website/+/374994
Trust: Jamal Carvalho <jamalcarvalho@google.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
|
|
This is the last user-facing golang.org domain.
Now everything is on go.dev.
Change-Id: I8d9f4b7609a019f077848825cbd417d38058a5ac
Reviewed-on: https://go-review.googlesource.com/c/website/+/365494
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Text files were being displayed raw, e.g.
https://golang.org/src/math/sin.go.
Fix that.
Change-Id: I09dec1d675ca950bf3750c38585cf3995a570134
Reviewed-on: https://go-review.googlesource.com/c/website/+/361206
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Go 1.16 is available on App Engine now, so use it.
Also, Go 1.17 has been released, meaning
we don't need to keep Go 1.15 builders working.
Delete all the Go 1.16 backports except the template packages,
which contain modifications we need.
Change-Id: I4612441a1484ce9272a22268da73d67f7624309b
Reviewed-on: https://go-review.googlesource.com/c/website/+/343935
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
This is the first of a sequence of consolidations of web sites into
the single site go.dev. An accompanying blog post (next CL) will
explain the change.
The blog/_content tree moves to go.dev/_content/blog.
The *.article files were converted to *.md files using rsc.io/tmp/blog2md.
The old dot directives are now template function invocations,
so that blog content files are now exactly the same format and
semantics as regular site content files.
All the old blog redirects are carried forward, of course.
Also add exhaustive test that every .md file renders correctly.
Also rename rawhtml to raw, because it gets used for raw Markdown too.
The raw Markdown issue is working around a bigger problem
(html/template is not really right for Markdown) that we will have
to solve at some point, but not in this CL.
Change-Id: Ifa9b3b8d656a72af30d0d4e57e4c7bc8dacbc386
Reviewed-on: https://go-review.googlesource.com/c/website/+/342091
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Also fix doc/articles/wiki code file references.
Fixes golang/go#47759.
Change-Id: Idd0cce627f594898c805269ae7cd0e0f980aec8f
Reviewed-on: https://go-review.googlesource.com/c/website/+/343289
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
|
|
internal/web was the framework left serving golang.org.
go.dev/cmd/internal/site was the framework serving go.dev.
This CL merges the two into a coherent, simple site serving
framework that works for both sites, a step toward merging
the sites themselves.
The CL is difficult to break up, so it's a bit larger than would be ideal.
The best place to start is the doc comment in internal/web/site.go
and then the other changes in that directory.
The rest of the CL is just minor adjustments to the repo to match.
Change-Id: I927dea29396104a817bd81b6bf25fa43f996968f
Reviewed-on: https://go-review.googlesource.com/c/website/+/339403
Trust: Russ Cox <rsc@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
There's no real need for these to be written in Go.
Change-Id: Ifb3ebc99a06bb9670a39238a1ddf370c2dcd6a22
Reviewed-on: https://go-review.googlesource.com/c/website/+/339402
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Not all the package docs-specific parts of the server moved into
internal/pkgdoc before. Finish the job. Now the API for pkgdoc
is like the API for codewalk: just a NewServer that returns a handler.
Speaking of codewalk, unexport the Server type to match the
trimmed-down pkgdoc.
Change-Id: I19ba7351d55fb5d23d551a0296bb89d8abac6e9b
Reviewed-on: https://go-review.googlesource.com/c/website/+/328212
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|
|
CL 317655 introduced an issue causing non-playground code examples
to be double-escaped, causing HTML escape sequences and elements
to appear in the code, such as the examples in crypto/rsa,
as reported in golang/go#46839. This change treats the code as
template.HTML rather than string after running through (*Page).Node
(which formats the code as HTML) and doing some basic transformations,
preventing this double-escaping from occurring.
Fixes golang/go#46839
Change-Id: Id226147eb51219bd5e2db61e959519258e39a298
GitHub-Last-Rev: 81f8dc5e878cd283f7d5865e73d214135838549b
GitHub-Pull-Request: golang/website#73
Reviewed-on: https://go-review.googlesource.com/c/website/+/332889
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cherry Mui <cherryyz@google.com>
|
|
This reduces the number of documentation sites we have to one.
Except in China, where we have to keep serving on the one domain
golang.google.cn - there is no pkg.go.dev in China.
And unless people opt out with ?m=old.
For golang/go#44356.
Change-Id: I2a5b788ac861ce37f356287413468497d184fc09
Reviewed-on: https://go-review.googlesource.com/c/website/+/327849
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|
|
Goldmark has a bug that causes crashes in inputs
containing mixed spaces and tabs. Avoid it by removing tabs.
Change-Id: I4c678fce6c68bf0d448ed0b75a2ac12a42891ec6
Reviewed-on: https://go-review.googlesource.com/c/website/+/331349
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Steve Traut <straut@google.com>
|
|
There are differences in the App Engine environment that
cannot be adequately simulated elsewhere. Although we do
the best we can with testing locally, there will always be
differences.
The old makefiles deployed the site, then ran a regression
test against it, and then promoted the tested version.
This change does the same. The testing has moved into the
web server proper so that it can test the handler directly and
thereby check things like the responses on different domains.
The go-app-deploy.sh now always deploys --no-promote,
only promoting after a self-test passes on the deployed site.
Unlike the old check which only applied to golang.org,
the new pre-promotion testing happens for all the sites.
Also factor out GoogleCN into internal/web, because we needed
to modify it (to avoid internal/webtest's requests being diagnosed
as coming from China) and there were too many copies.
Change-Id: I0cde0e2167df2332939908e716ddb6bf429f2565
Reviewed-on: https://go-review.googlesource.com/c/website/+/329250
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|
|
With the help of the backported libraries introduced in the previous CL,
we can make the whole cmd/golangorg site run on Go 1.15 again.
This will let us use App Engine standard in advance of the release
of Go 1.16 on App Engine.
Change-Id: I9d1612de6f366e0774919aa6a94af14aafb248f5
Reviewed-on: https://go-review.googlesource.com/c/website/+/323891
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|
|
The toFS calls were a stop-gap to convert from old code that wasn't
strict about path forms to the io/fs routines that are more strict.
Arrange to pass io/fs-compatible paths everywhere and remove toFS.
Change-Id: Id69c0f23074ebd3a6dfef2255b2f8185ad1d1249
Reviewed-on: https://go-review.googlesource.com/c/website/+/317659
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|
|
What's left of internal/godoc is mainly a simple web server
for static content (plus the package docs provided by internal/pkgdoc)
and bears little resemblance to the original godoc.
Revamp the API and retire the name, moving to internal/web.
CL generated by the script below.
[git-generate]
cd internal/godoc
mv util.go istext.go
mv godoc_test.go template_test.go
mv server_test.go site_test.go
rf '
mv TabWidth tabWidth
mv IsText isText
mv TabSpacer tabSpacer
mv Presentation Site
mv NewPresentation NewSite
mv writerCapturesErr writeErrorSaver
rm marshalJSON
mv redirect maybeRedirect
mv redirectFile maybeRedirectFile
mv Site.serveText Site.serveRawText
mv Site.serveTextFile Site.serveText
mv Site.serveDirectory Site.serveDir
mv Site.initFuncMap Site.initDocFuncs
mv \
toFS \
Site \
NewSite \
Site.ServeError \
Site.ServeHTTP \
Site.ServePage \
Page \
Site.fullPage \
Page.Invoke \
writeErrorSaver \
writeErrorSaver.Write \
applyTemplateToResponseWriter \
Site.serveFile \
maybeRedirect \
maybeRedirectFile \
doctype \
Site.serveHTML \
Site.serveDir \
Site.serveText \
selRx \
rangeSelection \
Site.serveRawText \
Site.googleCN \
site.go
mv example_nameFunc example_name
mv example_suffixFunc example_suffix
mv srcPosLinkFunc srcPosLink
mv \
siteFuncs \
example_name \
example_suffix \
srcToPkg \
Page.SrcPkgLink \
Page.SrcBreadcrumb \
Page.SrcPosLink \
srcPosLink \
sitefuncs.go
mv \
docServer \
docServer.ServeHTTP \
Page.ModeQuery \
pkgdoc.go
mv metaJSON fileJSON
mv extractMetadata parseFile
mv \
file \
fileJSON \
join \
open \
jsonStart \
parseFile \
file.go
mv \
Site.initDocFuncs \
Site.code \
Site.contents \
stringFor \
Site.oneLine \
Site.multipleLines \
parseArg \
match \
docfuncs.go
mv Site.ServeError.p Site.ServeError.s
mv Site.ServeHTTP.p Site.ServeHTTP.s
mv Site.ServePage.p Site.ServePage.s
mv Site.code.p Site.code.s
mv Site.contents.p Site.contents.s
mv Site.fullPage.p Site.fullPage.s
mv Site.googleCN.p Site.googleCN.s
mv Site.initDocFuncs.p Site.initDocFuncs.s
mv Site.multipleLines.p Site.multipleLines.s
mv Site.oneLine.p Site.oneLine.s
mv Site.serveDir.p Site.serveDir.s
mv Site.serveFile.p Site.serveFile.s
mv Site.serveHTML.p Site.serveHTML.s
mv Site.serveRawText.p Site.serveRawText.s
mv Site.serveText.p Site.serveText.s
mv Site.writeNode.p Site.writeNode.s
mv Page.pres Page.site
mv astfuncs.go docfuncs.go examplefuncs.go \
file.go istext.go markdown.go pkgdoc.go \
site.go site_test.go sitefuncs.go \
tab.go template_test.go \
golang.org/x/website/internal/web
'
rm godoc.go meta.go page.go pres.go server.go template.go
cd ../../cmd/golangorg
rf '
mv pres site
'
Change-Id: Ic03a2dbe14f74c60bd6a5a86ba4d3f36d8c5bea8
Reviewed-on: https://go-review.googlesource.com/c/website/+/317656
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
|