aboutsummaryrefslogtreecommitdiff
path: root/cmd
AgeCommit message (Collapse)Author
13 hours[DO-NOT-MERGE] cmd/golangorg: support socket based activation with systemdHEADmainShulhan
Change-Id: I12e667f1945eb9440147842c3374756dbd8b09ef
13 hours[DO-NOT-MERGE] cmd/golangorg: realign structsShulhan
This affects declaring fields in struct using field name instead of naked names.
13 hours[DO-NOT-MERGE] cmd/golangorg: allow serving in local as "go.local"Shulhan
Change-Id: I73aa112ba125b56dbdaf2727a3a7165c03de9b3f
7 dayscmd/golangorg: use _goroot.zip during deploy tests tooDmitri Shuralyov
The deploy process constructs a _goroot.zip file which is used as the source of main Go repository content when serving go.dev. Start using the same _goroot.zip file when running tests in Cloud Build. Also move the flag.Parse to happen at the top of main, before some of the flag values are accessed and potentially overridden. For golang/go#78211. Change-Id: Iaf182301836917d062c5f4c329db6bbc171415da Reviewed-on: https://go-review.googlesource.com/c/website/+/763840 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
7 dayscmd/golangorg: temporarily skip check for "{{raw <code>" bad escapingDmitri Shuralyov
Even though the deployed version of go.dev/doc/godebug no longer has the "{{raw <code>" bad escaping, TestAll still fails during the deploy process. This is because it turns out that it doesn't use the same _goroot.zip file that the website uses to serve content. Instead, it uses GOROOT from the go version used to run the tests, and that version doesn't have the fixed godebug.md yet. For now, to fix the deploy process breakage sooner, disable the check that was recently added in CL 746741. For golang/go#78211. Change-Id: I5052f6ef2bc283e8751dca39f5131eb66c67cff3 Reviewed-on: https://go-review.googlesource.com/c/website/+/763740 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: David Chase <drchase@google.com>
2026-03-25cmd/golangorg: catch instances of bad escaping due to template useDmitri Shuralyov
The {{raw `…`}} sequence is commonly used in Markdown templates to include a block as is. If such a sequence is used in a Markdown file while its 'template' field in metadata is accidentally set to off (the new default value as of go.dev/cl/733500), it gets rendered as '{{raw <code>' HTML which is almost certainly not what was intended. It should be possible to catch these in TestAll. For golang/go#78211. Change-Id: I7bba708bc41a6421f3aae88e10d30574de7a9294 Reviewed-on: https://go-review.googlesource.com/c/website/+/746741 Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2026-03-25cmd/golangorg: include GOROOT/doc files in TestAll checksDmitri Shuralyov
Most of the go.dev content is in the _content directory of x/website, but some of the pages (e.g., go_spec.html, asm.html, godebug.md, etc.) canonically live in the main Go repository. Extend TestAll to help catch problems automatically in those files too. For golang/go#78211. Change-Id: I48ac3f8b2338ef1300461a860fe2cc4c2c30ac02 Reviewed-on: https://go-review.googlesource.com/c/website/+/746740 Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2026-03-25cmd/golangorg: support absolute paths in testTreeDmitri Shuralyov
The use of strings.TrimPrefix on filepath.ToSlash output works on all OSes when testTree is given a relative path like "../../_content", but it doesn't work on Windows if testTree is given an absolute path. The next change will do that (in order to process GOROOT/doc content), so prepare for it by migrating to filepath.Rel to compute relative path. For golang/go#78211. Change-Id: I2117d916e1c4112bfbd667597e32622039040dd0 Reviewed-on: https://go-review.googlesource.com/c/website/+/756501 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2026-02-10internal/history: remove draft notice, update deployment, add Go 1.26Junyang Shao
This change: Removes the draft notice from go1.26.md Updates the deployment for golangorg to Go 1.26 Adds Go 1.26 to history/release.go Fixes golang/go#75005. Change-Id: I3dc8457a3ec0fa2e3909b3592afe29db586db73a Reviewed-on: https://go-review.googlesource.com/c/website/+/743900 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com>
2026-02-02internal/web: do not treat Markdown files as templates by defaultRyo Sakuma
Markdown files are no longer treated as Go templates by default. Pages that need template processing must explicitly set "template: true" in their front matter. This prevents unintended HTML escaping of template-like syntax (e.g., "<" and ">") in Markdown content. Fixes golang/go#75552 Change-Id: If00328831cd6b119043d9c2055fd21076943e2c4 Reviewed-on: https://go-review.googlesource.com/c/website/+/733500 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2025-10-17cmd/screentest: escape % in format stringDmitri Shuralyov
Caught by the improved vet check as of CL 707135: $ go vet ./cmd/screentest cmd/screentest/screentest.go:169:33: p format % o reads arg #1, but call has 0 args Change-Id: I7eeedab93652a51779904542e52d1fb77349f3f5 Reviewed-on: https://go-review.googlesource.com/c/website/+/712760 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2025-10-14cmd/adminapp: add protection against CSRFDmitri Shuralyov
Use CrossOriginProtection, which was added to net/http in Go 1.25, to reject non-safe cross-origin browser requests and help protect against Cross-Site Request Forgery (CSRF). Also modernize slightly while here by using strings.CutPrefix and removing a no-op return. Change-Id: I698d26e1fe70be3b606c6e67a7d204e9e0f245d9 Reviewed-on: https://go-review.googlesource.com/c/website/+/711900 Auto-Submit: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Roland Shoemaker <roland@golang.org>
2025-09-12cmd/{adminapp,adminredirect,googlegolangorg}: update App Engine runtimeDmitri Shuralyov
Keep them up with the times. Change-Id: If9d93df36594dad923fc1aa2ebe2931a76706bac Reviewed-on: https://go-review.googlesource.com/c/website/+/695997 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
2025-08-14cmd/golangorg: update App Engine runtime to Go 1.25Dmitri Shuralyov
By now the supported and tested Go versions are Go 1.25 and 1.24. Update the website deployment to start using the Go 1.25 runtime. See https://cloud.google.com/appengine/docs/standard/lifecycle/support-schedule#go. Change-Id: I5e86431be0665f1d7f104b79a547baf5566bba89 Reviewed-on: https://go-review.googlesource.com/c/website/+/695996 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2025-08-12internal/history: remove draft notice, update deployment, add Go 1.25David Chase
This change: Removes the draft notice from go1.25.md Updates the deployment for golangorg to Go 1.25 Adds Go 1.25 to history/release.go For golang/go#71661 Change-Id: I1b74a1a92c47f6044a43ac2dd4609e7a52f11b45 Reviewed-on: https://go-review.googlesource.com/c/website/+/695375 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Bypass: David Chase <drchase@google.com>
2025-08-11cmd/googlegolangorg: add google.golang.org/adk redirectHana Kim
Internal tracking issue - b/435474163 Change-Id: I2507fed0fe099a23c4dc013dbd0597acf45f4d4b Reviewed-on: https://go-review.googlesource.com/c/website/+/692135 Reviewed-by: Jaana Dogan <jbd@google.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Sam Thanawalla <samthanawalla@google.com> Reviewed-by: Hongxiang Jiang <hxjiang@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-07-29_content/css: style tables produced from markdownAlan Donovan
We emit a <div class=markdown> around the whole output of goldmark, so that CSS style rules can easily select them (without affecting HTML tables in the spec, for example). The default style for markdown tables now has thin grey lines, grey headings, and a little padding. Also, remove the FS middleware used to inject default.tmpl into x/tools/gopls/doc, since that file is now actually present. And add it to the fake data at _content/gopls/doc. Fixes golang/go#67368 Change-Id: If91e702c394d73a181bd780711e8be6f661f2e59 Reviewed-on: https://go-review.googlesource.com/c/website/+/691616 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Alan Donovan <adonovan@google.com>
2025-07-29cmd/golangorg: serve latest commit on gopls' latest release branchAlan Donovan
Rather than serving docs at the gopls release itself, this CL causes us to serve whatever is on the release branch. This allows us to cherrypick doc fixes into the branch without all the fuss of a gopls release. Change-Id: I5f99458407388747a093219cac16e178f28ba527 Reviewed-on: https://go-review.googlesource.com/c/website/+/691415 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Alan Donovan <adonovan@google.com>
2025-07-09cmd/golangorg/testdata: tweak gopls assertions yet againAlan Donovan
I forgot that "Gopls: Home" is not the string that appears in the actual site. Sigh. Updates golang/go#68977 Change-Id: Idfc0ab7412d84212aa91848aae5edcbca54444ff Reviewed-on: https://go-review.googlesource.com/c/website/+/686820 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Commit-Queue: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-07-09cmd/golangorg/testdata: use tip for gopls tests, for nowAlan Donovan
(The new file structure won't appear until the gopls 20 release, and this causes AppEngine deployment to fail.) Updates golang/go#68977 Change-Id: I2e9a7222bb3cada1f32be4da6614c135fec14815 Reviewed-on: https://go-review.googlesource.com/c/website/+/686819 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2025-07-09cmd/golangorg: make assertions work with dummy and real dataAlan Donovan
Use the Settings doc instead of Dummy for the assertion, since it must pass both locally and in AppEngine deployment. Also, link to new gopls docs. Updates golang/go#68977 Change-Id: I8c1696c842617eb58005d94dc123aff6db6791dc Reviewed-on: https://go-review.googlesource.com/c/website/+/686915 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2025-07-08cmd/golangorg: serve gopls docs at go.dev/goplsAlan Donovan
The go.dev/gopls endpoint serves the gopls/doc directory at the latest release of gopls; the tip.golang.dev/gopls endpoint serves the latest x/tools commit. The GOLANGORG_LOCAL_X_TOOLS environment variable specifies a local directory, overriding the use of git, for previewing local doc changes. Also, a command to recursively check links within the go.dev/gopls subtree. Fixes golang/go#68977 Change-Id: I5d92e6f0e5fdbed721a57f0a1ace2ac98e562fc8 Reviewed-on: https://go-review.googlesource.com/c/website/+/685635 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-03-11cmd/{adminapp,adminredirect,googlegolangorg}: update App Engine runtimeDmitri Shuralyov
Keep them up with the times. Change-Id: I9305c1708f1824a39f256cd593f3958d99b209c5 Reviewed-on: https://go-review.googlesource.com/c/website/+/655657 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2025-03-10cmd/golangorg: update App Engine runtime to Go 1.23Dmitri Shuralyov
By now the supported and tested Go versions are Go 1.24 and 1.23. Update the website deployment to start using the Go 1.23 runtime. See https://cloud.google.com/appengine/docs/standard/lifecycle/support-schedule#go. Change-Id: I714843c6e984f3ff13049dd92e1b998c6265003e Reviewed-on: https://go-review.googlesource.com/c/website/+/655656 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2025-03-10cmd/golangorg: drop "at least Go 1.19" checkDmitri Shuralyov
The go.mod file enforces Go 1.23.0 or higher. Also drop the obsolete skip for /doc/godebug. For golang/go#54200. Change-Id: Iaab9bf954dfae72074b5c9b7cdfd5128871e62d6 Reviewed-on: https://go-review.googlesource.com/c/website/+/655655 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
2025-03-03_content/doc/go1.24: add release dateDmitri Shuralyov
The month and year alone should be enough granularity for the purpose of the introduction to Go 1.24. In this case, February 2025 refers to when the go1.24.0 major release came out, but we released pre-release versions even before then. Link to the dedicated release history page where full details and exact dates can be found. Add a test so we don't forget. For golang/go#68545. Fixes golang/go#54170. Change-Id: Ia2bceee9208094b0623add6696585592f4399893 Reviewed-on: https://go-review.googlesource.com/c/website/+/654015 Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2025-02-11cmd/golangorg: fix local run directory pathCherry Mui
FileInfo.Name returns the base name, not the path. Here we need the path. This makes "go run ." from cmd/golangorg directory work again. Change-Id: Iec7533758cf8a696a2696c28107caebf84bbed91 Reviewed-on: https://go-review.googlesource.com/c/website/+/648575 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2025-02-11cmd/golangorg, internal/history: update for Go 1.24.0 releaseDmitri Shuralyov
Start using the GOROOT content from release-branch.go1.24, and add an entry for the Go 1.24.0 release to the release history. Removing the draft notice from the release notes is done in CL 647797. For golang/go#68545. Change-Id: Ib30082d4dcc0afaadcf22ba07e5e5f7e3f4761bc Reviewed-on: https://go-review.googlesource.com/c/website/+/648498 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2024-12-16cmd/golangorg: redirect /issue(s) on tip.golang.orgDmitri Shuralyov
The /issue and its alias /issues subtrees were missed in CL 634915. Also group related subtrees together. For golang/go#58484. Change-Id: I598e2c7aa70f56bdfd3ec069347dca3d96f8e6d5 Reviewed-on: https://go-review.googlesource.com/c/website/+/636215 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2024-12-16cmd/googlegolangorg: add google.golang.org/open2opaque redirectMichael Stapelberg
Change-Id: I44e86f64ca742a0387bf5f6a449fc8c86ec1bb86 Reviewed-on: https://go-review.googlesource.com/c/website/+/636615 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Carlos Amedee <carlos@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Michael Stapelberg <stapelberg@google.com>
2024-12-10cmd/golangorg: redirect various dynamic content on tip.golang.orgRuss Cox
This makes links in package docs work better. Fixes golang/go#58484. Change-Id: Ie399bf94262b0aaeb5eed7c0ef18a2a938e9ef7c Reviewed-on: https://go-review.googlesource.com/c/website/+/634915 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2024-12-09cmd/googlegolangorg: mdd google.golang.org/genai to the list of modulesBen Kazemi
See Google-internal bugs 372231254 and 383152931. Change-Id: Ic57b5d6ff0d6bba0b3b4ecfb1fcab5ed26d7bfe5 Reviewed-on: https://go-review.googlesource.com/c/website/+/634715 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Eli Bendersky <eliben@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2024-12-06cmd/screentest: compare image sizesJonathan Amsterdam
The imgdiff package we use assumes the images are the same size. So check the sizes first. Also: - Fix a bug where we retry instead of failing immediately. - Make the default concurrency 1. Screen tests are flaky enough without adding concurrency. - Remove the check in sleep for integers. time.ParseDuration already does that. Change-Id: I63442d29c0846e3b6648eef993e8a113f4019bda Reviewed-on: https://go-review.googlesource.com/c/website/+/634078 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-12-05cmd/golangorg: suggest relative links for /issue/ and /wiki/ casesDmitri Shuralyov
The test already requires "https://go.dev/page" links to be written as relative "/page" ones; it looks like an oversight not to do that right away in these two cases. Change-Id: I81f16e6b30db31351cf4bbe941ed01de969d6cd3 Reviewed-on: https://go-review.googlesource.com/c/website/+/633855 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
2024-12-05all: remove unreachable codeSean Liao
While running go test -vet=all I saw a failure from unreachable code, which lead me to run deadcode on the entire repo. Change-Id: I20a7cd83f54595d12d46d1bdb714975e1efaf5e3 Reviewed-on: https://go-review.googlesource.com/c/website/+/633895 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-12-04cmd/golangorg: suggest working new issue link in TestAllDmitri Shuralyov
https://go.dev/issue/new already redirects to GitHub's issue tracker with the "/choose" suffix, and https://go.dev/issue/new/choose is 404. Improve the test to handle this case and suggest the right fixed URL. Change-Id: I15a7c80f0acbe3b24f834a6b87282b25cb4e4ea0 Reviewed-on: https://go-review.googlesource.com/c/website/+/633835 Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2024-12-03cmd/screentest: add retrypixels flagJonathan Amsterdam
Add a flag to enable retries when there are few differing pixels. Some screentests fail occasionally with very small pixel differences, like 11. There doesn't seem to be any underlying cause. You can't even see the pixels on a diff image. Retrying those cases when they arise seems to fix the problem. Change-Id: Ic9103ac1ede30ed611be933dfa970a49488049a2 Reviewed-on: https://go-review.googlesource.com/c/website/+/633175 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-11-26cmd/golangorg/testdatascreentest: fix learn testJonathan Amsterdam
Remove the Go version HTML from the screenshot so the test will pass. The version mismatch is an artifact of the test setup. Also, have screentest warn about using eval with quoted expressions. I was doing this and couldn't understand why my fix to the learn test wasn't working. Lastly, describe how we could add a feature that shows the result of evaluating each expression. My buggy version of this feature helped me diagnose the above problem, but a proper implementation is harder and not worth it now. Change-Id: I411717cd2aafab97193082a392bcd792bd3c7534 Reviewed-on: https://go-review.googlesource.com/c/website/+/631715 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-25cmd/screentest: fix double-close bugJonathan Amsterdam
The closure in waitForEvent can be called more than once. Make sure we only close the channel once. Change-Id: I5bde4d970bbda238d4cd3414234d45c957420fbd Reviewed-on: https://go-review.googlesource.com/c/website/+/631695 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-11-25cmd/screentest: miscellaneous minor changesJonathan Amsterdam
- Rename -u to -update to reduce chance of error. - Remove entire failure directory so that index.html is deleted too. - Tweak user output. - Replace url.JoinPath with a custom function that does not escape paths. - Fix bug where context is canceled when writing to GCS. Change-Id: I2762d4c226f8a0592e2720846ec118aeac49d0cf Reviewed-on: https://go-review.googlesource.com/c/website/+/630175 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-11-22cmd/screentest: doc headless-shell; improve outputJonathan Amsterdam
- Document the preference for headless-shell, the stripped-down Chrome binary. It is more reliable. - Clarify output, reduce vertical whitespace. - Fix race condition. Change-Id: I8d879bf4442a089e1b3eeb47074c76fe46e87a53 Reviewed-on: https://go-review.googlesource.com/c/website/+/628056 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-22cmd/screentest: remove special case for same URLJonathan Amsterdam
The special case added in a previous CL is not the problem. In general, waiting for components to render is a better solution. Change-Id: Iadecccea7862db0cbfcfc525392b8859b78dda6d Reviewed-on: https://go-review.googlesource.com/c/website/+/628055 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-20cmd/screentest: rename pathname to pathJonathan Amsterdam
That part of a URL is properly called a path. Change-Id: I4ce1765e99a3e2d76bb600b90cdc4fd6f6e320f1 Reviewed-on: https://go-review.googlesource.com/c/website/+/627601 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-20cmd/screentest: reorganize readTestsJonathan Amsterdam
Replace the local variables with a testcase value. Clone the testcase after each capture. Change-Id: I1fd94daa222eb699cca2adfbe4e8296e595e1b72 Reviewed-on: https://go-review.googlesource.com/c/website/+/627600 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-19cmd/screentest: fix and test filterJonathan Amsterdam
The filter wasn't considering the suffixes to a testname added by some capture directives. Also, remove the String method on testcase; it was breaking cmp.Diff output by showing only the test name in diffs. Change-Id: Ic24ac2a88e0ba008c2fe98e291dfe64f8d46f60d Reviewed-on: https://go-review.googlesource.com/c/website/+/627599 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-19cmd/screentest: check that every test ends with a captureJonathan Amsterdam
Change-Id: Iadc1843b71fe2688d0ff13b28210cef564d64e9f Reviewed-on: https://go-review.googlesource.com/c/website/+/627598 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-11-19cmd/screentest: simplify ReadTestJonathan Amsterdam
- Remove args struct. - Derive filename from test name. Change-Id: Ic3db71b23b06fd44e8511d3e27a9b43c9273c76c Reviewed-on: https://go-review.googlesource.com/c/website/+/627597 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-11-19cmd/screentest: rename outputURL to outputDirURLJonathan Amsterdam
Change-Id: I39b56db83ef60b899a3499acd2dce88269409089 Reviewed-on: https://go-review.googlesource.com/c/website/+/627596 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-19cmd/screentest: various cleanupsJonathan Amsterdam
Perform miscellaneous improvements to the code: refactoring, renaming, removing duplication, etc. Change-Id: Ibf8e89d51ef72583182faadd8d541c640e55d65a Reviewed-on: https://go-review.googlesource.com/c/website/+/627517 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-19cmd/screentest: clean directoriesJonathan Amsterdam
Delete the old test directory when re-running a test file. Implement rmdir for image writers to support this. Also factor out values common to all tests, and do some minor cleanup. Change-Id: Ie133c07874a634b015cbfe0d4faaa19ce9fc113d Reviewed-on: https://go-review.googlesource.com/c/website/+/627157 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
generated by cgit v1.3 (git 2.53.0) at 2026-04-15 07:45:06 +0000