diff options
| author | Jonathan Amsterdam <jba@google.com> | 2024-11-09 18:48:45 -0500 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2024-11-11 19:09:58 +0000 |
| commit | 340e7184cf0a42e3eff7b65df58240f5488c2a42 (patch) | |
| tree | 6681d52a097644032b586ab1c6994442784b789a /internal | |
| parent | 3a761022ad6ff0280a444482b7c8deb56f0ab372 (diff) | |
| download | go-x-website-340e7184cf0a42e3eff7b65df58240f5488c2a42.tar.xz | |
internal/screentest: get tests to pass
- Update chromedp to the latest version.
- Don't call chromedp concurrently if the hosts are the same
(as they are in these tests).
Change-Id: Ida58a5be4b9305d18e7e926bc3729da6326b5349
Reviewed-on: https://go-review.googlesource.com/c/website/+/626559
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'internal')
| -rw-r--r-- | internal/screentest/screentest.go | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/internal/screentest/screentest.go b/internal/screentest/screentest.go index 841fafaa..4c2478fe 100644 --- a/internal/screentest/screentest.go +++ b/internal/screentest/screentest.go @@ -116,6 +116,7 @@ package screentest import ( "bufio" "bytes" + "cmp" "context" "errors" "fmt" @@ -671,6 +672,16 @@ func (tc *testcase) run(ctx context.Context, update bool) (err error) { fmt.Fprintf(&tc.output, "test %s ", tc.name) var screenA, screenB *image.Image g, ctx := errgroup.WithContext(ctx) + // If the hosts are the same, chrome (or chromedp) does not handle concurrent requests well. + // This wouldn't make sense in an actual test, but it does happen in this package's tests. + urla, erra := url.Parse(tc.urlA) + urlb, errb := url.Parse(tc.urlA) + if err := cmp.Or(erra, errb); err != nil { + return err + } + if urla.Host == urlb.Host { + g.SetLimit(1) + } g.Go(func() error { screenA, err = tc.screenshot(ctx, tc.urlA, tc.outImgA, tc.cacheA, update) if err != nil { |