diff options
| author | Jonathan Amsterdam <jba@google.com> | 2024-11-11 10:54:44 -0500 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2024-11-15 14:25:10 +0000 |
| commit | d5b6a06e5ef0dadbf37df80f73c407550b8162b3 (patch) | |
| tree | d479d59d87e1e37b4a92f4e032aa64300df33de4 /cmd/golangorg | |
| parent | ffc202c92e8684f6f75dc53a8fcb47c623eb3435 (diff) | |
| download | go-x-website-d5b6a06e5ef0dadbf37df80f73c407550b8162b3.tar.xz | |
cmd/screentest: turn deprecations into errors
This is the first CL that makes breaking changes to screentest.
Breaking changes to commands are permitted by the Go compatibility
guarantee. Furthermore, this repo is at major version 0, and I found
no uses of screentest anywhere in the open source ecosystem or Google's
internal codebase, other than in this repo and x/pkgsite.
The changes include:
- Formerly deprecated script features, like the compare, output
and header directives, are now errors.
- The test and want URLs are now required, so they are arguments
instead of flags.
- Instead of taking a glob which is expanded by the program, screentest
now behaves like a normal Unix command and accepts a list of files,
leaving glob expansion to the shell. (The internal globbing was a
remnant of modeling the internal/screentest package on
internal/webtest, where globbing makes sense.)
Change-Id: Ie851705a5c5e37c1934c164360fb523f62888455
Reviewed-on: https://go-review.googlesource.com/c/website/+/627060
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'cmd/golangorg')
| -rwxr-xr-x | cmd/golangorg/screentest.sh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/cmd/golangorg/screentest.sh b/cmd/golangorg/screentest.sh index 7e67ff7b..3ffbd1dd 100755 --- a/cmd/golangorg/screentest.sh +++ b/cmd/golangorg/screentest.sh @@ -3,7 +3,7 @@ # Use of this source code is governed by a BSD-style # license that can be found in the LICENSE file. -go run ./cmd/screentest \ - -test http://localhost:6060/go.dev \ - -want https://go.dev \ - './cmd/golangorg/testdata/screentest/*' +# This script compares web pages generated by a golangorg web server running locally +# with the pages on the production go.dev server. + +go run ./cmd/screentest http://localhost:6060/go.dev https://go.dev ./cmd/golangorg/testdata/screentest/* |