diff options
| author | Russ Cox <rsc@golang.org> | 2023-07-28 13:53:30 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2023-08-03 04:10:03 +0000 |
| commit | e5f882dc959d83ed3c1dc413c468ea89d59c3c52 (patch) | |
| tree | 5e688163093289546dc46b1d6914f3528a8e6a1e | |
| parent | 1e75b26cba0e55a9f61c79dbb46459a4e6ddbd65 (diff) | |
| download | go-x-website-e5f882dc959d83ed3c1dc413c468ea89d59c3c52.tar.xz | |
cmd/golangorg: fix CachedURL, update rebuild template
The "not modified" response code is 304, not 206. Oops.
Use named constants to avoid similar mistakes in the future.
Also update rebuild template to show more version information.
For golang/go#57120.
For golang/go#58884.
Change-Id: I2c3ddf25cede0b5a853fa971226463a997f168c7
Reviewed-on: https://go-review.googlesource.com/c/website/+/515455
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
| -rw-r--r-- | _content/rebuild.html | 5 | ||||
| -rw-r--r-- | cmd/golangorg/server.go | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/_content/rebuild.html b/_content/rebuild.html index 8931be0a..cf59587c 100644 --- a/_content/rebuild.html +++ b/_content/rebuild.html @@ -55,8 +55,9 @@ The <code>-p=4</code> means to run up to four builds in parallel. {{$Report := json gorebuild}} {{with $Report}} -Using gorebuild from {{.Version}}<br><br> - +Gorebuild version {{.Version}}.<br> +Built with Go version {{.GoVersion}}, {{.GOOS}}-{{.GOARCH}}.<br> +<br> Rebuild started at {{(rfc3339 .Start).UTC.Format "2006-01-02 15:04:05"}} UTC.<br> Rebuild finished at {{(rfc3339 .End).UTC.Format "2006-01-02 15:04:05"}} UTC.<br> Elapsed time: {{((rfc3339 .End).Sub (rfc3339 .Start)).Round 1e9}}. diff --git a/cmd/golangorg/server.go b/cmd/golangorg/server.go index 2a7f66b0..7665efa1 100644 --- a/cmd/golangorg/server.go +++ b/cmd/golangorg/server.go @@ -855,13 +855,13 @@ func (c *CachedURL) Get() (data []byte, err error) { return nil, fmt.Errorf("loading rebuild report JSON: %v", err) } defer resp.Body.Close() - if resp.StatusCode == 206 { + if resp.StatusCode == http.StatusNotModified { // Unmodified. log.Printf("checked %s - unmodified", c.url) return c.data, c.err } log.Printf("reloading %s", c.url) - if resp.StatusCode != 200 { + if resp.StatusCode != http.StatusOK { return nil, fmt.Errorf("loading rebuild report JSON: %v", resp.Status) } c.etag = resp.Header.Get("Etag") |