| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2024-02-29 | git-codereview: improve haveGerritInternalv1.10.0 | Joshua Sing | |
| Use url.Parse and check URL components rather than performing imprecise string matching. This addresses a bug where git-codereview does not work when the Git origin ends with a forward slash. Note that the check for 'github.com' has been removed since the test for '.googlesource.com' already excludes it. Change-Id: I083bccdbacf2152cbfddd2407fb20afa47c8e91e Reviewed-on: https://go-review.googlesource.com/c/review/+/543495 Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Joel Sing <joel@sing.id.au> | |||
| 2015-03-18 | git-codereview: rewrite issue references | Josh Bleecher Snyder | |
| We have a single repo against which all issues are filed. GitHub supports closing issues in other repos, but it is easy to forget to use the magic syntax. To fix that, rewrite issue references in the commit msg hook. To that end, introduce a repo-level config file, located at REPOROOT/codereview.cfg. The config is always read from origin/master. Config lines are of the form "key: value". Lines beginning with # are comments. To designate a repo as the issues repo, add issuerepo: USERNAME/REPO to the config. Fixes golang/go#9273. Change-Id: I31ec98883641bbf0c149f3619769231f6a452512 Reviewed-on: https://go-review.googlesource.com/4131 Reviewed-by: Andrew Gerrand <adg@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> | |||
