| Age | Commit message (Collapse) | Author |
|---|
|
Google engineers are now required to use these access methods
instead of https://go.googlesource.com/, so recognize them as
aliases.
(It is possible for every engineer to configure their Git clients with
insteadOf clauses to hide these from the codereview plugin, but
it's far less error-prone to just handle it here.)
Change-Id: Ic1c9a6b45aa61b11ff25ce21bca6e49344974b04
Reviewed-on: https://go-review.googlesource.com/c/review/+/499923
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>
Run-TryBot: Russ Cox <rsc@golang.org>
|
|
Use a mutex in loadGerritOrigin to avoid race when called in parallel
by "git coderevew pending". Add a new initialized field so that the
code knows when auth has been initialized. Adjust tests accordingly.
The test is simply "go test -race".
Fixes golang/go#43670
Change-Id: Ifb060fca6ed463f1d11a2959d03fca5e14e238c6
Reviewed-on: https://go-review.googlesource.com/c/review/+/287012
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
|
|
The 'write' helper function previously assumed file permission 0666.
We don't actually need these files to be world-writable, but we do
need specific ones — scripts executed as Git commit hooks — to be
executable, at least on certain platforms.
Also use t.Helper() to produce more useful log lines for failures.
(That was added in order to diagnose TryBot failures.)
Fixes golang/go#32836
Change-Id: I2d670563f42778ef8cf645445420756599c37ac6
Reviewed-on: https://go-review.googlesource.com/c/review/+/211477
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
|
|
http.cookiefile is a pathname value, which means a leading tilde is
automatically expanded by git-config.
https://git-scm.com/docs/git-config#git-config-httpcookieFile
https://git-scm.com/docs/git-config#git-config-pathname
Change-Id: Ia208b8a8a7dd5e07de58481b9010051569d0d8c8
Reviewed-on: https://go-review.googlesource.com/115576
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
|
This test was incorrectly passing when it should be dying, because
I have a global http.cookiefile defined that this test falls back to
using if a local http.cookiefile isn't configured.
Fix this by defining a local, invalid cookiefile, which causes
git/git-codereview to error out.
Change-Id: Ia538d3e8af53b849d672419582c21ba8a6fdbbdd
Reviewed-on: https://go-review.googlesource.com/49293
Reviewed-by: Andrew Bonventre <andybons@golang.org>
|
|
Change-Id: I38a58a2fb1bf6f4840cca8fe24aaa85ad3d6289e
Reviewed-on: https://go-review.googlesource.com/21252
Run-TryBot: Andrew Gerrand <adg@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
The git-review module is useful for other gerrit sites. Some
host gerrit under a sub-path. Add tests for both googlesource.com
repos and non-googlesource.com repos.
Change-Id: If2848128d6957db61ac50cbab7e6927da431002b
Reviewed-on: https://go-review.googlesource.com/20553
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Andrew Gerrand <adg@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
|
|
Change-Id: Ifdbfc63caa7c1afa42d05c2f91a6168a867e8056
Reviewed-on: https://go-review.googlesource.com/2113
Reviewed-by: Austin Clements <austin@google.com>
|
