aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-15git-codereview: fix buglet in 'reword' related to work treesThan McIntosh
The reword command was trying to store a saved messages file in the subdirectory .git in the repo root; this doesn't work well if multiple work trees are in use and the user is working in a non-main work tree. Use "git rev-parse --git-path ." instead of "git rev-parse --show-top-level" to find the location for the saved messages file. Fixes golang/go#43695. Change-Id: Ie0b3e810ad585fe1c18805f4070736335a2ef2b5 Reviewed-on: https://go-review.googlesource.com/c/review/+/283646 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Trust: Than McIntosh <thanm@google.com>
2021-01-13git-codereview: add sync-branch -merge-back-to-parentRuss Cox
Dev branches come to an end. Making sync-branch help that process instead of forcing people to follow a playbook will help avoid mistakes. The flag name was chosen to be very unlikely to be used accidentally, and the commit subject and message both are distinct to make clear to reviewers what they are being asked to +2. The Merge List is also included in full and is likely to be quite large, yet another signal for everyone involved about the magnitude and weight of the change. Change-Id: I91cdda2b85cd3811711a339f4f3290fee109022e Reviewed-on: https://go-review.googlesource.com/c/review/+/282534 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-01-13git-codereview: clean up detached HEAD modeRuss Cox
Long ago I decided to return origin/HEAD from b.OriginBranch in detached HEAD mode, thinking it would cause obvious failures. But the joke was on me - origin/HEAD is a real thing in git, and HEAD tracking origin/HEAD is not the right answer on dev branches. Now that each branch's codereview.cfg typically has the branch info we need, we can use that in detached HEAD mode to be able to provide useful displays in commands like "git pending". And we can be careful not to do that when we don't know the actual branch. This commit cleans all that up. Change-Id: I0e59bcb6f9b61e0cdce7a27299b7f29fef8e7048 Reviewed-on: https://go-review.googlesource.com/c/review/+/282616 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-01-13git-codereview: add reword commandRuss Cox
Quoting the new docs: The reword command edits pending commit messages. git codereview reword [commit...] Reword opens the editor on the commit message for each named commit in turn. When all the editing is finished, it applies the changes to the pending commits. If no commit is listed, reword applies to the most recent pending commit. Reword is similar in effect to running “git codereview rebase-work” and changing the script action for the named commits to “reword”, or (with no arguments) to “git commit --amend”, but it only affects the commit messages, not the state of the git staged index, nor any checked-out files. This more careful implementation makes it safe to use when there are local changes or, for example, when tests are running that would be broken by temporary changes to the checked-out tree, as would happen during “git codereview rebase-work”. Change-Id: I38ac939b8530bf237c6cafb911f2b17d22eaca60 Reviewed-on: https://go-review.googlesource.com/c/review/+/279718 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-01-13git-codereview: new sync-branch and related fixesRuss Cox
This CL adds a new command, "git codereview sync-branch", which does the appropriate git merge for the current branch. This CL also fixes a bug in "git codereview branchpoint", and therefore also commands like "git codereview pending", which was getting the branchpoint wrong for merges, with the effect that a merge showed too many pending CLs. This CL also fixes a bug in "git codereview change", which was formerly willing to run "git checkout" with a pending merge, which had the effect of flattening the merge mysteriously. Now it detects the merge and refuses to run. All of this should make merges easier and less error-prone as we use dev branches more often. With the earlier CL in this stack that allows working directly on local branches, this is now a great way to run a merge updating dev.regabi: git change dev.regabi git sync-branch (with appropriate aliases to avoid typing "codereview"). Fixes golang/go#26201. Change-Id: Ic24603123ca5135a72004309f5bb208ff149c9eb Reviewed-on: https://go-review.googlesource.com/c/review/+/279772 Trust: Russ Cox <rsc@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-01-07git-codereview: make git change handle GitHub PRsRuss Cox
Change-Id: Iab0417d14a29dce1a43f30f1f357d3f71dfdb51f Reviewed-on: https://go-review.googlesource.com/c/review/+/279721 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-01-07git-codereview: allow work on main branchesRuss Cox
The only reason not to allow work on branches named for the origin branches is to preserve them for "git change main; git change new" to make a new branch tracking main. But we can still do that and allow commits on main - we just have to use the branchpoint as the root of the new branch. Now people can work on "main" (or "dev.regabi") if that suits them. In particular, if you're doing merges, it's nice to be on "dev.regabi" and know for sure that's the branch you're working on. Change-Id: I8e9458793c30857a5c00e6bfd4f1cb41adbbe637 Reviewed-on: https://go-review.googlesource.com/c/review/+/279874 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Austin Clements <austin@google.com>
2021-01-07git-codereview: add a few more testsRuss Cox
Change-Id: I17ad065e8b4c1eb00cdd2f17af82be76bae4fc09 Reviewed-on: https://go-review.googlesource.com/c/review/+/279717 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-01-07git-codereview: update tests for "main" branch defaultRuss Cox
"git init ." leaves me on "main" now, not "master". Update tests to expect that, and update the "tracking" message too (otherwise the tests fail). Because not all gits agree about the initial branch name, set it explicitly too in the test. Fixes #42926. Change-Id: If3adb3bb53beba9efcd75cad0f081f59fba85fe7 Reviewed-on: https://go-review.googlesource.com/c/review/+/279873 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Austin Clements <austin@google.com>
2020-12-22git-codereview: clean up usage message, docsRuss Cox
Change-Id: I634a9d47401c1000bcb38e9dd7e84296a3de00e6 Reviewed-on: https://go-review.googlesource.com/c/review/+/254746 Trust: Russ Cox <rsc@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2020-09-11git-codereview: add mail -trust to set Trust+1 voteRuss Cox
The expectation is that approvers will change their .gitconfig to define mail as codereview mail -trust. For golang/go#40699. Change-Id: I2a1040bf3f1c7248e9c361e1f2a83c17870b1df5 Reviewed-on: https://go-review.googlesource.com/c/review/+/254421 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-09-11git-codereview: change upstream fallback to try main before masterRuss Cox
Will help when we start using origin/main in Go repos. (Tested using git-codereview against github.com/google/licensecheck.) Change-Id: I564a0f6863938a3196dea3df9e8af240faba91fc Reviewed-on: https://go-review.googlesource.com/c/review/+/254420 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-05-15git-codereview: add -wip flag to mail commandPaul Jolly
Add a -wip flag to the mail command to set the status of a change to work-in-progress. Per: https://gerrit-review.googlesource.com/Documentation/intro-user.html#wip Fixes golang/go#20991 Change-Id: I227beccb55570949e9b0f487d5394855611a118a Reviewed-on: https://go-review.googlesource.com/c/review/+/233237 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Andrew Bonventre <andybons@golang.org>
2020-03-11git-codereview: remove use of MergeableRuss Cox
Mergeable has been removed from the Gerrit API - it was too expensive to maintain, had racy semantics, and was too little used. As of right now, git submit fails because it doesn't see "mergeable":true in the JSON. Remove the use of it in git-codereview. Change-Id: I12c821b9dbc44183a689d510dd20104eab5a0043 Reviewed-on: https://go-review.googlesource.com/c/review/+/222937 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
2020-01-15git-codereview: add mail -nokeycheck optionBrad Fitzpatrick
This adds a flag to set git push -o nokeycheck. This is an alternative to CL 163158 (to always do it) and CL 81937 (which adds a broader flag without much in the way of guidance of how to use it) Change-Id: I42b1c047ac92aeaea98c0838738e265ffdca0108 Reviewed-on: https://go-review.googlesource.com/c/review/+/214918 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2019-12-16git-codereview: write hooks with execute permission in testsBryan C. Mills
The 'write' helper function previously assumed file permission 0666. We don't actually need these files to be world-writable, but we do need specific ones — scripts executed as Git commit hooks — to be executable, at least on certain platforms. Also use t.Helper() to produce more useful log lines for failures. (That was added in order to diagnose TryBot failures.) Fixes golang/go#32836 Change-Id: I2d670563f42778ef8cf645445420756599c37ac6 Reviewed-on: https://go-review.googlesource.com/c/review/+/211477 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>
2019-11-12git-codereview: pick up URL-specific cookieFile configDaniel Lublin
Example config: [http "https://go.googlesource.com"] cookiefile = ~/.gitcookies-googlesource The --get-urlmatch option falls back to non-URL-specific config. Fixes golang/go#35496 Change-Id: I2410ff5b55e2bf9214fcc2cad16095facec78434 Reviewed-on: https://go-review.googlesource.com/c/review/+/206697 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-11-09git-codereview: override existing locale with LC_ALL=CEric Lagergren
The git-codereview tool shells out to git, then parses the output. However, because git respects a user's locale settings its output might not be in English, confusing git-codereview. Explicitly set the LC_ALL environment variable to the "C" locale, which is a version of US English that should be on all machines. Fixes golang/go#33895 Change-Id: Id06a81046dba58131fc1de602dd9add687846da1 Reviewed-on: https://go-review.googlesource.com/c/review/+/192237 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-09-25git-codereview: do not install hooks for help and invalid commandsAnderson Queiroz
Fixes golang/go#34320 Change-Id: I53348a027d1a33d1614d2bad32c75eaca52fac8a Reviewed-on: https://go-review.googlesource.com/c/review/+/195897 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
2019-08-30go.mod: add go version directiveBryan C. Mills
(I mostly just wanted to make a trivial change to this repo to clear out the failure cells for misconfigured builders on the landing page of https://build.golang.org.) Updates golang/go#32836 Change-Id: Ibcea7e75912ca377fd78cef37d8beb29ab8b83d3 Reviewed-on: https://go-review.googlesource.com/c/review/+/192557 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2019-05-08git-codereview: add a hint about mailing the whole chain of changesYury Smolsky
"mail HEAD" will mail every commit between HEAD and branching point. Fixes golang/go#16034 Change-Id: If95aece584f2a324f866c64770f7361ddb3e7636 Reviewed-on: https://go-review.googlesource.com/c/review/+/148137 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
2019-04-22git-codereview: do not require gofmt for testdata filesRebecca Stambler
We use Go files as testdata for gopls, specifically as test cases for formatting and imports. Change-Id: Ie4ed6097960eb0eb3d5c1767b8b76bed147c81e0 Reviewed-on: https://go-review.googlesource.com/c/review/+/173339 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-03-25git-codereview: make commit-msg hook play nicely with other systemsAndrew Gerrand
Gerrit requires 'Change-Id:' lines to be included in each commit message, but they are not the only kind of 'metadata line' that might appear in a commit message. Metadata lines observed by other systems include 'Bug:' and 'Signed-off-by:'. This change ensures that the commit-msg hook adds its 'Change-Id:' line to the set of metadata lines, separated only by a single linefeed, rather than creating a new set by inserting two line feeds. Change-Id: Ia3bdce6f52f663685eea1e648874ef81ddb2bd91 Reviewed-on: https://go-review.googlesource.com/c/review/+/169097 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-03-13all: add a go.mod fileMichael Matloob
This change adds a go.mod file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. There is no go.sum file because this repo has no dependencies. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: Ie24d8bb73104e8299d3d22cf6c72a295036804f7 Reviewed-on: https://go-review.googlesource.com/c/review/+/162916 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-01-22git-codereview: do not check vendor folder with gofmtDaniel Theophanes
The go command already skips the vendor folder when running go fmt. The "go mod vendor" command updates all vendor packages at once, so this becomes more of an issue. Change-Id: I0b2d51d2f1f01998e9ca7a244af491bd18150e8a Reviewed-on: https://go-review.googlesource.com/c/158839 Run-TryBot: Daniel Theophanes <kardianos@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
2018-11-29git-codereview: recognize rpc:// and sso:// as Gerrit originsRuss Cox
Change-Id: I43e14ef54a5c9936f3c80fa87e9b9f0ed468b05a Reviewed-on: https://go-review.googlesource.com/c/151737 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
2018-11-08git-codereview: add -m optionJean de Klerk
The -m option allows a user to specify an inline commit message. This is useful for a few reasons; primary among them are the ability to easily automate a `git change` flow (e.g. in a CI/CD workflow) and the ease of creating one-liner commits (e.g. "regen protos"). Fixes golang/go#24912 Change-Id: Ie06886c74552ec615623c2faac285a1896bdac06 Reviewed-on: https://go-review.googlesource.com/c/107625 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Yury Smolsky <yury@smolsky.by> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
2018-10-14README.md: correct installation instructionsJohan Brandhorst
Fixes golang/go#28196 Change-Id: I5fa57b039798c172a0b2610d8278077aca15512e Reviewed-on: https://go-review.googlesource.com/c/141802 Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com> Reviewed-by: Rob Pike <r@golang.org>
2018-08-23git-codereview: remove unused cruftJean de Klerk
Change-Id: If9b3494162311743d9ea84dc9dc26163d6563c9c Reviewed-on: https://go-review.googlesource.com/131055 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-08-07Fix erroneous error message saying "git sync"Issac Trotts
It's `git codereview sync`. Change-Id: Ia55db061d0cf35cb56c6faba7bb1569e621f9b57 GitHub-Last-Rev: 539f4d0750845686c1b0d3720f598f489dc3530f GitHub-Pull-Request: golang/review#11 Reviewed-on: https://go-review.googlesource.com/128075 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-07-02git-codereview: add -hashtag flag to the mail commandJesús Espino
It is now possible to mail a CL with any number of hashtags. Fixes golang/go#26149 Change-Id: I231826f95ec357bd448de12a9a5aa30e581c3bb3 Reviewed-on: https://go-review.googlesource.com/121798 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-06-17git-codereview: highlight branchpoint commandMark Fischer
Put text between title and command. Fixes: golang/go#19077 Change-Id: I6fe1cc3081d6aa939cd46de11fa208b4a0d6b26e Reviewed-on: https://go-review.googlesource.com/119339 Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
2018-06-12git-codereview: use --path option of git config to expand ~Dmitri Shuralyov
This change largely reverts CL 115576, and applies a simpler version. It uses the --path option of git config to achieve equivalent behavior. The --path option is available as far back as git 1.7.0, according to https://git-scm.com/docs/git-config/1.7.0, making it safe to rely on: The type specifier can be [...] --path, which does some path expansion (see --path below). If no type specifier is passed, no checks or transformations are performed on the value. --path git-config will expand leading ~ to the value of $HOME, and ~user to the home directory for the specified user. Change-Id: I74bb543ab488d24fe4cf66da0c6dbc087dc368a6 Reviewed-on: https://go-review.googlesource.com/116016 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-06-05git-codereview: check for https:// origin only for googlesource urlsMichael Matloob
Change-Id: Idc3ce48cb706959738c6045c3e58904399ca24f3 Reviewed-on: https://go-review.googlesource.com/116361 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-06-01git-codereview: support ~ in http.cookiefileFilippo Valsorda
http.cookiefile is a pathname value, which means a leading tilde is automatically expanded by git-config. https://git-scm.com/docs/git-config#git-config-httpcookieFile https://git-scm.com/docs/git-config#git-config-pathname Change-Id: Ia208b8a8a7dd5e07de58481b9010051569d0d8c8 Reviewed-on: https://go-review.googlesource.com/115576 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-04-04git-codereview: pull punctuation marks out of quotation marksMarvin Stenger
Command-line commands listed in the documentation are put in quotation marks. In some places punctuation marks were also placed between the quotation marks, which could suggest that they are part of the command. So we pull those punctuation marks out. Change-Id: I7057747a0f045394976f04f8be387e18805c22e1 Reviewed-on: https://go-review.googlesource.com/104657 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2018-03-30git-codereview: forbid mailing editor temp filesYury Smolsky
"mail" command rejects *~, #*# and .#* filenames. Also it should reject commit messages with non-printable characters, because these are impossible to spot in the review. For golang/go#24139 Change-Id: I3544e3c34c5ac9f55a7808264de4535bc455bd0a Reviewed-on: https://go-review.googlesource.com/101755 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
2018-03-14CONTRIBUTING.md: remove note about not accepting Pull RequestsAndrew Bonventre
Updates golang/go#24185 Change-Id: I74b024457ece54c6b02c3b017cb003142b75b4f8 Reviewed-on: https://go-review.googlesource.com/100690 Reviewed-by: Andrew Bonventre <andybons@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2018-01-22review/git-codereview: use more verbosity to signal verbose pullsRob Pike
The -v flag in review is already used to signal more verbose output. With one -v, git sync shows the git commands. After this change, two -vs (or -v=2) causes git sync to pass -v to git pull as well. Also mention that -v is a counter not a boolean in the documentation. Change-Id: I584068f05c2298be6ae2e6ae17a0b817dc6a092f Reviewed-on: https://go-review.googlesource.com/88875 Reviewed-by: Andrew Gerrand <adg@golang.org>
2017-12-15git-codereview: fix vet warning to fix build on Go 1.10Brad Fitzpatrick
Change-Id: Ib4cee24d5b70f99dfbebf0aa05c85be6164ba835 Reviewed-on: https://go-review.googlesource.com/84216 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2017-11-29git-codereview: fix Go 1.8 t.Helper fixBrad Fitzpatrick
Don't add a new stack frame. Thanks to Dominik Honnef. Change-Id: I817f95fb23e80dcdff733a7b35fa72bac89958f8 Reviewed-on: https://go-review.googlesource.com/80795 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dominik Honnef <dominik@honnef.co>
2017-11-27git-codereview: fix test compilation error on Go 1.8Brad Fitzpatrick
These tests depended on Go 1.9's t.Helper. Change-Id: Ib8196e24f8508b4b2891cd1467dd9954bc5d8de5 Reviewed-on: https://go-review.googlesource.com/77932 Reviewed-by: Dominik Honnef <dominik@honnef.co>
2017-11-16git-codereview: add support for DΟ NΟT MAILRuss Cox
Also create a local DΟ NΟT SUBMIT check, although the Gerrit server is also taking care of that. While we're here, make fixup! and squash! commits non-mailable as well. (In the all caps text above the big Os are really Omicrons. Otherwise the CL would not be mailable or submittable.) Change-Id: Id1a9806b0d395d1a0bfc50ed7d7d22c64a48a2f1 Reviewed-on: https://go-review.googlesource.com/76877 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
2017-11-10git-codereview: overlap 'git fetch -q' with Gerrit queries in pendingRuss Cox
Right now 'git fetch -q' takes about one second because of Gerrit advertising far too many refs. Overlap the fetch with all the other work, to at least reduce the overall time for 'git pending'. The Gerrit team is aware of the refs advertisement problem and a fix is planned for the next few months. That fix will speed things up even further. Change-Id: Iad57da9f1af1c6eae144fe28e5f96f79234bf3cd Reviewed-on: https://go-review.googlesource.com/67572 Reviewed-by: Austin Clements <austin@google.com>
2017-11-10git-codereview: batch GerritChange info fetches during pendingRuss Cox
This speeds pending a bit by reducing the number of round trips to the Gerrit server when you have a stack of CLs. Change-Id: I456e1a8739b9b6586f4e05c1a5442f402e440a79 Reviewed-on: https://go-review.googlesource.com/67571 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
2017-10-06git-codereview: specify a dummy cookie fileKevin Burke
This test was incorrectly passing when it should be dying, because I have a global http.cookiefile defined that this test falls back to using if a local http.cookiefile isn't configured. Fix this by defining a local, invalid cookiefile, which causes git/git-codereview to error out. Change-Id: Ia538d3e8af53b849d672419582c21ba8a6fdbbdd Reviewed-on: https://go-review.googlesource.com/49293 Reviewed-by: Andrew Bonventre <andybons@golang.org>
2017-10-02git-codereview: avoid Gerrit timeout for missing Change-Id during pendingRuss Cox
If a commit is missing a Change-Id line, pending queries https://go-review.googlesource.com/a/changes/go~master~?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS (that's go~master~CHANGEID?... with CHANGEID=""), which must cause Gerrit to iterate over all possible CLs or something like that, because it takes forever. Don't bother: if the commit we care about has no Change-Id, it is by definition not on the server at all. This makes 'git pending' not just hang when you have a commit without a Change-Id. Change-Id: I548a51b4190db723538af35ea6a14169861d6bc3 Reviewed-on: https://go-review.googlesource.com/67570 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
2017-09-27README: add better descriptionKevin Burke
Move the README to README.md so Gerrit can render it; currently Gerrit only renders files named exactly "README.md" (for example at https://go.googlesource.com/go). Add more links to the README explaining how to file issues, how to submit code changes, where to download the code to and how to get it. Hopefully this should help people who go to https://go.googlesource.com/review or https://github.com/golang/review figure out how to get started with development. Change-Id: Ie490adc9126b759f81af2a526e9e05270d3525e6 Reviewed-on: https://go-review.googlesource.com/49871 Reviewed-by: Kevin Burke <kev@inburke.com>
2017-07-17git-codereview: create hooks directory if it doesn't existMarko Mudrinic
Fixes golang/go#21028 On some versions of Git, "git init" will not create ".git/hooks directory", causing "git change" to fail. This fix will check if the hooks directory exists, and if not, create it. Change-Id: I6a9e688740fde8701e5d48630686039c8ebf4172 Reviewed-on: https://go-review.googlesource.com/49070 Reviewed-by: Kevin Burke <kev@inburke.com>
2017-06-07git-codereview: update help text to add -trybotDaniel Martí
It was added to the godoc in https://golang.org/cl/24960, but that CL missed the help text given in "git-codereview help". Briefly mention it there too. Change-Id: I6905b3f98f4092ed34609596bb875e88cb00d480 Reviewed-on: https://go-review.googlesource.com/41693 Reviewed-by: Ian Lance Taylor <iant@golang.org>
generated by cgit v1.3 (git 2.53.0) at 2026-04-15 01:52:36 +0000