diff options
| author | Rebecca Stambler <rstambler@golang.org> | 2019-04-22 17:52:48 -0400 |
|---|---|---|
| committer | Rebecca Stambler <rstambler@golang.org> | 2019-04-22 22:03:18 +0000 |
| commit | 83908358f3a5c0332c3043570ce65ab14ff3d087 (patch) | |
| tree | 7fc5bf4489e39cfffbd62a88e6903006831cff07 | |
| parent | 7744f6d7ac193720bb483dc2a2c266504b33d1a9 (diff) | |
| download | go-x-review-83908358f3a5c0332c3043570ce65ab14ff3d087.tar.xz | |
git-codereview: do not require gofmt for testdata files
We use Go files as testdata for gopls, specifically as test cases for
formatting and imports.
Change-Id: Ie4ed6097960eb0eb3d5c1767b8b76bed147c81e0
Reviewed-on: https://go-review.googlesource.com/c/review/+/173339
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
| -rw-r--r-- | git-codereview/gofmt.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/git-codereview/gofmt.go b/git-codereview/gofmt.go index 12ea801..f47c43d 100644 --- a/git-codereview/gofmt.go +++ b/git-codereview/gofmt.go @@ -348,6 +348,9 @@ func gofmtRequired(file string) bool { if strings.HasPrefix(file, "vendor/") || strings.Contains(file, "/vendor/") { return false } + if strings.HasPrefix(file, "testdata/") || strings.Contains(file, "/testdata/") { + return false + } if !strings.HasPrefix(file, "test/") { return true } |