diff options
| author | Yury Smolsky <yury@smolsky.by> | 2018-03-21 01:23:00 +0200 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2018-03-30 21:38:54 +0000 |
| commit | febe82b3542e335479ef0e8a401a0e95f070fa41 (patch) | |
| tree | b3d746400bde7ae847f6c7e8d00ca929c6ba06c5 /git-codereview/util_test.go | |
| parent | 34696713d8ce9c6e709a50d8192fd973246a30e9 (diff) | |
| download | go-x-review-febe82b3542e335479ef0e8a401a0e95f070fa41.tar.xz | |
git-codereview: forbid mailing editor temp files
"mail" command rejects *~, #*# and .#* filenames.
Also it should reject commit messages with non-printable characters,
because these are impossible to spot in the review.
For golang/go#24139
Change-Id: I3544e3c34c5ac9f55a7808264de4535bc455bd0a
Reviewed-on: https://go-review.googlesource.com/101755
Run-TryBot: Yury Smolsky <yury@smolsky.by>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'git-codereview/util_test.go')
| -rw-r--r-- | git-codereview/util_test.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/git-codereview/util_test.go b/git-codereview/util_test.go index 133c93a..ab8dced 100644 --- a/git-codereview/util_test.go +++ b/git-codereview/util_test.go @@ -90,6 +90,12 @@ func (gt *gitTest) work(t *testing.T) { doWork(t, gt.nwork, gt.client, "file", "23456789") } +func (gt *gitTest) workFile(t *testing.T, file string) { + // make local change on client in the specific file + gt.nwork++ + doWork(t, gt.nwork, gt.client, file, "23456789") +} + func (gt *gitTest) serverWork(t *testing.T) { // make change on server // duplicating the sequence of changes in gt.work to simulate them |