diff options
| author | Tobias Klauser <tklauser@distanz.ch> | 2021-12-03 20:11:11 +0100 |
|---|---|---|
| committer | Tobias Klauser <tobias.klauser@gmail.com> | 2021-12-03 21:50:33 +0000 |
| commit | b8ead204a2e00eca3f1554da0b908d1d7b7afb9f (patch) | |
| tree | 9cdf67d000154fb147b0883cb755bd76b4523a01 /git-codereview/sync_test.go | |
| parent | 4305ba78f05fd75ba1bc3be8457fcc2501da2c5e (diff) | |
| download | go-x-review-b8ead204a2e00eca3f1554da0b908d1d7b7afb9f.tar.xz | |
git-codereview: don't sign git tags
For users who set tag.gpgSign=true in their git configuration,
git-codereview mail currently fails to create the .mailed git tag
because a signed git tag always requires a message:
fatal: no tag message?
(running: git tag -f foobar.mailed cf87726ac456)
/home/tklauser/go/bin/git-codereview: exit status 128
Fix this by overriding the tag.gpgSign configuration using git tag
--no-sign. There is no point in having these tags signed as they should
never leave the local system.
Change-Id: I8b7ddf3aa7709e6ea06e4d5add6cd581e9ec2e37
Reviewed-on: https://go-review.googlesource.com/c/review/+/369194
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'git-codereview/sync_test.go')
| -rw-r--r-- | git-codereview/sync_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/git-codereview/sync_test.go b/git-codereview/sync_test.go index 0d3978d..6470c5e 100644 --- a/git-codereview/sync_test.go +++ b/git-codereview/sync_test.go @@ -315,7 +315,7 @@ func TestSyncBranchMergeBack(t *testing.T) { testNoStdout(t) testPrintedStderr(t, "git push -q origin HEAD:refs/for/main", - "git tag -f dev.branch.mailed", + "git tag --no-sign -f dev.branch.mailed", ) } @@ -393,6 +393,6 @@ func TestSyncBranchConflict(t *testing.T) { testNoStdout(t) testPrintedStderr(t, "git push -q origin HEAD:refs/for/dev.branch", - "git tag -f dev.branch.mailed", + "git tag --no-sign -f dev.branch.mailed", ) } |