diff options
| author | Austin Clements <austin@google.com> | 2016-02-05 11:19:05 -0500 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2016-02-05 19:55:13 +0000 |
| commit | 36fe892ba0a999ea6698a694caf1bdec9ba2417b (patch) | |
| tree | 922b39e9b4ec6e2d3edb6d5137ce1ede6f924e51 /git-codereview/review.go | |
| parent | a8389558ab17f14c5ab75fbdec70e3814a42f09f (diff) | |
| download | go-x-review-36fe892ba0a999ea6698a694caf1bdec9ba2417b.tar.xz | |
git-codereview: accept any commit spelling for mail and submit
Currently the mail and submit subcommands only accept commit hashes.
This makes them inconsistent with other git commands (git is hard
enough without having to remember another convention) and makes
working with multi-commit branches cumbersome.
Change mail and submit to accept any standard commit spelling. In
particular, this makes it possible to use HEAD-relative names: "git
mail HEAD" sends the whole current branch. We still require that the
named commit be pending on the current branch to avoid accidentally
naming a completely unrelated commit.
Change-Id: If84d315e0fc32118a5283adfbca7a3b56f3c098c
Reviewed-on: https://go-review.googlesource.com/19271
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'git-codereview/review.go')
| -rw-r--r-- | git-codereview/review.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/git-codereview/review.go b/git-codereview/review.go index f4db94a..15766ef 100644 --- a/git-codereview/review.go +++ b/git-codereview/review.go @@ -77,9 +77,11 @@ Available commands: Every other operation except help also does this, if they are not already installed. - mail [-f] [-r reviewer,...] [-cc mail,...] + mail [-f] [-r reviewer,...] [-cc mail,...] [commit] Upload change commit to the code review server and send mail requesting a code review. + If there are multiple commits on this branch, upload commits + up to and including the named commit. If -f is specified, upload even if there are staged changes. The -r and -cc flags identify the email addresses of people to do the code review and to be CC'ed about the code review. @@ -95,7 +97,7 @@ Available commands: If -l is specified, only use locally available information. If -s is specified, show short output. - submit [-i | commit-hash...] + submit [-i | commit...] Push the pending change to the Gerrit server and tell Gerrit to submit it to the master branch. |