aboutsummaryrefslogtreecommitdiff
path: root/git-codereview/pending.go
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2015-02-11 14:16:45 -0500
committerRuss Cox <rsc@golang.org>2015-02-12 15:55:02 +0000
commitaeda9e8dd037ca116e6055b82264e55cf83b4dbe (patch)
tree082e82418f8689f4875be87975b54e32603cb635 /git-codereview/pending.go
parent4343dcafaee32a85932cb983b80a12ac5809990a (diff)
downloadgo-x-review-aeda9e8dd037ca116e6055b82264e55cf83b4dbe.tar.xz
git-codereview: hide +0 scores and +0 labels except Code-Review
Otherwise the list of reviewers is repeated for every label. This is happening now that we have trybot labels. Change-Id: Ie1fe0369d5944319c67fc9182ff3afbfd366687c Reviewed-on: https://go-review.googlesource.com/4570 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
Diffstat (limited to 'git-codereview/pending.go')
-rw-r--r--git-codereview/pending.go7
1 files changed, 6 insertions, 1 deletions
diff --git a/git-codereview/pending.go b/git-codereview/pending.go
index deda834..94b395c 100644
--- a/git-codereview/pending.go
+++ b/git-codereview/pending.go
@@ -292,10 +292,15 @@ func cmdPending(args []string) {
maxValue = x.Value
}
}
+ // Unless there are scores to report, do not show labels other than Code-Review.
+ // This hides Run-TryBot and TryBot-Result.
+ if minValue >= 0 && maxValue <= 0 && name != "Code-Review" {
+ continue
+ }
fmt.Fprintf(&buf, "\t%s:\n", name)
for score := maxValue; score >= minValue; score-- {
who := byScore[score]
- if len(who) == 0 {
+ if len(who) == 0 || score == 0 && name != "Code-Review" {
continue
}
sort.Strings(who)