diff options
| author | Tobias Klauser <tklauser@distanz.ch> | 2021-12-03 20:11:11 +0100 |
|---|---|---|
| committer | Tobias Klauser <tobias.klauser@gmail.com> | 2021-12-03 21:50:33 +0000 |
| commit | b8ead204a2e00eca3f1554da0b908d1d7b7afb9f (patch) | |
| tree | 9cdf67d000154fb147b0883cb755bd76b4523a01 /git-codereview/mail.go | |
| parent | 4305ba78f05fd75ba1bc3be8457fcc2501da2c5e (diff) | |
| download | go-x-review-b8ead204a2e00eca3f1554da0b908d1d7b7afb9f.tar.xz | |
git-codereview: don't sign git tags
For users who set tag.gpgSign=true in their git configuration,
git-codereview mail currently fails to create the .mailed git tag
because a signed git tag always requires a message:
fatal: no tag message?
(running: git tag -f foobar.mailed cf87726ac456)
/home/tklauser/go/bin/git-codereview: exit status 128
Fix this by overriding the tag.gpgSign configuration using git tag
--no-sign. There is no point in having these tags signed as they should
never leave the local system.
Change-Id: I8b7ddf3aa7709e6ea06e4d5add6cd581e9ec2e37
Reviewed-on: https://go-review.googlesource.com/c/review/+/369194
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'git-codereview/mail.go')
| -rw-r--r-- | git-codereview/mail.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-codereview/mail.go b/git-codereview/mail.go index b7fc9f9..2e6c6a6 100644 --- a/git-codereview/mail.go +++ b/git-codereview/mail.go @@ -169,7 +169,7 @@ func cmdMail(args []string) { // There is no conflict with the branch names people are using // for work, because git change rejects any name containing a dot. // The space of names with dots is ours (the Go team's) to define. - run("git", "tag", "-f", b.Name+".mailed", c.ShortHash) + run("git", "tag", "--no-sign", "-f", b.Name+".mailed", c.ShortHash) } // PushSpec returns the spec for a Gerrit push command to publish the change c in b. |