aboutsummaryrefslogtreecommitdiff
path: root/internal/queue/pgqueue/queue_test.go
blob: b1621435b009ca24e2584402e395c19c475c701d (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
// Copyright 2026 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package pgqueue

import (
	"context"
	"errors"
	"log"
	"os"
	"sync"
	"testing"
	"time"

	_ "github.com/jackc/pgx/v4/stdlib"

	"golang.org/x/pkgsite/internal/database"
	"golang.org/x/pkgsite/internal/derrors"
	"golang.org/x/pkgsite/internal/queue"
)

const testDBName = "discovery_pgqueue_test"

var testDB *database.DB

func TestMain(m *testing.M) {
	if os.Getenv("GO_DISCOVERY_TESTDB") != "true" {
		log.Printf("SKIPPING: GO_DISCOVERY_TESTDB is not set to true")
		return
	}
	if err := database.CreateDBIfNotExists(testDBName); err != nil {
		if errors.Is(err, derrors.NotFound) {
			log.Printf("SKIPPING: could not connect to DB: %v", err)
			return
		}
		log.Fatal(err)
	}
	db, err := database.Open("pgx", database.DBConnURI(testDBName), "test")
	if err != nil {
		log.Fatal(err)
	}
	testDB = db
	os.Exit(m.Run())
}

func setup(t *testing.T) *Queue {
	t.Helper()
	ctx := context.Background()
	if testDB == nil {
		t.Skip("test database not available")
	}
	// Drop and recreate the table for a clean slate.
	if _, err := testDB.Exec(ctx, `DROP TABLE IF EXISTS queue_tasks`); err != nil {
		t.Fatal(err)
	}
	q, err := New(ctx, testDB)
	if err != nil {
		t.Fatal(err)
	}
	return q
}

func TestScheduleFetch(t *testing.T) {
	q := setup(t)
	ctx := context.Background()

	enqueued, err := q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", nil)
	if err != nil {
		t.Fatal(err)
	}
	if !enqueued {
		t.Error("ScheduleFetch() = false, want true")
	}

	// Same module@version should be deduplicated.
	enqueued, err = q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", nil)
	if err != nil {
		t.Fatal(err)
	}
	if enqueued {
		t.Error("ScheduleFetch() duplicate = true, want false")
	}
}

func TestScheduleFetchWithSuffix(t *testing.T) {
	q := setup(t)
	ctx := context.Background()

	if _, err := q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", nil); err != nil {
		t.Fatal(err)
	}

	// Same module@version with a suffix should not be deduplicated.
	enqueued, err := q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", &queue.Options{Suffix: "reprocess-1"})
	if err != nil {
		t.Fatal(err)
	}
	if !enqueued {
		t.Error("ScheduleFetch() with suffix = false, want true")
	}
}

func TestPollProcessesTasks(t *testing.T) {
	q := setup(t)
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	if _, err := q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", nil); err != nil {
		t.Fatal(err)
	}
	if _, err := q.ScheduleFetch(ctx, "golang.org/x/net", "v0.1.0", nil); err != nil {
		t.Fatal(err)
	}

	var mu sync.Mutex
	var processed []string

	go q.Poll(ctx, 2, func(ctx context.Context, modulePath, version string) (int, error) {
		mu.Lock()
		processed = append(processed, modulePath+"@"+version)
		mu.Unlock()
		return 200, nil
	})

	// Wait for tasks to be processed.
	deadline := time.After(30 * time.Second)
	for {
		select {
		case <-deadline:
			t.Fatal("timed out waiting for tasks to be processed")
		case <-time.After(100 * time.Millisecond):
			mu.Lock()
			n := len(processed)
			mu.Unlock()
			if n == 2 {
				cancel()
				return
			}
		}
	}
}

func TestPollDeletesTaskOnError(t *testing.T) {
	q := setup(t)
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	if _, err := q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", nil); err != nil {
		t.Fatal(err)
	}

	done := make(chan struct{})
	go func() {
		q.Poll(ctx, 1, func(ctx context.Context, modulePath, version string) (int, error) {
			close(done)
			return 500, errors.New("something went wrong")
		})
	}()

	select {
	case <-done:
	case <-time.After(30 * time.Second):
		t.Fatal("timed out waiting for task to be processed")
	}
	cancel()

	// Verify the task was deleted despite the error.
	var count int
	err := testDB.QueryRow(context.Background(), `SELECT count(*) FROM queue_tasks`).Scan(&count)
	if err != nil {
		t.Fatal(err)
	}
	// Allow a brief moment for the delete to complete.
	time.Sleep(100 * time.Millisecond)
	err = testDB.QueryRow(context.Background(), `SELECT count(*) FROM queue_tasks`).Scan(&count)
	if err != nil {
		t.Fatal(err)
	}
	if count != 0 {
		t.Errorf("queue_tasks count = %d, want 0", count)
	}
}

func TestPollReclaimsStalledTasks(t *testing.T) {
	q := setup(t)
	ctx := context.Background()

	if _, err := q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", nil); err != nil {
		t.Fatal(err)
	}

	// Simulate a stalled task by setting started_at to the past.
	if _, err := testDB.Exec(ctx,
		`UPDATE queue_tasks SET started_at = NOW() - INTERVAL '10 minutes'`); err != nil {
		t.Fatal(err)
	}

	pollCtx, cancel := context.WithCancel(ctx)
	defer cancel()

	done := make(chan struct{})
	go func() {
		q.Poll(pollCtx, 1, func(ctx context.Context, modulePath, version string) (int, error) {
			close(done)
			return 200, nil
		})
	}()

	select {
	case <-done:
		// Task was reclaimed and processed.
	case <-time.After(30 * time.Second):
		t.Fatal("timed out waiting for stalled task to be reclaimed")
	}
	cancel()
}

func TestStalledWorkerDeleteIsNoop(t *testing.T) {
	// Worker1 claims a task, but stalls. Worker2 claims it later. Worker1
	// unstalls and completes, but does not delete the task from the queue: once
	// worker2 has the task, only it may do the delete. It unstalls and finishes
	// and we assert the task is deleted from the queue.
	q := setup(t)
	ctx := context.Background()

	if _, err := q.ScheduleFetch(ctx, "golang.org/x/text", "v0.3.0", nil); err != nil {
		t.Fatal(err)
	}

	worker1Claimed := make(chan struct{})
	worker1Stall := make(chan struct{})
	worker1Done := make(chan struct{})
	worker2Claimed := make(chan struct{})
	worker2Stall := make(chan struct{})
	worker2Done := make(chan struct{})

	// Worker 1 claims the task and stalls.
	go func() {
		q.claimAndProcess(ctx, func(ctx context.Context, modulePath, version string) (int, error) {
			close(worker1Claimed)
			<-worker1Stall
			return 200, nil
		})
		close(worker1Done)
	}()

	// Wait for worker 1 to enter processFunc, then backdate started_at so the
	// task is eligible for reclaim.
	<-worker1Claimed
	if _, err := testDB.Exec(ctx, `UPDATE queue_tasks SET started_at = NOW() - INTERVAL '10 minutes'`); err != nil {
		t.Fatal(err)
	}

	// Worker 2 reclaims the task and stalls.
	go func() {
		q.claimAndProcess(ctx, func(ctx context.Context, modulePath, version string) (int, error) {
			close(worker2Claimed)
			<-worker2Stall
			return 200, nil
		})
		close(worker2Done)
	}()
	<-worker2Claimed

	// Unstall worker 1. Its delete should be a no-op because worker 2 has a
	// newer started_at.
	close(worker1Stall)
	<-worker1Done

	var count int
	if err := testDB.QueryRow(ctx, `SELECT count(*) FROM queue_tasks`).Scan(&count); err != nil {
		t.Fatal(err)
	}
	if count != 1 {
		t.Errorf("after worker 1: task count = %d, want 1 (worker 1 should not have deleted it)", count)
	}

	// Unstall worker 2. Its delete should succeed.
	close(worker2Stall)
	<-worker2Done

	if err := testDB.QueryRow(ctx, `SELECT count(*) FROM queue_tasks`).Scan(&count); err != nil {
		t.Fatal(err)
	}
	if count != 0 {
		t.Errorf("after worker 2: task count = %d, want 0", count)
	}
}