aboutsummaryrefslogtreecommitdiff
path: root/tests
AgeCommit message (Collapse)Author
2026-03-28tests/screentest: fix flaky mobile viewport screen capturesHana Kim
When "capture viewport 540x1080" shrinks the headless browser window from desktop to mobile size, the layout shifts and triggers CSS transitions. Because screentest takes the screenshot immediately after resizing, it often captures the page mid-animation. This causes element height changes and unexpected scrollbars, making the image diff fail randomly. Fixed by injecting a style tag that globally disables all CSS transitions during the hideElements initialization. This causes layout resizes to snap instantly, ensuring the captured image is always fully settled and consistent. Change-Id: I43310708ced5f0cff5bf011bfb407fa22705d9a2 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/760580 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ethan Lee <ethanalee@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2026-03-24all: pgx/v4 to v5 and upgrade pqEthan Lee
- In preparation for upgrade to PostgreSQL 17, upgrade stale dependencies within pkgsite. Change-Id: Id54cbb46182711b9808ee3bbbe2f0d5d9a04583d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/758121 Auto-Submit: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2026-03-09all: update PostgreSQL version to 14Ethan Lee
Update Docker configurations and documentation to use PostgreSQL 14, aligning local development and testing environments with production. There has been a change in how PostgreSQL 14 tokenizes paths. This has caused an alteration in how multi word searches are resolved. Update test case to reflect this. See golang/go#78036 for more context. To test: `tests/search/run.sh` Fixes golang/go#77903 Change-Id: I28eaa722914b2163fe962a1b4a1b8681d60b18b3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/750740 Auto-Submit: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2026-02-12internal/licenses: add COPYING.LESSER to recognized license filenamesEthan Lee
Fixes golang/go#77324 Change-Id: I1852deb53b128b0f7f1ebb235287bfced00c2c3c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/741620 Auto-Submit: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Junyang Shao <shaojunyang@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2025-12-30internal/frontend: remove logging for http.StatusNotFoundEthan Lee
- Update fetchCodeWikiURL to treat http.StatusNotFound as a successful "no link" result rather than an error. This prevents newURLGenerator from logging an Errorf every time a package is missing from CodeWiki. Change-Id: I05bc0361acba70791fc526e7fdc58d81e4602a73 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/733280 Reviewed-by: Nicholas Husin <nsh@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Ethan Lee <ethanalee@google.com> Reviewed-by: Nicholas Husin <husin@google.com>
2025-12-20tests: update docs for updating screenshot testsEthan Lee
Change-Id: I85997dce21dae9c40ca68eb4007e7a724e519094 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/731021 Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Ethan Lee <ethanalee@google.com>
2025-12-20internal/frontend: add CodeWiki link support to pkgsiteEthan Lee
- If a module's source repo exists in CodeWiki, display a link to codewiki.google/repo. - Disable the CodeWiki link from being displayed for screentests by adding it to the hidden elements. Change-Id: Ia5feb913280b8066806e56524bf9d32ce51f0614 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/730880 Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Ethan Lee <ethanalee@google.com>
2025-12-20test/screentest: increase timeout for "x/net directories expanded"Ethan Lee
- Test flakiness induced by insufficient timeout. Test: for i in {1..10}; do echo "--- Running test iteration $i ---"; ./tests/screentest/run.sh -rm -run "test x/net directories expanded" -ci; done Fixes golang/go#76933 Change-Id: Ib4de3dd3159cbb00e02848fafbccea63586cad0b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/731580 Auto-Submit: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2025-08-06static/frontend: update the logo styling to not have an explicit widthJean Barkhuysen
If a company wants to run their own version of pkgsite, the easiest way to differentiate it from pkg.go.dev is to put their company logo (or some text, like INTERNAL) in the logo SVG next to the GO. However, doing so increases the width of the logo. In the current CSS, a wider logo means it gets shrunk down, because the width and height are constrained by css. This CL removes the width constraint, so that the logo is allowed to be wider. This will have a nearly imperceptible effect on the current pkg.go.dev style: the logo will be a few pixels wider. After a few pixels' width growth it becomes constrained by the height rule. Note: This is doubly important as a CL to upstream because it's very hard to patch in this change, as it requires a change to the minified files. It's quite hard to come up with the appropriate sed command that performs a patch to the minified files. Change-Id: I717553204888a7438a9f2c93f428bc166f095e09 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/685955 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Chressie Himpel <chressie@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Mark Freeman <markfreeman@google.com>
2025-07-04static/doc: promote examples into TOC link tree.Matt T. Proud
This change alters how the table of contents (TOC) is rendered to promote the listing of examples directly into the TOC itself as well as avoid nesting the examples under a sub-heading where they are likely not to be seen. A change like this assists beginners with providing immediate awareness that the concept of examples exists. Without this change, the whole idea of examples are easy to miss, as they are suggested essentially only in collapsible summary tags at the bottom of the respective identifier or scope they are attached to. Change-Id: Ic46d20180767c25092648355af52e935a6f45f4e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/673435 Reviewed-by: Cherry Mui <cherryyz@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Matt Proud <matt.proud@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2025-06-09internal/frontend: lowercase module chip for consistencyVamsi Avula
All other chips (including module elsewhere) are lowercased. Change-Id: Id00000006431579daf1471350c862f345a231d43 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626815 Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
2025-06-08internal/frontend: report whether subdirectories are commandsVamsi Avula
Fixes golang/go#68939. Change-Id: Id0000000428e169bc31293f02fb89f861da084b3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/620739 Reviewed-by: Jonathan Amsterdam <jba@google.com> Auto-Submit: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Naga Raju Karre <karrer@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-05-23static/frontend: hide subpackage expansion button when all internalJake Bailey
If all of a package's subpackages are internal, the button will do nothing when clicked unless "show internal" has been clicked. Prevent the expand button from appearing when this is the case by applying the same CSS class used to hide the internal packages themselves. Fixes golang/go#70313 Change-Id: Ie66b90ba4bb2a1e8d1a90ac3710422bfadb610b1 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/673717 Auto-Submit: Robert Findley <rfindley@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: David Chase <drchase@google.com>
2025-03-10static/shared/header: change security linkAnna Groebel
Change the link in navigation to the security documentation root instead of the subpage on security policies. For golang/go#57972 Change-Id: Iaf3dc48f15400060c55ea20d2e8372967b88c77e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/641715 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2025-02-05tests/screentest: omit mobile expanded README testJonathan Amsterdam
Comment out the test for expanded README on small screens. It fails about half the time in CI, making it annoying to deploy and submit CLs. Maybe more effort could deflake it, but I'm not optimistic. I spent a while throwing everything I could at it and it's still misbehaving. It would require someone more familiar than I with the intricacies of HTML page loading and headless chrome to make progress. It is only for mobile, not our main concern, and it is only one test. Change-Id: Icd9c2bd3f3c99ee0efaf8a617f9b2b31a0c8dde6 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/646855 kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
2025-01-27internal/frontend: redirect on "std/" queriesJonathan Amsterdam
If a search query is "std/P", where P is a a stdlib package, redirect to P without searching. Also, update the help page on search to mention this, and to correctly reflect the existing behavior of always doing a search for queries without a slash. For golang/go#71452. Change-Id: Idf5c09ee3e81b4c6efa44c2d76470e6f496dcbcd Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/644676 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-01-27internal/licenses: add EUPL-1.1Jonathan Amsterdam
Accept the EUPL-1.1 license. Fixes golang/go#71332. Change-Id: I3fc37fa67cd972a5e508e325d2fd1d47928768f3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/644735 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-12-09tests/screentest: remove a test casesJonathan Amsterdam
Commented out the multi-GOOS 540x1080 test. I tried and failed to increase its reliability. Running locally against staging, it still fails about 20% of the time, but always succeeds after a retry. Running on Cloud Build against staging, the failure rate seems higher, and retries don't help. More detail in a comment. Change-Id: I31e334d03c6bdff6733ed675a97677a723309ce0 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/634555 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-12-06tests/screentest: add latest x/net version to seedJonathan Amsterdam
A new version of golang.org/x/net was tagged, resulting in a change in the chip from "Latest" to "Go to latest". Add this new version to the list of seeds to capture that change, and update the goldens. (This is a one-time fix: future tagged versions won't change the page. The real mistake was using the then-latest version when we added x/net.) Change-Id: I2855307ef815b970cbcef5249adfb9041d54c573 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/634080 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-12-06tests/screentest: update goldensJonathan Amsterdam
Update the screentest goldens (*.want.png files) to capture the change in https://go.dev/cl/621839, which reduced the "fading" at the bottom of the truncated README to improve accessibility. Also, add sleeps to some tests to deflake them. Also, tell git to ignore screentest output. Change-Id: I8d6f99db3503f0a448f9ba0b199a11e23370528b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/633997 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-12-03tests/screentest: retry on small diffsJonathan Amsterdam
If a screentest case fails but the number of differing pixels is small, retry the the test. This can increase reliability when a test fails but the diffs are tiny--20 pixels or fewer. We don't know why this happens, but it does happen occasionally. Note that no test passes unless every pixel matches. This change merely retries tests that are close. We've found that to help. (After three retries, the test will fail.) Change-Id: Ib48858197c6206cd1ea6a850c58c1335e031347e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/633200 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-12-03tests/screentest: make tests work on stagingJonathan Amsterdam
- Fix bug in run.sh where we weren't sending the right auth header. - Tweak some test cases to make them reliable. In particular, some tests become more stable by hiding the "Links" meta section. - Change the "expanded directories" test from x/tools to x/net. The latter has the same DB state in our production environment and locally, so the pages render identically. - Add more modules to the list used to seed the local/ci database. These modules are never rendered, but affect the rendering of others. The reasons are documented in the seed file. Change-Id: Ia03b5c8dde5ef612525ccb2b92cddc9c80665687 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/632798 Reviewed-by: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-28tests/screentest: uncomment "jump to modal" testJonathan Amsterdam
This test doesn't seem to flake. Perhaps the problem is fixed in the upgraded chromedp that we are now using. Change-Id: I314389156d9ab20c9ad2a48481f69c98ce82c264 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/631681 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-28tests/screentest: fix expanded directories testJonathan Amsterdam
Update the expanded directories test case. The root cause is a difference in production and seeded DBs, probably as a result of a change in go/doc or go/doc/comment. Updating the golden to match the seeded DB addresses the problem for CI. Change-Id: I13873e68a9b6d934e1c29d4c6b52abad95550d21 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/631680 kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-11-28tests/screentest: fix deprecated symbol testsJonathan Amsterdam
Work around the bug in chromedp where a fullscreen shot of a certain page is corrupted. Split the test into two, one for the index and one for the specific symbol, and scroll to the appropriate place by using a URL fragment. The fragment doesn't work on chromedp for the smaller dimensions, so omit those tests. Also, delete some old .b.png and .diff.png files that shouldn't be there. Change-Id: I893476e79320856cf1ae21606d2b22da4bd2734f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/631679 Reviewed-by: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-26tests/screentest: update goldens to latest chromedp versionJonathan Amsterdam
Use a more recent version of chromedp and screentest. The newer screentest takes arguments differently, so update its invocations. The newer chromedp displays things slightly differently, so update the goldens. Also use the suffix "want" instead of "a", as the new screentest requires. Comment out buggy or flaky tests. These will be handled in followup CLs. Also, improve and enhance run.sh, notably adding the -run flag to run a subset of the tests. Change-Id: Ia46bf02f8cae15a763c80c6d6744f4ac9c005b9b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/631780 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-13tests/README.md: add troubleshooting adviceJonathan Amsterdam
Add a paragraph to deal with a condition that I have encountered on my machine. Change-Id: Ie03a0e8ab4030973cdec8e84cd5877234830b8de Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626856 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-11-13tests/screentest: improve run.shJonathan Amsterdam
- Use single-hyphen flags to conform to Go style. - Remove unnecessary quotation. - Minor shell style nits. - Change the "local" case to run all components, instead of assuming that some are already running. The last change makes the "local" case much more useful, and faster than the "ci" case for local testing. Change-Id: Id3412fac8bd4a29539563e3cc568a3c7edd06c2e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626855 Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-13tests/screentest: pin screentest binary to older versionJonathan Amsterdam
The screentest binary (golang.org/x/website/cmd/screentest) was recently updated to use a new version of chromedp, the package that talks to chrome in order to obtain screenshots. The new version produces slightly different screenshots. We will eventually deal with this when the screentest changes are finished, but for now use an older screentest version. Change-Id: I197501241a823f7c7ee03fab9c7312f89949af9a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/627535 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-08test/screentest: remove unneeded seedsJonathan Amsterdam
Remove modules that don't matter from the list of modules used to seed the database in ci mode. Also combine two identical tests. Change-Id: I979ed07ce1f3bdf0fa164e46643cffefcdce45e3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/626003 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-11-07screentest: enable test x/tools directories expandedVamsi Avula
This will be useful for https://go.dev/cl/620739 -- https://go.dev/cl/413680 (the CL that disabled it) says it was failing on the CI, maybe we'll have better luck this time? I'd like to enable it here so cl/620739 can capture the diff. Change-Id: Id0000000c68af80d5194e955e0df7df59f58f29d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/624475 Run-TryBot: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
2024-08-24Revert "static/frontend: made cancel button in search field keyboard accessible"Jonathan Amsterdam
This reverts commit a224e846c93566e132672c606d14b07ef659553c. Reason for revert: breaks the UI (#68538) Fixes #68538. Change-Id: I23a6acaf741e7cb863c304363ee9b7a4fdf0bbe2 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/608036 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-08-22devtools/cmd/seeddb: limit concurrencyJonathan Amsterdam
Limit the number of goroutines that are fetching modules at once, to reduce the chance of transactions timing out. We've been noticing kokoro failures due to that recently. I chose a limit of 10 arbitrarily. We'll see if it helps. I tried testing locally, but I don't get the same behavior as on kokoro. Also, use an errgroup with a context to clean up seeddb failures faster. Also, remove the seeddb flag permanently. Change-Id: Ib0244c76572c9f9e34064f99a05b26d70cc55aea Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/607755 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-07-16tests/screentest: delete flaky screentestTatiana Bradley
Delete screentest "module-with-one-vuln" which is flaky. For golang/go#68467 Change-Id: If2335c1f542478d9860ebe7ca42827a209a33eef Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/598532 Auto-Submit: Tatiana Bradley <tatianabradley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-07-15internal/vuln,static/frontend: display custom versions on vuln pagesTatiana Bradley
On vulnerability entry pages, display "custom versions" (and a note explainining them) if there are any "custom_ranges" published in the OSV. (Once this is live, we will remove the disclaimer from the OSV details since this will be redundant.) Change-Id: I20c3b08ecb3f36ce0334553eef0dacd0fe57480b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/597616 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-07-15tests/screentest: add test for vuln with custom_rangesTatiana Bradley
Change-Id: Idf26fba7712eeb98b84c5d87aa31da86e2ea0a7a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/597615 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-07-12tests/screentest: fix module-with-one-vuln screentestTatiana Bradley
Change-Id: I9f486b8e4758fa251d20e0fab3106095bc674f57 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/598035 kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Tatiana Bradley <tatianabradley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com>
2024-07-01static/frontend: condense vuln display on module pagesTatiana Bradley
When a module is affected by many vulnerabilities, the current display can become overwhelming because details are listed for each vuln. If there are 2 or more vulns, condense the the message to "Affected by GO-XXXX-YYYY and N other vulnerabilities", with the option to click a button and see all the vulns. Change-Id: I5e4e6712aa6038d390ed70b339a982f7684a986f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/595561 kokoro-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
2024-05-22static/frontend/vuln,internal/osv: display info about unreviewed meaning on ↵Tatiana Bradley
vuln page For UNREVIEWED reports, display the word "Unreviewed" under the title, and add a blurb to the feedback section explaining its meaning. Currently, don't display anything special for a REVIEWED report. This is the default. Change-Id: I43ad7c324f6712a22a035c4aac725808cd50e7c3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/586101 Run-TryBot: Tatiana Bradley <tatianabradley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-05-22tests: update vuln testdata to pull in review_statusTatiana Bradley
Update the script that pulls in the latest vulns to include an UNREVIEWED report. Run the script to update the test corpus to bring in this new vuln, plus the review_status for all vulns. Update the screentests accordingly. Change-Id: I45aa815ac9a33d186bac196220cce169b8523dae Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/586100 kokoro-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Tatiana Bradley <tatianabradley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-04-26static/frontend: ensure page content fits across >= 320 CSS pixelsLuc Talatinian
Ensure main page content is readable at 320 CSS pixels without the need for horizontal scrolling. This is important for documentation users that may require zoom functionality in order to read content. WCAG 2.2 defines 320 pixels as the minimum width reasonably achieveable by site authors. See https://www.w3.org/WAI/WCAG22/Understanding/reflow.html. Fixes #66996. Change-Id: Ic3d02bffac23798bcd86d28560845fa91ce831db Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/581236 Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Robert Findley <rfindley@google.com>
2024-04-24internal/{frontend,vuln}: display affected modulesTatiana Bradley
For vulns with no detailed package data, display affected modules and versions. Change-Id: Ibacdcd486cbb47b17a11d331692356a0603ac6d1 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/581181 kokoro-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
2024-04-24static/frontend/vuln: fix credits list displayTatiana Bradley
Fix a bug in which the first two credits of a vuln report were displayed with no separation. Change-Id: I1f42268d8d6e03341e8e1b5db09d16beb7188f8f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/581180 Reviewed-by: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Tatiana Bradley <tatianabradley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-04-24tests/screentest: add a test for a vuln with no affected packagesTatiana Bradley
Adds a test for a vulnerability report that only lists affected module(s), not affected packages. Package site currently does not display this correctly (it displays an empty section instead of listing the modules). An upcoming CL will fix. Change-Id: Ia9b73ab8ad3f2ec71061bd329ab7497eccb91ee2 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/581179 Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Tatiana Bradley <tatianabradley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-04-24internal/osv,static/frontend/vuln: add a chip for standard library vulnsTatiana Bradley
Change-Id: I0cb26136ddd58afbb53312dbd93f3ca1a5b8388f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/581176 Run-TryBot: Tatiana Bradley <tatianabradley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
2024-04-23static/frontend/vuln: display (withdrawn) instead of vuln detailsTatiana Bradley
For withdrawn vulns, display the phrase "(withdrawn)" instead of the vuln details on the vuln list pages. The user can still view the full details by clicking on the vulnerability entry page. Change-Id: I4b9dd9907b4727342907c5791c6af4f3981f5d23 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/580995 Run-TryBot: Tatiana Bradley <tatianabradley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com>
2024-04-23static/frontend/vuln: add withdrawn chip for vulnsTatiana Bradley
Adds a gray chip and a strikethrough to withdrawn vulns so they are more recognizable. Change-Id: I632a7606b4a4b107a05e3c8b73b7978831d2efbf Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/580195 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Run-TryBot: Tatiana Bradley <tatianabradley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-04-18static/frontend/vuln: add withdrawn time for vulnsTatiana Bradley
Display the withdrawn time for vulnerabilities (if one is present). Change-Id: Ia215392ccb8340eee089528e586b43ab995d5fa5 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/579917 Run-TryBot: Tatiana Bradley <tatianabradley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Damien Neil <dneil@google.com>
2024-04-18test/screentest: add withdrawn vuln and update screentestsTatiana Bradley
Add a "withdrawn" vulnerability example to the screentests so we can more easily test upcoming functionality that will handle withdrawn vulns. Change-Id: I3c373927055e3ce4a0f93fc1f1608596c9889c0a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/579916 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Tatiana Bradley <tatianabradley@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Run-TryBot: Tatiana Bradley <tatianabradley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-04-16all: fix function names in commentcuishuang
Change-Id: I25ba419d2fc5878e14cf3b5026724e17efaaa39d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/579177 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: qiu laidongfeng2 <2645477756@qq.com> Reviewed-by: Cherry Mui <cherryyz@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org>
generated by cgit v1.3 (git 2.53.0) at 2026-04-15 09:48:46 +0000