| Age | Commit message (Collapse) | Author |
|
Our system does not use Node.JS in production. It is only for testing.
Make this clear.
And remove unneeded dependencies.
Change-Id: I7b28bbb62a163cda3cc1e241710e2889f79807c6
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/753420
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ethan Lee <ethanalee@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
|
|
Change-Id: I4b8926abb39c2a025fa42312c88b3c8d203fcd98
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/752185
Reviewed-by: Ethan Lee <ethanalee@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
|
|
run `npm audit`, then its recommended commands, to resolve
npm vulnerabilities.
Updates #71118.
Change-Id: I8dd1e7384fce436e942691552a9bbd1ebfd3b5d2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/642081
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
|
|
- Fix npm vulns.
- Fix the minimized-css check to look only at the working dir.
Change-Id: Iecf2c5ef35813fef16df22147f795cda814fef2b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/608037
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
|
|
Change-Id: I2568aa885085a1820f4cffedecf0d737affd7da9
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/585475
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
|
|
Ran `./all.bash npm update @babel/traverse --depth 14`
to fix vulnerabilities associated with @babel/traverse.
Change-Id: Ib2c4174385f4a0dbe4791df4d52c6a1383f56e6c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/551775
kokoro-CI: kokoro <noreply+kokoro@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
|
|
Change-Id: I6fdff4d1209f7bb25b6212add1612a48ee404fec
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/476617
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Upgraded postcss to fix a type error when running
stylelint --fix. See stylelint/stylelint#5766.
Fixed the fileglob for CSS files and made simple fixes
for stylelint errors.
Change-Id: If838a740f97532b9b29ad16fb6aeb5de72ed49d1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/455956
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
|
Change-Id: I83d83875e1eb4fc6e6c83fa8af458b4c112df97b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/452765
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Change-Id: I38862b504d261c6ccf5595ddf922a50d9e4dfa51
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/425077
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
|
|
Even though I thought I had just done this, when I ran all.bash,
npm audit complained. This CL is the result of running
./all.bash npm audit fix
Change-Id: I00f4d8059bb9f44ba97a3e0118d40216eea08060
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/413034
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
The e2e tests have been replaced with the screentest
check. Removed the tests, related jest config, and
npm dependencies.
Change-Id: Ib7652170a00ce2750545e7843b11d27b7eb0e3fb
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/382035
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Ran ./all.bash npm audit fix.
See https://github.com/advisories/GHSA-r683-j2x4-v87g details.
Change-Id: Ib8f6f777599b7a6f13cf578b874a18043a714e6e
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/381414
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Change-Id: I92792c13386d6b007b6cb710be3bc82d24146f5d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/379138
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Upgraded stylelint and ran ./all.bash npm run lint -- --fix
Change-Id: Ieeade66258cb970fb40ebd7bf420cad2ff13d89e
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/379137
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Fix for CVE-2022-21680.
Change-Id: Ic9c25d85dee6d3f1725e8fa685bbd45702db25a2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/379136
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Updated jest related packages and code
to work with the latest major version.
Change-Id: I24a7ed09f324f372b5d29202ccd23d0bea2fbb9a
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/358537
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Result of `npm audit fix --force`
Change-Id: If452cc8d55b01c1326e80c11b31d61746633cee1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/358494
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Change-Id: I238ab885e751c6619e93840979da183a393fbb15
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/341309
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
The 1.46-chrome-stable image of browserless/chrome was updated and
a tag that contains the same combination of browserless, puppeteer,
and chromium does not exist. This change upgrades puppeteer and
uses a browserless/chrome image with pinned versions of all the
internal software.
Change-Id: I2d7c037395c8f1a3c0a51ccb16abf0eadcc599b3
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/340189
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Ran npm audit to pick up the postcss security fix.
Change-Id: I43a92bc38c49fd0da4c401dfbc50c923f3934cfd
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/328672
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Ran npm audit fix to patch security vulnerabilities.
Change-Id: I00a87bfad6ebf5b445c604c1a3bb3a6064599515
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/327296
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Ran all.bash.
Change-Id: I5318bff28645c65254d3f663d3f847c91ee584f1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/326775
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Marked is used to parse markdown files in the JS tests
for the styleguide components.
Change-Id: I9b883b10a5f590977eb2c7f88ca019e1b1b20ed9
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/320571
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
https://www.npmjs.com/advisories/1673
Change-Id: I6664d4204779ff1f7ef86118c9a5e17a093cf73f
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/318889
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Change-Id: I6af384c9190041b04fecbe950a0796d7c3ec6738
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/311449
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
The e2e tests will prefer a locally installed npm binary and
use a prebuilt headless chrome docker image. This will speed up
test runs for devs with npm installed but still leave the option
to opt out of installing node directly on the host machine.
Jest now uses a custom test environment that initializes global
variables, starts chrome, and adds authorization headers to
requests.
Change-Id: Ie43952ada6fd3e4df0fd522c84691186ef0d7f80
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/310314
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Each e2e test file was starting and closing its
own instance of Chrome. To speed up the tests
we are now sharing a single instance of across
test files and properly exiting after the tests
have completed.
Change-Id: Ia7ad4acaf961cf89a177e293e971c94b43b76d05
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/304589
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
This change gives us a slight improvement in the
speed of our tests and results in better error
messages when things break. Jest-circus is the default
test runner in the next major release of jest but
we can take advantage of it today.
Change-Id: I454449b18e1644a8d02faf276c2905b2a5879377
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/298429
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
- Switches to stylelint-config-standard. This config adds
additional rules to enforce common stylistic conventions
found in many CSS style guides, including Google's.
- Adds alphabetical properties rule.
Change-Id: Ic2df16c38662777f729a6301c1e567faa330a92d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/283712
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Removes PostCSS cli dependency and minified CSS files.
Reverts the changes from https://golang.org/cl/281772
to simplify the development process for CSS files. We
may revisit minifying and bundling CSS with a Go package
in the future.
Change-Id: I34936eefc0d9aced9a13badace2c950f53ac84da
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/282376
Reviewed-by: Julie Qiu <julie@golang.org>
Trust: Jamal Carvalho <jamal@golang.org>
|
|
Adds dependencies for PostCSS and TypeScript with build
and develop scripts that use them in package.json.
Removes tsconfig parser option from eslintrc because it interferes
with a change in the tsconfig to exclude test files. We want eslint
to still lint test files. This is okay for now because none of our
lint rules depend on type information. If we add rules that require
type info we can create a separate tsconfig for eslint.
This change adds TypeScript but not esbuild. It is not
clear that we need minification so we will start with just
the TypeScript compiler for now. Looking at some of the sources
we currently minify with the closure compiler typical savings in
a file is less than 1kb. Once we have some TypeScript
code to compare minified and unminified performance with we
can consider adding esbuild or some other minifier.
For golang/go#43359
For golang/go#43360
Change-Id: I1a181952f546b0a0eb9b755128b2b83481e8ed92
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/280705
Reviewed-by: Julie Qiu <julie@golang.org>
Trust: Jamal Carvalho <jamal@golang.org>
|
|
Adds dependencies, configuration, and scripts for frontend
e2e and unit testing. Test examples to follow this change.
Change-Id: Ia3d246abfcc1411d5b00ca7e23829f1ede6e7207
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/280600
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Trust: Jamal Carvalho <jamal@golang.org>
|
|
Installs dependencies for typescript and stylelint and
adds scripts to package.json for linting code. The linter
will ignore code in content/static for now. A new directory
to be added, content/lib, will contain the typescript and
unprocessed css files.
For golang/go#43358
Change-Id: I6ee74665a99af8938df6f1ee675c8705fcce589c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/280599
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Trust: Jamal Carvalho <jamal@golang.org>
|
|
Creates build file for pkgsite npm container. This will enable
contributors to run prettier formatting without having npm and
node installed on their machines as long as they have docker and
docker-composed installed.
Change-Id: Ibb9ff375eabcb548d258907cf6f1111ca3654e7d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/275447
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|