aboutsummaryrefslogtreecommitdiff
path: root/internal/fetch
AgeCommit message (Collapse)Author
2026-03-30all.bash: re-enable unparamJonathan Amsterdam
It's working now. Also fix, issues that it detected. Change-Id: Ifd3fe5baf9a56d31bafe099bf4b38e02356bde21 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/760582 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Ethan Lee <ethanalee@google.com>
2026-03-27all: run go fix -stringsseqHana Kim
Change-Id: Id22b6fbc926c516043a2a9869ce9042dedebc725 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/753433 Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2026-03-26internal: consolidate build context and unit resolution logicEthan Lee
- Centralize logic for resolving units and selecting the best matching build context. - New helpers MatchingBuildContext, SortedBuildContexts provide a consistent, efficient approach to build context selection. - DocumentationForBuildContext now finds the best match based on precdence rules rather than just returning the first match. - A new getUnitContext helper resolves unit metadata and the best build context in a single query. - GetSymbols and GetUnit are now both optimized to use pre-resolved IDs, simplifying their queries and removing redundant joins. - Replaced redundant matchingDoc functions in fetchdatasource and fakedatasource. Change-Id: I9207d3bfe03404483c816090a0b99666f14a36e3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/759162 Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ethan Lee <ethanalee@google.com>
2026-03-13all: fix mapsloopHana Kim
Change-Id: I9841a5c30af333fd07ce5f9d8252e2ff79ee0dc9 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/753424 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2026-03-13all: fix forvarHana Kim
Change-Id: I02d2be535d9e3ac1788306adcc78d997d0caf951 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/753422 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Ethan Lee <ethanalee@google.com>
2026-03-13all: fix fmtappendfHana Kim
Change-Id: I80655ec771398304bd5c33c3f8d52ae22a35e6d8 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/753421 Reviewed-by: Ethan Lee <ethanalee@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2026-02-23frontend: fix loading stdlib in direct_proxy modeEthan Lee
- internal/fetch: fix stdlib path extraction by removing invalid "std/" prefix. - internal/fetchdatasource: fix "std" proxy errors in GetLatestInfo. - cmd/frontend: prioritize stdlib getter and add local GOROOT optimization. Reproduction: - `go run ./cmd/frontend -dev -direct_proxy` should utilize the local GOROOT as the source for stdlib. - `go run ./cmd/frontend -direct_proxy` should enable one to via a stdlib library at `localhost:8080/std` or any other stdlib pkg. Fixes golang/go#77112 Change-Id: I0686922804178129550d9bb9edc87b2adff51aa6 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/746700 Auto-Submit: Ethan Lee <ethanalee@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Nicholas Husin <husin@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Nicholas Husin <nsh@golang.org>
2025-12-15internal/fetch: add runtimesecret and simd goexperimentsSean Liao
For golang/go#21865 For golang/go#71488 For golang/go#73787 Change-Id: Iedb7c007de2ab3840c98b604720f81196a6a6964 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/729900 Reviewed-by: Ethan Lee <ethanalee@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2025-10-23all: fix some commentscuishuang
Change-Id: Ia70b35ab9aef270692a3892629c3c81208771089 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/713360 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Sean Liao <sean@liao.dev> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
2025-07-14cmd/internal/pkgsite: improve godoc mode search in GOROOTMichael Matloob
If a user starts go doc -http inside of GOROOT, we create three module getters when we only need one: We create a StdlibZip module getter which we're not going to use because we're using a local GOROOT, we create a gopackages module getter for the module determined as corresponding to the current directory, which is a stdlib module, and finally we create the NewGoPackagesStdlibModuleGetter, which is the main module getter for the standard library in that case. The StdlibZip module getter is not used when we're using a local GOROOT, so don't add it in that case. And if we detect that the module for a specified directory is std or cmd for the specified local GOROOT, skip adding it because it will be redundant with the module getter we create using NewGoPackagesStdlibModuleGetter specifically for the standard libarry. Removing the redundant module getter will prevent redundant search results returned by each of the gopackages module getters corresponding to the standard library. While we're here, if there's a VERSION file in GOROOT, set the version on the module metadata we return for the standard library to the stdlib.VersionForTag of that version, so we can report the version in the search results. Fixes golang/go#74459 Change-Id: If250f715b052f57f8668b02a57b4c96725be515a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/687918 Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Matloob <matloob@google.com> Auto-Submit: Michael Matloob <matloob@golang.org>
2025-06-11internal/fetch: remove goexperiment.synctestDamien Neil
Go 1.25 includes synctest in its non-experimental form. Drop the goexperiment.synctest constraint. This will cause us to stop displaying the experimental testing/synctest package for older Go versions, but more importantly will avoid displaying the deprecated (and GOEXPERIMENT-guarded) Run method in Go 1.25. For golang/go#71488. For golang/go#67434. Change-Id: I77c5c55f2a96d6c8e943da9cb3ffe9f92c7d6e68 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/680695 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Damien Neil <dneil@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-06-11internal/fetch: don't include goexperiment.jsonv2 for encoding/jsonDamien Neil
Setting the goexperiment.jsonv2 constraint switches the encoding/json package over to the new, experimental implementation, which has both documentation differences and API additions. We don't want to display this for most users, so only enable the goexperiment.jsonv2 constraint when loading entirely new packages that use it. For golang/go#71488. For golang/go#71845. Change-Id: Id69878e2948dea07245eb3d9bf3bb04cfed15e2d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/680675 Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Damien Neil <dneil@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2025-04-24internal/fetch: include goexperiment.jsonv2Sean Liao
For golang/go#71488 For golang/go#71845 Change-Id: Ib1b2fcbe5fede9a7c48207aee06a7659b0d49403 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/666935 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com>
2025-04-16internal: case sensitive exclude for github.com/google/UUIDSean Liao
Fixes golang/go#68357 Change-Id: I6f59310442fa6a161c95ea568238fefffcc09072 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/665735 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2025-04-01internal/fetch: fix broken linkcuishuang
Change-Id: I313d8feb224ee37dbc7a9f91c51dfa8875086b6a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/654537 Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Carlos Amedee <carlos@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-03-12internal: case sensitive exclude for github.com/BurntSushi/tomlSean Liao
For golang/go#68357 Change-Id: I1b64b6d288b947d3db4ea6149a7e7c4e7632dc0c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/654735 kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Nooras Saba‎ <noorassaba@google.com>
2025-02-18all: upgrade go directive to at least 1.23.0 [generated]Gopher Robot
By now Go 1.24.0 has been released, and Go 1.22 is no longer supported per the Go Release Policy (https://go.dev/doc/devel/release#policy). For golang/go#69095. [git-generate] (cd . && go get go@1.23.0 && go mod tidy && go fix ./... && go mod edit -toolchain=none) Change-Id: Iffce79b33bf11a871952a64d3dea922c50ebf412 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/649380 kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-02-14internal/fetch: look at files with tag goexperiment.synctestJonathan Amsterdam
If a file has the goexperiment.synctest tag, the worker will include it when constructing documentation. This was done for testing/synctest (clearly). We should gather a list of all GOEXPERIMENT tags that affect stdlib files, and include them as well. For golang/go#71488. Change-Id: Ibed834ebfcff529a58cd54efcacf4fe70941c5b0 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/649319 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-01-17internal/fetch: add correct canonical path for IBM/saramaDominic Evans
Similar to golang/go#52192 we need to add lowercase ibm/sarama to the knownAlternatives map to ensure the canonical uppercase variant (asdefined in go.mod) is chosen in preference. Fixes golang/go#71256 Change-Id: I190dafa0495adae304f25a5b194e74aa23f2079e GitHub-Last-Rev: eeafa01205603436cf6e0223af0d96fd518437f0 GitHub-Pull-Request: golang/pkgsite#107 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/642600 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2025-01-03all: make function and struct comments match the namescuishuang
Change-Id: Ic939b5b002e881f8041ccb95114010fe7e751f9a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/639558 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
2024-12-16internal/fetch: fix bug setting environmentMichael Matloob
We were adding "GOROOT=" and the path as separate elements to the environment slice rather than adding the single "GOROOT=<path>" element. Fixes #70581 Change-Id: I9f8afa271c8bae38ac37d1476eef4f3a532798d6 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/635675 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-12-05static/frontend: add titles to links for visual usersDenis Bowen
frontend: add titles to links add titles to links for visual users Screenshot of fix: https://screenshot.googleplex.com/8dUyg5GVTn7iXmg fixes b/283533047 Change-Id: I2e75c7c6b32add6f42de3a84de34f3219cad935a GitHub-Last-Rev: 4832e52fa3021cac5fdfb38261ea1e83a154d70d GitHub-Pull-Request: golang/pkgsite#101 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/624236 TryBot-Bypass: Jonathan Amsterdam <jba@google.com> Reviewed-by: Nooras Saba‎ <saba@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Joy Serquina (xWF) <serquina@google.com>
2024-11-08internal/godoc: increase max doc HTML limitJonathan Amsterdam
Double the maximum allowed size of rendered documentation. Increase the maximum file size as well. Also, add information about the documentation size to logs and error messages, so we can see the amount by which the limit was exceeded next time. For golang/go#40576. Change-Id: Ia2aa11915d583e8e0c5ca0e273202a57679bd5f7 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/622556 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cody Oss <codyoss@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-09-05internal/fetch,godoc: handle lint exceptionsJonathan Amsterdam
This CL addresses the errors found by staticcheck when we upgraded to Go 1.23. All were deprecation warnings, and they were silenced by "ignore" directives until we could deal with them. In all cases, ignore the lint message was the right choice. The CL adds justifications. Change-Id: I09d4bb96cb9913f8e35189ed3a4af9deaa092447 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/610801 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-09-04go.mod: upgrade to go 1.23Jonathan Amsterdam
The go.mod major version now matches what we use for Dockerfiles. The version of staticcheck that works with Go 1.23 revealed several uses of deprecated functions. Some of these were easy to change, but other require more care and will be addressed in some later CLs. Change-Id: I7f8344e419b8be6351d51db90faa64cef04057a0 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/609142 Reviewed-by: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-04-16all: fix function names in commentcuishuang
Change-Id: I25ba419d2fc5878e14cf3b5026724e17efaaa39d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/579177 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: qiu laidongfeng2 <2645477756@qq.com> Reviewed-by: Cherry Mui <cherryyz@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org>
2024-02-21internal/fetch: treat go.mod parse failure as BadModuleJonathan Amsterdam
We were returning a 500 if we couldn't parse a module's go.mod file. Instead return 490 (bad module). This fixes github.com/AlCutter/crucible@v0.0.0-20240212163456-5ee0456321b3, and others. Change-Id: Ia65a4523c44e6baa65760cef07c434b32f80c678 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/565678 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-02-21internal/godoc: increase max imports per packageJonathan Amsterdam
This will let us process git.runstone.com/DataCollect-BD/cisco-network-telemetry-proto@v1.1.0. Also, remove an unused constant from internal/fetch. Change-Id: Ib57078b84f5ee32b59fe934d153ede47d238e1d5 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/565677 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Matloob <matloob@golang.org>
2024-02-14internal/fetch: handle error in root packageJonathan Amsterdam
If a module had a problem with the package at its root, we would end up with two packageVersionStates. That caused a DB error in upsertPackageVersionStates. Distinguish between the module unit and package units in a couple of places. That addresses the root cause of the problem. Also, fix an unrelated bug that was causing a panic when we tried to send the error to the errorreporting service. Change-Id: Ia02faea50f4477999c6c6eca0674b8dde0f15bb3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/564076 Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-02-06internal/fetch: close directory file in defer in extractReadmeMichael Matloob
This addresses bcmills's comment in CL 559615 Fixes golang/go#65545. Change-Id: I02a4ba48eb897f33b4f4c47911e9cc80c99f7869 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/562176 TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
2024-02-06internal/fetch: remove comment that is no longer relevant.Michael Matloob
It doesn't matter for the same reasons when we set HasGoMod. Change-Id: I509233be3d85d2c5a4c948238ee26907e72faa3f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/562175 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2024-02-06internal/fetch: split FetchModule in twoMichael Matloob
First we get a LazyModule that essentially just contains the UnitMetas for each of the modules and then we process each Unit as needed so that FetchDataSource doesn't need to process all the Units when it just needs one. To construct at FetchResult, FetchModule will now get a LazyModule and then compute all the Units. A compromise to get this to work is that FetchDataSource will no longer populate Synopsis, IsRedistributable and Licenses on Subdirectories to avoid computing all those fields for all units when returning a single unit. MainVersion and MasterVersion are removed from FetchResult because they were only set on the internal/worker.FetchTask struct that embeds a FetchResult. Change-Id: Ia0db850ae570d421712ec484ee8b7815a779128e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/557818 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-01-31internal/fetch: split extractReadme from extractReadmesMichael Matloob
In CL 557818 we're going to process readmes a single unit at a time, so split a function that extracts a single readme at a time out of extractReadmes so we can use that in the cl. Change-Id: I5c39a95869de12e6f4aeebd2f42d87f24e147786 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/559615 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2024-01-23internal: move UnitMeta.IsRedistributable to UnitMichael Matloob
Change-Id: Ia0a18df32d752f20b0400b47860638c7d0910eb7 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/556435 Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-01-22internal: move UnitMeta.Licenses to UnitMichael Matloob
Change-Id: If2b3c1acd4830948e2d134517608f89771a7abcb Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/555735 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com>
2023-12-21cmd/pkgsite,internal/fetch: improve startup experienceMichael Matloob
When a user tries to look at the documentation for a unit for the first time, we process all the packages in the module. Kick off goroutines to do that so that the modules' packages might be processed by the time the user sees them. Also parallelize processing the packages in the module. That brings processing std from about 8 seconds to about 3 seconds. Change-Id: I505979d682897d2d1e55ce9e123e3ff4d1fb0e70 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/551776 kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2023-11-08internal/godoc/dochtml: add type parameters on func synopsisThiago
Adding type parameters on functions synopsis. Fixes golang/go#60954 Change-Id: If72c1b4d401b6cd32c335b1ed136063e7c965743 GitHub-Last-Rev: 375797ea2c2b352d6e5435334b82804552fd1a57 GitHub-Pull-Request: golang/pkgsite#79 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/535555 Reviewed-by: Suzy Mueller <suzmue@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2023-09-19internal/fetch: make readme too large a ModuleTooLarge errorSuzy Mueller
A too large README was returning an error with no code, resulting in a 500 from the worker which would then retry the module. This updates the error to be a ModuleTooLarge error, preventing it from being retried. Change-Id: Ib93d7d34e0104c5fb630286854f2d165b4379042 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/529375 kokoro-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2023-09-19internal/fetch: update _ directory test for extractReadmeSuzy Mueller
Update the unit test to have an explicit _ test case that is distinct from the stdlib case and rename the stdlib case. Change-Id: If0d2f35c66ae42666fb773d50cc58bcae8b0a5ac Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/529376 kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2023-09-05static/frontend: fix to make link purpose clear to users.Prudhvi Krishna Chintala
Change-Id: I4ebdf32f03936e6af927c204e28548e39994cd77 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/520255 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Suzy Mueller <suzmue@golang.org> Reviewed-by: Jamal Carvalho <jamal@golang.org> Run-TryBot: Suzy Mueller <suzmue@golang.org> Reviewed-by: Suzy Mueller <suzmue@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com>
2023-08-31all: skip tests that can't run on wasm platformsMichael Matloob
Some because the network support isn't enough for httpreplay, and some because we need the Go command. For golang/go#61209 Change-Id: I02c6b7d10553d931c746723ce9608f39834c131c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/524797 Reviewed-by: Robert Findley <rfindley@google.com> Run-TryBot: Michael Matloob <matloob@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> TryBot-Result: Gopher Robot <gobot@golang.org>
2023-08-30internal/trace: add a wrapper for tracingMichael Matloob
This package adds a StartSpan function that does nothing unless an implementation for the StartSpan function is injected in. That allows us to have the frontend and worker mains inject the implementation while internal/fetch and internal/source can use the StartSpan function without depending on opencensus's tracing library. For golang/go#61399 Change-Id: I2c650bdbb56c8fcc47ffabab8353cef74e0d1c4e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/523739 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Run-TryBot: Michael Matloob <matloob@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
2023-08-29internal/proxy: inject transport in proxy.NewMichael Matloob
This removes the dependency from internal/proxy on ochttp. For golang/go#61399 Change-Id: Ib2a350151752dc18c9a6e03b38b2d423ed55f4a1 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/523513 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2023-08-29internal/fetch: remove trailing tab from module pathDmitri Shuralyov
It seems unintentional. Spotted while reviewing CL 520735. Change-Id: Ia364d8d7e2b81a8f2e5b95d88014b3a630c9bcd8 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/521116 TryBot-Result: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2023-08-23all: remove arbitrary hard-coded timeouts in testsBryan C. Mills
If a test times out, that implies that it got stuck on something. By default, the Go testing package dumps goroutines when its own timeout is passed, which prints a goroutine dump, helping to reveal what was stuck. Adding an arbitrary timeout on top of the testing package's own timeout is, in my experience, almost always counterproductive. If the arbitrary timeout catches a real hang, it causes the test to fail instead of dumping goroutines, making it much harder to see what was stuck. On the other hand, if the timeouts are set aggressively enough to make the test fail early, they are often too aggressive for CI testing, causing flakes that then have to be triaged on an ongoing basis. On balance, the value of saving a minute or two for developers who have introduced a hang is not worth the cost of suppressing debugging information and causing flakes that have to be triaged. Fixes #61556. For #59347. Change-Id: I0263d0d9b18283470f100e5a0155818b87b5312f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/521837 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Matloob <matloob@golang.org>
2023-08-19internal/fetch: gofmt formatcui fliter
Change-Id: Ib03e0679f6737ee917131486e984ad213c9b736d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/520735 Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2023-08-10cmd/pkgsite: more changes to use local stdlibMichael Matloob
This cl makes more changes to enable using the local stdlib. It always uses the local stdlib from cmd/pkgsite. It also changes code that processes and shows versions to expect and pass through v0.0.0, the fake version we use when we show local packages. For #57742 Change-Id: Ic407e58e9658b0703dbc6df47f40bbe1f1bd2b2a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/517915 kokoro-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
2023-07-19internal/stdlib: remove dependency on github.com/go-git/go-git/v5Michael Matloob
Instead of using the in-memory git library implementation, just run all git operations using git commands. Add the MustHaveExecPath function from the internal/testenv library in the Go repo to our internal/testenv (with a modification to drop MustHaveExec because we don't really need it) so that we can check that git exists on the test platform before running tests that use this code because now we need a git binary to do git operations. For #61399 For #61341 Change-Id: I53441ee1638353a23935ba6a5ac70e2965b546f9 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/510415 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Jamal Carvalho <jamal@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Michael Matloob <matloob@golang.org>
2023-07-17internal/fetch: add two stdlib gettersMichael Matloob
This breaks out the behavior of getting the stdlib into its own getter, stdlibZipModuleGetter. Most (but not all) of the special cases in the fetch code for the stdlib are in the stdlibZipModuleGetter, which is installed on the frontend. For the local pkgsite command, we add a new builder for the goPackagesModuleGetter that loads the packages from the stdlib given a GOROOT. The stdlibZipModuleGetter is also installed for pkgsite in as a fallback if the goPackagesModuleGetter doesn't successfully fetch the stdlib module (I'm not sure if that's possible). Fixes #60114 Change-Id: Ida6a5367343643cc337c6d05e0d40095f79ca9e5 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/507883 Reviewed-by: Jamal Carvalho <jamal@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com>
2023-07-12internal/stdlib: update to account for .0 major version suffixesRob Findley
Starting with go1.21.0, the first version of new major Go versions will include the .0 suffix (compare go1.20). Update pkgsite logic to account for this switch, and add unit+integration test support. Fixes golang/go#60373 Change-Id: Ibdac8a3413a48f925427a5aae366bed2f691cfa6 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/508937 Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Jamal Carvalho <jamal@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com>
generated by cgit v1.3 (git 2.53.0) at 2026-04-15 06:10:36 +0000