aboutsummaryrefslogtreecommitdiff
path: root/cmd/internal
AgeCommit message (Collapse)Author
5 daysgo.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I0e4e9a00bda8777e7930d2b09e40dba681bfb768 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/764907 Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2026-03-30all.bash: re-enable unparamJonathan Amsterdam
It's working now. Also fix, issues that it detected. Change-Id: Ifd3fe5baf9a56d31bafe099bf4b38e02356bde21 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/760582 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Ethan Lee <ethanalee@google.com>
2026-03-26cmd/internal/pkgsite: fix godoc mode without -listFilippo Valsorda
Looks like it had always been broken, since m doesn't have a useful String() method. Change-Id: I6ad3a60916d3611fb38982a3aaf648c46a6a6964 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/737280 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2026-03-24all: pgx/v4 to v5 and upgrade pqEthan Lee
- In preparation for upgrade to PostgreSQL 17, upgrade stale dependencies within pkgsite. Change-Id: Id54cbb46182711b9808ee3bbbe2f0d5d9a04583d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/758121 Auto-Submit: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2026-03-12go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I2421b8fadf19befc309b16096bb771cd7ba808fc Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/754683 kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2026-02-23internal/database: set db connection pool limitsHana Kim
Under high-load, the frontend can issue many queries and trigger many connections. This can exceed the Cloud SQL connection limit of 100 per instance enforced by the Cloud Run environment, even if the database itself has remaining global capacity. To prevent this, we introduce limits on the database connection pool. We also include settings for idle connections and connection lifetimes to ensure better resource management and connection rotation. Introduces new env vars: GO_DISCOVERY_DATABASE_MAX_OPEN_CONNS GO_DISCOVERY_DATABASE_MAX_IDLE_CONNS GO_DISCOVERY_DATABASE_CONN_MAX_LIFETIME GO_DISCOVERY_DATABASE_CONN_MAX_IDLE_TIME Updates SetPoolSettings to validate that MaxIdleConns does not exceed MaxOpenConns, providing a warning if it does and capping it. Change-Id: I74edac05c4a23102d64e74a180c661c223e1b757 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/747620 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Nicholas Husin <nsh@golang.org> Reviewed-by: Nicholas Husin <husin@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2026-02-09go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ib5e6476d1539dc52fa50f2842d0066e3bcf243cd Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/743408 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
2026-01-12go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I5801b1fd083b0a88c8848bd9e49723fe34cae7ba Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/735765 Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-12-23cmd/internal/doc: increase x/pkgsite dependency to CL 729900matloob
So that go/doc could show docs for the new experiments. I updated the go command to use the latest commit of the doc module but id didn't yet have a dependency on a version of pkgsite that included Sean's changes. This CL adds that dependency, and then we'll have to re-update 'go doc' to depend on a version of this module that includes this CL. Commands run from cmd/internal/doc: go get golang.org/x/pkgsite@4eb0af2 go mod tidy For golang/go#71488 Change-Id: I228ba4477876a26bca8c91b44c254ce16a6a6964 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/732240 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Michael Matloob <matloob@golang.org> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> TryBot-Bypass: Michael Matloob <matloob@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2025-12-22internal/dcensus: add metrics for codewiki link usageEthan Lee
- Count link usage, target url and referrer page. - To avoid increasing dependency size, use indirection to call recordCodeWikiMetrics. Example: Run `go run ./cmd/frontend/main.go -dev -direct_proxy` and access pkgsite via localhost:8080. After clicking on the link, observe the relevant metric logged in localhost:8081/statz. Run `go test -v -run TestCmdPkgsiteDeps` to ensure that cmd/pkgsite dependencies remain stable. Change-Id: Ib312584162b81deac4c22b4ed923ff783133e11e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/731020 Reviewed-by: Jonathan Amsterdam <jba@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-12-09go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I90bbb062ee42f45f23b2a4d97447d7bbb066b324 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/728523 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Gopher Robot <gobot@golang.org>
2025-11-13go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I9da6bcee42ffb7f1ebdffcfca8b0c6673f3551dc Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/720163 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: David Chase <drchase@google.com>
2025-10-09go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I54ac128d9a58c1b2aaa15e17c0e4415c357d8d6a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/710110 Auto-Submit: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
2025-09-11go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Icf4a7bbd4511c2eb8c7ce94ea7c5aa9c4b09cdcf Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/702045 Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2025-09-08cmd/internal/cmdconfig: include Cloud Run instance ID in logsMichael Pratt
This aids in diagnosing per-instance issues. The instance ID seems like it would belong in the MonitoredResource labels (configured in serverconfig), but the top-level instanceId field is the standard name for this field on Cloud Run. Log messages going directly to stderr (before we configure logging) get this label automatically from the Cloud Run infra. When we use stackdriver directly we apparently need to add this ourselves. See https://cloud.google.com/run/docs/logging#service-fields. Change-Id: I6a6a636cb11a2abc00347e0679605ebbdb9995f4 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/700396 Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2025-08-08go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I0e93b41c2ab47eb6c42f2f91398beaa1c455461c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/694005 Auto-Submit: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2025-07-14cmd/internal/pkgsite: increase x/pkgsite dependency to CL 687918Michael Matloob
This CL increases the dependency on the golang.org/x/pkgsite module to include the changes in CL 687918. For golang/go#74459 Change-Id: I8e72c9e841b081ad9818d86a4fd8aa8ee499ad52 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/687976 Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Matloob <matloob@google.com> Auto-Submit: Michael Matloob <matloob@golang.org>
2025-07-14cmd/internal/pkgsite: improve godoc mode search in GOROOTMichael Matloob
If a user starts go doc -http inside of GOROOT, we create three module getters when we only need one: We create a StdlibZip module getter which we're not going to use because we're using a local GOROOT, we create a gopackages module getter for the module determined as corresponding to the current directory, which is a stdlib module, and finally we create the NewGoPackagesStdlibModuleGetter, which is the main module getter for the standard library in that case. The StdlibZip module getter is not used when we're using a local GOROOT, so don't add it in that case. And if we detect that the module for a specified directory is std or cmd for the specified local GOROOT, skip adding it because it will be redundant with the module getter we create using NewGoPackagesStdlibModuleGetter specifically for the standard libarry. Removing the redundant module getter will prevent redundant search results returned by each of the gopackages module getters corresponding to the standard library. While we're here, if there's a VERSION file in GOROOT, set the version on the module metadata we return for the standard library to the stdlib.VersionForTag of that version, so we can report the version in the search results. Fixes golang/go#74459 Change-Id: If250f715b052f57f8668b02a57b4c96725be515a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/687918 Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Matloob <matloob@google.com> Auto-Submit: Michael Matloob <matloob@golang.org>
2025-07-11go.mod: update golang.org/x dependenciesGopher Robot
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I7976645ea13a7d7e8f322d311290d85b1ba9bc5d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/687560 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-06-24Revert "internal/frontend: recycle database connections every 5m"Robert Findley
This reverts commit 4b544d88ef33b543889e92d50bcc7b02d4b95ff0. Reason for revert: From slack, this causes the following error: 2025/06/23 21:17:14 Error: middleware.Panic: sql: Register called twice for driver ocWrapper-pgx Change-Id: I7caf80f4e13ca341e2f29d20c4b5b9ed963695b2 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/683635 Auto-Submit: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2025-06-23internal/frontend: recycle database connections every 5mRob Findley
In order to avoid imbalance between pkgsite's two database instances, recycle connections every 5 minutes. Change-Id: I9ca1e686a90f8c61619fd76454ec66163e501ee1 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/680175 kokoro-CI: kokoro <noreply+kokoro@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2025-05-30cmd/internal/doc: enable go doc modeMichael Matloob
This turns off unnecessary UI and doesn't try to get deps.dev urls or vulnerability info. Change-Id: I2c7567a5d3e93e6a9b1a8b84f863f0dfe9a79d04 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/675958 Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Michael Matloob <matloob@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Auto-Submit: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-05-30internal/frontend: add a go doc mode to suppress some UI elementsMichael Matloob
This change adds an option to the server to suppress the unit header details and the right hand side unit metadata that's shown on pkgsite, when it's operating in go doc mode. In this go doc mode, it will also not fetch the deps.dev url or vulnerability information, so that pkgsite doesn't make unnecessary network calls. The behavior to allow no modules to match the pattern has also been folded into go doc mode. I think we may also want to make some CSS changes too but I think those would belong in another CL. Change-Id: I8b6ebb5594f73684d2db41a84e1b6d46ee95d774 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/675957 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-05-20cmd/internal/doc: set go.mod go version to 1.24.3Michael Matloob
The proxy and sumdb don't know how to fetch 1.25 modules (and we break a bunch of other things) so downgrade to the latest released go version so that the module can be fetched. For golang/go#68106 Change-Id: I611614ca814c8f8640bf886029cc702b3acc8cf0 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/674575 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2025-05-20cmd/internal/doc: add doc command in its own moduleMichael Matloob
This change adds a simpler version of cmd/pkgsite, called simply 'doc', that will be invoked by the go command to show package documentation in the browser. This version has a couple of small changes. The first is that it uses the AllowNoModules option added to the server to allow no modules to match. It also makes the logging more quiet so that it's more in line with expectations for a go tool. Finally, it takes the path of the page to open in the browser to open after we start listening on the given address. The unused functionality of cmd/pkgsite is stripped out of the doc command. The doc command is placed into its own module, in the cmd/internal directory so we can see the set of module dependencies in the go.mod file is limited to the smaller set of modules that cmd/pkgsite's dependencies were limited to. For golang/go#68106 Change-Id: Iab9db7c02044a5e08c1f6bc6894b24a400382aae Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/674437 Reviewed-by: Michael Matloob <matloob@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2025-05-20cmd/internal/pkgsite: add AllowNoModules option to ServerConfigMichael Matloob
If the user is outside of any modules, they should be able to still get documentation for the standard library. Allow no matching modules so we don't exit the command if no modules were found. For golang/go#68106 Change-Id: Ie9a06e1a3b055e3d13957019d06677f5aed46f4d Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/674436 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Michael Matloob <matloob@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2025-03-11go.mod, misc: update to go 1.24Jonathan Amsterdam
Change-Id: Iba3d15376214048113314150944d3b0df187a8cf Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/656475 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
2024-07-24cmd/pkgsite: fix setting gorepo flagMichael Matloob
The value of the gorepo flag variable was being used before flags were parsed. Fix that. Also fix a couple of other issues that came up in golang/go#68533: First, don't print "searching GOPATH" when we're not searching GOPATH. Second, print the stderr from the go command in the error when it fails because it's the stderr that usually provides information about the failure, not the stdout. For golang/go#68533 Change-Id: Ic6321d6e071dd82415474f2a2c54146e9eabbef7 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/600917 Reviewed-by: Jonathan Amsterdam <jba@google.com> Auto-Submit: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2024-02-07cmd: split the cmd/pkgsite server building logic to a new packageMichael Matloob
This will allow us to create a separate binary (probably called cmd/pkgdoc) that will be started by "go doc" to serve pkgsite. The separate binary can have different flags and options. Change-Id: Ie8c2cdce4c850c9f787db12679c872f279c435ad Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/561340 kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
2023-08-25internal/config: separate config initialization into serverconfigMichael Matloob
This change creates a new package that does config initialization and other GCP-specific operations that were previously done in package config, so that config can have no cloud dependencies. For golang/go#61399 Change-Id: I8d78294834e325b47d838892a1cef87003a4b90a Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/522516 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
2023-08-07internal/config: remove dependency on MonitoredResource protoMichael Matloob
For golang/go#61399 Change-Id: I90070de1c2fcde2bb4056c30637d4ff4fdf100f5 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/515376 kokoro-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Jamal Carvalho <jamal@golang.org>
2023-08-07cmd/log: move stackdriver logging to its own packageMichael Matloob
This change breaks out the stackdriver logging to its own package. It also only does logging of trace ids and labels to the stackdriver logger, to keep the logging interface simple. For golang/go#61399 Change-Id: I9a25d0c6391d1667fe476e5fdc30fc057f07c40f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/515375 TryBot-Result: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Jamal Carvalho <jamal@golang.org>
2023-08-04internal/frontend: remove dependency on cloud error reporting clientMichael Matloob
This removes the dependency of internal/frontend on the cloud error reporting client, both directly, and through the derrors package by introducing a new interface Reporter that is used both to set the reporting client for internal/derrors, and on the Server. For golang/go#61399 Change-Id: Id4d4def522cda9b4e49f53cff6708019dec2693c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/514676 Reviewed-by: Jamal Carvalho <jamal@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org>
2021-07-14cmd,internal: refactor UseStackdriverLoggerJulie Qiu
Because UseStackdriverLogger currently uses the config package, the config package uses the standard library logger instead of internal/log from the pkgsite repo. Since UseStackdriverLogger only requires a few pieces of information from cfg, it is refactored to accept those args explicitly. Change-Id: I80bbbb1e8de7b1d21b685f201f55e948c3946b75 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/333930 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-07-12cmd,internal: downgrade logs to debugJulie Qiu
Logs related to reading the experiment config file are downgraded to debug level to reduce noise during development, since these logs appear every minute. Change-Id: I80169a30e6eeb3829be0324fb901a9da13bb8300 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/332376 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-06-18config, etc: remove GO_DISCOVERY_DATABASE_DRIVER env varJonathan Amsterdam
Hard-code "pgx". Change-Id: I5787d67704fddbee2f9b2f7b94497906b168a970 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/329170 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> Reviewed-by: Julie Qiu <julie@golang.org>
2021-06-16devtools/cmd/seeddb: moved from cmd/internal/seeddbJulie Qiu
Pure code in motion. Tests are fixed in the next CL. Change-Id: Ib59f59cad231baab763c6f74ba1f8aaf995063ee Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/327931 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-06-09cmd/internal/seeddb: add script to seed dbJulie Qiu
A script is added which can be used to seed a database with modules. Change-Id: I322cb6a5919f04cc9c75fca0ea2e23a91c01639e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/325749 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Jamal Carvalho <jamal@golang.org>
2021-04-29cmd/internal/testing/stdlibsymbol: delete unused scriptJulie Qiu
This script is a duplicate of one in the private repo. Change-Id: Ib254d8c4db6e897eb7ba5f94c1a2d811c8451987 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/314691 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-04-29internal/symbol: update ParsePackageAPIInfo for non-stdlib packagesJulie Qiu
ParsePackageAPIInfo is updated to handle apidata for both stdlib and third-party packages. It also handles information for constants and variables. For golang/go#37102 Change-Id: Ia2a6a374cecb843700b9187e77ac7c395c23392b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/314535 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-03-25internal/database: wrap OpenCensus sql driverJonathan Amsterdam
The datbase/sql package provides a way to get at the underlying driver's connection. We will need that feature to access pgx's fast CopyFrom method. Unfortunately, we do not use the pgx driver directly. Instead, we wrap it in an OpenCensus driver for tracing and metrics. And that OpenCensus driver's connection does not allow us to dig into _it_ to retrieve the pgx connection that it wraps. Hence this dance: we must write our own driver and connection implementations. The driver return the connection, and the connection holds both the underlying (pgx) connection and the OpenCensus connection, to which it delegates. This CL is a no-op; everything behaves as before. But it lays the groundwork for a subsequent CL that will use pgx's CopyFrom. Change-Id: I5bf308aa23f07f20d1f6410ebb04cd6b9a5e0922 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/304630 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Julie Qiu <julie@golang.org>
2021-03-23cmd/internal/testing/stdlibsymbol: fix build errorJulie Qiu
The type for frontend.Symbol has changed since tests passed for CL 300173, which caused build errors that are fixed. Change-Id: I71264a14dddaf9ef7a417091db9455bd9b9455ee Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/304089 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-03-23cmd/internal/testing/stdlibsymbol: add stdlib versions page testJulie Qiu
A script is added which tests the output of the stdlib versions page with data from the api/goN.txt files. For golang/go#37102 Change-Id: Ie3e5388f502e2d11fc0388ee64f27493978d97a6 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/300173 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-03-09Revert "cmd/internal/testing/stdlibsymbol: add stdlib versions page test"Julie Qiu
This reverts commit ef291491fb30b08d4ac6530f828963d77d91cca8. Reason for revert: This was blocked on CL 298309 before merging, otherwise there is a vet error Change-Id: I5fa2b06e17edb07af75b0f67db53b633bbcdfd27 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/300129 Reviewed-by: Jonathan Amsterdam <jba@google.com> Trust: Julie Qiu <julie@golang.org>
2021-03-09cmd/internal/testing/stdlibsymbol: add stdlib versions page testJulie Qiu
A script is added which tests the output of the stdlib versions page with data from the api/goN.txt files. Change-Id: Id41f543ca5fc2c060a321c42bf26a39cbf064f05 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/299350 Trust: Julie Qiu <julie@golang.org> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-02-19cmd,internal/symbol: add stdlib API comparison scriptJulie Qiu
A script is added at cmd/internal/testing/stdlibsymbol/main.go, which compares the stdlib API data in https://go.googlesource.com/go/+/refs/heads/master/api with that of the symbol_history table. This script is used to check that data on pkgsite is accurate during development. Change-Id: Ib453dc8d63ee45cc3c8eb40365f9baf5636adec3 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/293429 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
2020-12-17internal/derrors,etc.: report errors lower in the stackJonathan Amsterdam
The data we get from the errorreporting API isn't too useful because the call to Report happens high on the stack. Try to call Report closer to where the error happens. Change-Id: I101fb4de0892c5d9967f6eb46d7c9cbd72fb567e Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/278952 Trust: Jonathan Amsterdam <jba@google.com> Trust: Julie Qiu <julie@golang.org> Run-TryBot: Jonathan Amsterdam <jba@google.com> Run-TryBot: Julie Qiu <julie@golang.org> Reviewed-by: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com>
2020-11-24cmd/internal/cmdconfig: factor out DB openingJonathan Amsterdam
Change-Id: If9be542ae7b50789c548f19dbab419a2db74e8ca Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/272793 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Julie Qiu <julie@golang.org>
2020-10-20internal/config: support disabling error reportingJonathan Amsterdam
We don't always want to get emails about errors (for instance, for our dev environment). The product doesn't support selectively emailing by service, so disable error reporting in the binary instead. Change-Id: Ia5abc50a86dbdb22d14cddc36c0450d2e505ff1b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/262997 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Julie Qiu <julie@golang.org>
2020-10-07cmd/internal/cmdconfig: fill in experiment descriptionsJonathan Amsterdam
If an experiment lacks a description in the config file, use the description from internal.Experiments. Log an error if the experiment name is not in that map. Change-Id: I3362d9a71d963a202d1616b9f2c6cf347314332c Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/260117 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> Reviewed-by: Jamal Carvalho <jamal@golang.org>
generated by cgit v1.3 (git 2.53.0) at 2026-04-15 13:36:47 +0000