| Age | Commit message (Collapse) | Author |
|
It's working now.
Also fix, issues that it detected.
Change-Id: Ifd3fe5baf9a56d31bafe099bf4b38e02356bde21
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/760582
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ethan Lee <ethanalee@google.com>
|
|
- Fix npm vulns.
- Fix the minimized-css check to look only at the working dir.
Change-Id: Iecf2c5ef35813fef16df22147f795cda814fef2b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/608037
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
|
|
Add a check that the minified css files correspond to the their sources.
Previously, the all.bash script generated the minified files and left
the modified files in the repo working copy. This may have helped during
development, but during CI it should be a no-op. This CL simply verifies
that. The developer can still run `devtools/cmd/static` manually.
A check like this should be standard procedure for all binary or
incrutable files that appear in CLs.
Change-Id: I47d34e5204637ff38113b91ff46c595b9f42f4ee
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/585476
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
|
Done with:
go run cloud.google.com/go/internal/aliasfix/cmd/aliasfix@latest .
go mod tidy
As suggested in the package deprecation note¹.
¹ https://pkg.go.dev/google.golang.org/genproto/googleapis/cloud/tasks/v2#pkg-overview
Change-Id: I78df9037198e5460a2e00339727a06282cf8a701
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/526315
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
|
Done with 'go mod tidy' using go1.21.0.
This uncovers that some deprecated packages and types are used.
Temporarily change the SA1019 check to use zero exit code, and
the next CL moves to non-deprecated packages and re-enables it.
Change-Id: I65f582da11e5c6925c00392953a7965ed8a02686
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/525978
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
|
|
This will make pkgsite pick up the latest 1.20.x.
And
- reenable staticcheck.
- mark the working directory as safe when running for ci.
(this workaround is needed after the security patch
https://release.debian.org/proposed-updates/bullseye_diffs/git_2.30.2-1+deb11u1.debdiff)
Updates golang/go#53532
Change-Id: I31c5fc838821d8bd6ade81dc439eb46fabb75fe1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/468917
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
- Disabled staticcheck while go1.20 is unsupported.
- Fixed out of bounds error in doc html parsing.
- Fixed test issue related to rand package changes.
Change-Id: Ib7b30ed9c40505a5a51d986426f0e41e53a298b1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/464296
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
|
|
Most of the checks were about io/ioutil. There were a couple of
other minor ones. I didn't address the check for strings.Title;
instead, I turned off that check globally with a staticcheck.conf
file.
Change-Id: I286a6894fb1fd891818ab9e451c891f52a3828fc
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/412675
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Also, comment out unparam because it doesn't work on generic
code yet.
Change-Id: I821e29e9011781d851b9b468dae56f47695d7450
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/389655
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
For golang/go#48264
Change-Id: I55e512051450fb4bbc58fe00872c5d7077988ccb
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/382974
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Change-Id: I5f4f857b576fd68b0d5f58f7926bb598dbfe3cdb
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/382979
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Change-Id: I342703673651430c6be19ea52fd35833cbf158ef
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/382094
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
`all.bash prettier` accepts a list of files.
Change-Id: Iefde5d5cd22ab5790c968e4641422acc22e28889
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/364694
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
run_build_static is now the first step of all.bash, to make it faster to
remove static/ changes when running in -dev mode.
Change-Id: I38f2f0f5bc9206d2c5f33f3907f7f79c66b031c9
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/346409
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
|
|
Added --fix option to TS and CSS linters and removed
TS and CSS files from the prettier file glob. Prettier
is run through eslint and stylelint already so checking
these files is redundant.
Change-Id: I1004b48a7fd3b142e1ea15af382a6e713ed03679
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/335491
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Change-Id: I0c263beee2439ec924cfeaed6d1540678ffe7fc2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/329049
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Additional logs are added to ci.sh which show how long each section of
CI took.
Change-Id: Id733bf8a1e4cbf490687c3c99ef9bac263c0812c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/327472
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Change-Id: I34bd964e568a41391775108f74173d0860bf618b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/327298
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
The check for script hashes will be broken until CL 327283.
The unused hashes are still necessary until the reads have
been switched over to the new template files.
Change-Id: Id5d912407f8aebc31542e3e0e1e76455a1d4002e
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/327280
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
A copy of devtools/ci/nodejs.sh is made to devtools/nodejs.sh, and the
latter is now referenced where devtools/ci/nodejs.sh was previously used.
This makes it easier to comment out tests when testing configuration
changes to kokoro.
Also, since the contents of ./devtools/nodejs.sh are used in non-ci
parts of the repo, so it makes sense to have that script outside the ci/
folder.
In a future CL, rather than having these 3 lines in the kokoro config:
devtools/ci/nodejs.sh npm install --quiet
devtools/ci/nodejs.sh npm run lint
devtools/ci/nodejs.sh npm run test
They will be moved to devtools/ci/nodejs.sh, which will use
devtools/nodejs.sh.
Change-Id: I156324a625666ead31be18ae19e5608d38e0faf1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/326989
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Runs npm and npx commands by default using the
docker helper script instead of the local install.
This will keep everyone synced on the nodejs version
and CI current with our local setup.
You can override this by setting GO_DISCOVERY_NPM_CMD=npm
and GO_DISCOVERY_NPX_CMD=npx to use your locally installed
binaries.
Change-Id: I08841e372d995229eb9ceba328c4a17e2f4c420c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/326549
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Jamal Carvalho <jamal@golang.org>
|
|
Files used for kokoro are copied to devtools/ci along with a README.md,
so that it is clear what these files are used for.
The existing files will be deleted in the next CL, after an internal CL
is merged to change references.
Change-Id: I893ac9461d3f775460ba749da80e2b4ba71dcc1e
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/325129
Trust: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
We will need to run npx commands with docker when
running tests in CI. This change creates an npx
command in all.bash and modifies the docker_nodejs
script to share networking with the host so it can
connect to a local instance of the frontend.
Change-Id: Id8f32a7ff5bf017cb55c531b1e37a3f8aab0e73a
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/322635
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
The content of the styleguide page is generated from
the markdown files contained in the component directories
of content/static. We use goldmark to parse the files
into html sections and generate an outline for the sidenav.
Goldmark is extended to render html code blocks as both
html and code snippets.
Change-Id: I023edb77114001439be58e00d5a48198181f165a
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/320654
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Updates prettier file glob to ignore JS files
and process TS files. The repo should not contain
any JS files outside of generated or minified code.
Change-Id: I1167b96c1d0d2ab2da5e9cf4d40c2b2fd79e70fd
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/320990
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Switching all.bash to use a locally installed version
of prettier to remove the expectation that it is
globally installed.
Change-Id: Ib3bf0da16b3d8bfad817be693fff62776f6e99da
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/313529
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Using run_npm instead of npm directly in bash scripts.
This will default to local npm when available but use
docker-ized npm when the npm command is not found on
the host machine.
Change-Id: I08c0e69c5f18a29059eaf4787bc03d8eba99562b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/311349
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Change-Id: Ic3686f67bcf853241a11b1bbb2b2f8bf164ec5df
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/311229
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
The e2e tests will prefer a locally installed npm binary and
use a prebuilt headless chrome docker image. This will speed up
test runs for devs with npm installed but still leave the option
to opt out of installing node directly on the host machine.
Jest now uses a custom test environment that initializes global
variables, starts chrome, and adds authorization headers to
requests.
Change-Id: Ie43952ada6fd3e4df0fd522c84691186ef0d7f80
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/310314
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
When the frontend server is run in dev mode it
builds the JavaScript out files unminified which can
leave behind unstaged files with unwanted changes.
Currently, all.bash checks that the minified
JavaScript files match the output from compiling
the TypeScript files. This change updates the script
to write the files on run to clean up the content/js
folder after running the frontend in dev mode.
Change-Id: I6bed05613bae97430fc6c8a47a611eb673d1fb43
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/303770
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Adds a check for script output. Ensures minified
code matches the expected output for the current
source files.
Change-Id: I9d6b2ae52a6885c6fb68fc4b5fc1b65f8149346f
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/300232
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Some files output by the TypeScript compiler
have an additional line above the license
header. Adding an additional line of buffer
for the header check.
Change-Id: I157d3210980149f5b91d2005ec2a178955af3e96
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/299252
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
Updates ./all.bash to rebuild services on tests run
so that devs do not have to remember to manually
rebuild them. The builds are cached so this
should not be too much of a pain.
Change-Id: I0c490794ed0ba5f62a2d936dcd4a23a33a92e8f5
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/298369
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
The raw-latest system is replaced by the latest-version system.
For golang/go#44710
Change-Id: Id59f03aa3078c05e2a91b58d92633cc73dea4c3e
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/298234
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
all.bash will now fail if misspell fails.
Change-Id: Ida72c27469bef5f4b2a48f80221e925df6b2936d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/296630
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
When fetching a module at a version, the proxy datasource uses
fetch.RawLatestInfo to get the go.mod file at the raw latest version
of the module, then uses internal.RawLatestInfo.PopulateModule to
determine whether the module version is deprecated or retracted.
Also, add some proxy test modules to facilitate testing.
For golang/go#41321
For golang/go#43265
For golang/go#44437
Change-Id: I312346d72f656e598ad170135046ef85da8e9b11
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/295430
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
The docker service for npm was renamed to
nodejs. Updates the docker-compose run command
to use the new service name.
Change-Id: Id13f5eaa89bfc189dbda4a5867cdb09279375f4b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294950
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
`all.bash cl` will run checks only on files for the current CL.
Change-Id: I77a057accf6995a54ac85aa81365243e54e2b01d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294629
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
- Create a command to run npm scripts as a relacement
for devtools/npm.sh.
- Adds unit tests to all.bash run and a commmand to e2e tests
locally.
For golang/go#43361
Change-Id: I8bff0358c9e71b6790ee2f1516716c46bc07a702
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/292696
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Change-Id: Ia3d0353f3922b0af1faaf7ce5a541f56517011d2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/284198
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
It takes too long on some DB-heavy tests.
Change-Id: I69c410b664d2c28b00749f4a1cc011c1f68dafb3
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/285814
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
|
|
When a staticcheck error occurs, upgrade it to an error so that CI
will fail for the change.
Change-Id: Ied94c9829eed6863b4fc5a1d4c4bb979a7c06c27
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/281993
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
|
|
Updates all.bash to use a dockerized prettier install as a fallback
when prettier is not installed globally. For now the script will
only use the container if it has already been built. We could change
this in the future to automatically build the image but this will give
everyone a chance to test it out first. To build the image run
'docker-compose -f devtools/config/docker-compose.yaml build' from the
repo root.
Change-Id: I56ad2cd2da2fe0dbbf46636024f44cc614adb168
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/275532
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Change-Id: Iabc2eec0f1835f4bbdfe045be074efbc58b0515d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246242
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Consider any code after the last "// Output:" comment to
be "cleanup" code and omit it from the example.
Fixes golang/go#40517.
Change-Id: I17e0b6859d188192cf1f2eb851d8d8888229ff63
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/246241
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
We don't use KMS or a secrets bucket anymore; we use Secret Manager.
Change-Id: I5afba05927dccb8efa6c0d76aec5380d30bb31cf
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/245920
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Add `go vet -all` to our standard checks.
It checks some things that staticcheck doesn't. Notably, closing over
loop variables.
Currently none of the checks are false positives, so might as well run
them all (it takes about 2s). If we later find one we disagree with,
we can disable it.
Change-Id: Ie11b5d8fd7250f8b55b474a662fe78f139f23a6e
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/241797
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
For simplicity, add a new script that runs all.bash CI using Docker
only. This will facilitate hooking into Kokoro (a Google internal CI
runner).
Change-Id: I2faa6190e6ecc35a2b2dc9151f173dc07f80d9b5
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/241603
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Add a tool that checks the script hashes used
for our Content Security Policy (CSP).
Run the tool from all.bash.
(Also, prettier decided to change CONTRIBUTING.md.)
Fixes b/159711607.
Change-Id: I4498a19143c53fb90bcf0560ccaf529f4fb72a81
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/240138
Reviewed-by: Julie Qiu <julie@golang.org>
|
|
Change-Id: I73efcea136731bcb80a08cdc3702ba62e65b138f
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/237977
Reviewed-by: Julie Qiu <julie@golang.org>
|