diff options
| author | Jonathan Amsterdam <jba@google.com> | 2021-06-09 07:28:03 -0400 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2021-06-09 17:56:31 +0000 |
| commit | 3f6ba65acd671c661c4cc4ec7396f9216a5a656d (patch) | |
| tree | db99aa5ae7c743fe6955345884909c9aaab58785 /internal/worker/server.go | |
| parent | 6606008756175243019de712757dc9ce8499a276 (diff) | |
| download | go-x-pkgsite-3f6ba65acd671c661c4cc4ec7396f9216a5a656d.tar.xz | |
internal/worker: add metric for new unprocessed modules
We have a metric for total unprocessed modules, including new ones and
those we are reprocessing.
Add a metric that tracks only the new ones: those with status 0 or 500
(the latter to count the number of failed new modules).
This metric is a better choice for an alert, since during reprocessing
we expect a very large total backlog, but we never want a large
backlog of new modules.
Change-Id: Ibc3cbee1d867f6a454748237352a70cf9eb500c0
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/326290
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Diffstat (limited to 'internal/worker/server.go')
| -rw-r--r-- | internal/worker/server.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/internal/worker/server.go b/internal/worker/server.go index 88da9676..9f299a5e 100644 --- a/internal/worker/server.go +++ b/internal/worker/server.go @@ -401,12 +401,12 @@ func (s *Server) computeProcessingLag(ctx context.Context) { } func (s *Server) computeUnprocessedModules(ctx context.Context) { - n, err := s.db.NumUnprocessedModules(ctx) + total, new, err := s.db.NumUnprocessedModules(ctx) if err != nil { - log.Warningf(ctx, "NumUnprocessedModules: %v", err) + log.Warningf(ctx, "%v", err) return } - recordUnprocessedModules(ctx, n) + recordUnprocessedModules(ctx, total, new) } // handleEnqueue queries the module_version_states table for the next batch of |