diff options
| author | Jonathan Amsterdam <jba@google.com> | 2021-01-29 18:44:53 -0500 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2021-02-02 19:36:47 +0000 |
| commit | 814534999dcbf4fa3d7b358a6de57bf2d44fc450 (patch) | |
| tree | 712ffee18ee7ac7953160860419735cfe0402eec /internal/worker/refetch_test.go | |
| parent | 1fe92ed1d8906c5c7253e7f1f03cb008e08a640c (diff) | |
| download | go-x-pkgsite-814534999dcbf4fa3d7b358a6de57bf2d44fc450.tar.xz | |
many: allow for multiple documentations for a Unit
Change internal.Unit.Documentation from a single
internal.Documentation to a slice, so that a Unit can have doc for
multiple build contexts.
However, don't use this ability yet: fetch takes only the first
build context it finds, postgres inserts only the first, frontend
renders only the first, etc.
For golang/go#37232
Change-Id: I17fd1ff2378e0862c029c8077057c207001f6136
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/288217
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Diffstat (limited to 'internal/worker/refetch_test.go')
| -rw-r--r-- | internal/worker/refetch_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/internal/worker/refetch_test.go b/internal/worker/refetch_test.go index a5a6f570..0bf54fad 100644 --- a/internal/worker/refetch_test.go +++ b/internal/worker/refetch_test.go @@ -100,11 +100,11 @@ func TestReFetch(t *testing.T) { Filepath: "bar/README.md", Contents: "This is a readme", }, - Documentation: &internal.Documentation{ + Documentation: []*internal.Documentation{{ Synopsis: "Package bar", GOOS: "linux", GOARCH: "amd64", - }, + }}, Subdirectories: []*internal.PackageMeta{ { Path: "github.com/valid/module_name/bar", @@ -138,7 +138,7 @@ func TestReFetch(t *testing.T) { t.Errorf("mismatch on readme (-want +got):\n%s", diff) } if got, want := gotPkg.Documentation, want.Documentation; got == nil || want == nil { - if got != want { + if !cmp.Equal(got, want) { t.Fatalf("mismatch on documentation: got: %v\nwant: %v", got, want) } return |