diff options
| author | Jonathan Amsterdam <jba@google.com> | 2020-09-17 16:00:30 -0400 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2020-09-18 14:21:51 +0000 |
| commit | 89b8b3974dfea17b2fd457f1574da9c5a511f16b (patch) | |
| tree | 037199dd1f67159ec387c7c41bbb8b02223f6c45 /internal/stdlib/stdlib_test.go | |
| parent | 21c3920079c6dab66055fb05418cf01dbded99fe (diff) | |
| download | go-x-pkgsite-89b8b3974dfea17b2fd457f1574da9c5a511f16b.tar.xz | |
internal/stdlib: Zip takes resolved version
In the only call to this function, we already know the resolved
version.
For golang/go#41452
Change-Id: I96e5ebdf5acb0aeec45288b25b555e5c6cbb52ee
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/255757
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Diffstat (limited to 'internal/stdlib/stdlib_test.go')
| -rw-r--r-- | internal/stdlib/stdlib_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/internal/stdlib/stdlib_test.go b/internal/stdlib/stdlib_test.go index 253c84cd..77786166 100644 --- a/internal/stdlib/stdlib_test.go +++ b/internal/stdlib/stdlib_test.go @@ -115,9 +115,9 @@ func TestZip(t *testing.T) { UseTestData = true defer func() { UseTestData = false }() - for _, version := range []string{"v1.14.6", "v1.12.5", "v1.3.2", "latest"} { - t.Run(version, func(t *testing.T) { - zr, gotTime, resolvedVersion, err := Zip(version) + for _, resolvedVersion := range []string{"v1.14.6", "v1.12.5", "v1.3.2"} { + t.Run(resolvedVersion, func(t *testing.T) { + zr, gotTime, err := Zip(resolvedVersion) if err != nil { t.Fatal(err) } @@ -178,7 +178,7 @@ func TestZipInfo(t *testing.T) { UseTestData = true defer func() { UseTestData = false }() - gotVersion, gotSize, err := ZipInfo("v1.14.6") + gotVersion, gotSize, err := ZipInfo("latest") if err != nil { t.Fatal(err) } |