internal: remove experiment insert-symbol-search-documents

This experiment is live in all environments and can be removed.

For golang/go#44142

Change-Id: Ie653e833b8fc04d5a538fab41137ca77a0989125
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/341451
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>

4 files changed, 0 insertions, 27 deletions

diff --git a/internal/postgres/symbol.go b/internal/postgres/symbol.go
index 9bd14591..b40919f0 100644
--- a/internal/postgres/symbol.go
+++ b/internal/postgres/symbol.go
@@ -14,7 +14,6 @@ import (
 	"golang.org/x/pkgsite/internal"
 	"golang.org/x/pkgsite/internal/database"
 	"golang.org/x/pkgsite/internal/derrors"
-	"golang.org/x/pkgsite/internal/experiment"
 	"golang.org/x/pkgsite/internal/version"
 )
 
@@ -79,10 +78,6 @@ func upsertDocumentationSymbols(ctx context.Context, db *database.DB,
 	pathToDocIDToDoc map[string]map[int]*internal.Documentation) (err error) {
 	defer derrors.WrapStack(&err, "upsertDocumentationSymbols(ctx, db, pathToPkgsymID, pathToDocIDToDoc)")
 
-	if !experiment.IsActive(ctx, internal.ExperimentInsertSymbolSearchDocuments) {
-		return nil
-	}
-
 	// Create a map of documentation_id TO package_symbol_id set.
 	// This will be used to verify that all package_symbols for the unit have
 	// been inserted.
diff --git a/internal/postgres/symbol_test.go b/internal/postgres/symbol_test.go
index 845da028..5d9431de 100644
--- a/internal/postgres/symbol_test.go
+++ b/internal/postgres/symbol_test.go
@@ -16,7 +16,6 @@ import (
 	"golang.org/x/pkgsite/internal"
 	"golang.org/x/pkgsite/internal/database"
 	"golang.org/x/pkgsite/internal/derrors"
-	"golang.org/x/pkgsite/internal/experiment"
 	"golang.org/x/pkgsite/internal/testing/sample"
 )
 
@@ -25,9 +24,6 @@ func TestInsertSymbolNamesAndHistory(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx,
-		internal.ExperimentInsertSymbolSearchDocuments,
-	)
 	defer cancel()
 
 	mod := sample.DefaultModule()
@@ -91,9 +87,6 @@ func TestInsertSymbolHistory_Basic(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx,
-		internal.ExperimentInsertSymbolSearchDocuments,
-	)
 	defer cancel()
 
 	mod := sample.DefaultModule()
@@ -122,9 +115,6 @@ func TestInsertSymbolHistory_MultiVersions(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx,
-		internal.ExperimentInsertSymbolSearchDocuments,
-	)
 	defer cancel()
 
 	typ := internal.Symbol{
@@ -225,9 +215,6 @@ func TestInsertSymbolHistory_MultiGOOS(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx,
-		internal.ExperimentInsertSymbolSearchDocuments,
-	)
 	defer cancel()
 
 	typ := internal.Symbol{
diff --git a/internal/postgres/symbolsearch.go b/internal/postgres/symbolsearch.go
index fd7053ed..d86ae3f7 100644
--- a/internal/postgres/symbolsearch.go
+++ b/internal/postgres/symbolsearch.go
@@ -13,10 +13,8 @@ import (
 	"strings"
 
 	"github.com/lib/pq"
-	"golang.org/x/pkgsite/internal"
 	"golang.org/x/pkgsite/internal/database"
 	"golang.org/x/pkgsite/internal/derrors"
-	"golang.org/x/pkgsite/internal/experiment"
 	"golang.org/x/pkgsite/internal/postgres/symbolsearch"
 	"golang.org/x/sync/errgroup"
 )
@@ -25,10 +23,6 @@ func upsertSymbolSearchDocuments(ctx context.Context, tx *database.DB,
 	modulePath, v string) (err error) {
 	defer derrors.Wrap(&err, "upsertSymbolSearchDocuments(ctx, ddb, %q, %q)", modulePath, v)
 
-	if !experiment.IsActive(ctx, internal.ExperimentInsertSymbolSearchDocuments) {
-		return nil
-	}
-
 	// If a user is looking for the symbol "DB.Begin", from package
 	// database/sql, we want them to be able to find this by searching for
 	// "DB.Begin" and "sql.DB.Begin". Searching for "sql.DB", "DB", "Begin" or
diff --git a/internal/postgres/symbolsearch_test.go b/internal/postgres/symbolsearch_test.go
index e5c44240..7777a2a8 100644
--- a/internal/postgres/symbolsearch_test.go
+++ b/internal/postgres/symbolsearch_test.go
@@ -11,13 +11,11 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	"golang.org/x/pkgsite/internal"
-	"golang.org/x/pkgsite/internal/experiment"
 	"golang.org/x/pkgsite/internal/testing/sample"
 )
 
 func TestSymbolSearch(t *testing.T) {
 	ctx := context.Background()
-	ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbolSearchDocuments)
 	testDB, release := acquire(t)
 	defer release()
 
@@ -122,7 +120,6 @@ func TestSymbolSearch(t *testing.T) {
 // (SQLSTATE 21000)
 func TestUpsertSymbolSearch_UniqueConstraints(t *testing.T) {
 	ctx := context.Background()
-	ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbolSearchDocuments)
 	testDB, release := acquire(t)
 	defer release()