internal/postgres: delete insert-symbols

Change-Id: I654b4b6186d49a9a8a83874747ab5ee9d909fe9a
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/310380
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>

3 files changed, 11 insertions, 22 deletions

diff --git a/internal/postgres/insert_module.go b/internal/postgres/insert_module.go
index 0b773fa1..ce2edcb6 100644
--- a/internal/postgres/insert_module.go
+++ b/internal/postgres/insert_module.go
@@ -413,20 +413,17 @@ func (pdb *DB) insertUnits(ctx context.Context, db *database.DB, m *internal.Mod
 		return err
 	}
 
-	if experiment.IsActive(ctx, internal.ExperimentInsertSymbols) {
-		pathToDocIDToDoc, err := getDocIDsForPath(ctx, db, pathToUnitID, pathToDocs)
-		if err != nil {
-			return err
-		}
-
-		// Only update symbols if the version type is release.
-		versionType, err := version.ParseType(m.Version)
-		if err != nil {
-			return err
-		}
-		if versionType == version.TypeRelease {
-			return insertSymbols(ctx, db, m.ModulePath, m.Version, pathToID, pathToDocIDToDoc)
-		}
+	pathToDocIDToDoc, err := getDocIDsForPath(ctx, db, pathToUnitID, pathToDocs)
+	if err != nil {
+		return err
+	}
+	// Only update symbols if the version type is release.
+	versionType, err := version.ParseType(m.Version)
+	if err != nil {
+		return err
+	}
+	if versionType == version.TypeRelease {
+		return insertSymbols(ctx, db, m.ModulePath, m.Version, pathToID, pathToDocIDToDoc)
 	}
 	return nil
 }
diff --git a/internal/postgres/symbol.go b/internal/postgres/symbol.go
index 631f8996..352ec200 100644
--- a/internal/postgres/symbol.go
+++ b/internal/postgres/symbol.go
@@ -23,9 +23,6 @@ func insertSymbols(ctx context.Context, db *database.DB, modulePath, version str
 	pathToID map[string]int,
 	pathToDocIDToDoc map[string]map[int]*internal.Documentation) (err error) {
 	defer derrors.WrapStack(&err, "insertSymbols(ctx, db, %q, %q, pathToID, pathToDocs)", modulePath, version)
-	if !experiment.IsActive(ctx, internal.ExperimentInsertSymbols) {
-		return nil
-	}
 	pathToPkgsymToID, err := upsertPackageSymbolsReturningIDs(ctx, db, modulePath, pathToID, pathToDocIDToDoc)
 	if err != nil {
 		return err
diff --git a/internal/postgres/symbol_test.go b/internal/postgres/symbol_test.go
index 0ea7b79e..7c713c56 100644
--- a/internal/postgres/symbol_test.go
+++ b/internal/postgres/symbol_test.go
@@ -12,7 +12,6 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
 	"golang.org/x/pkgsite/internal"
-	"golang.org/x/pkgsite/internal/experiment"
 	"golang.org/x/pkgsite/internal/testing/sample"
 )
 
@@ -21,7 +20,6 @@ func TestInsertSymbolNamesAndHistory(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbols)
 	defer cancel()
 
 	mod := sample.DefaultModule()
@@ -69,7 +67,6 @@ func TestInsertSymbolHistory_Basic(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbols)
 	defer cancel()
 
 	mod := sample.DefaultModule()
@@ -99,7 +96,6 @@ func TestInsertSymbolHistory_MultiVersions(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbols)
 	defer cancel()
 
 	typ := internal.Symbol{
@@ -175,7 +171,6 @@ func TestInsertSymbolHistory_MultiGOOS(t *testing.T) {
 	testDB, release := acquire(t)
 	defer release()
 	ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
-	ctx = experiment.NewContext(ctx, internal.ExperimentInsertSymbols)
 	defer cancel()
 
 	typ := internal.Symbol{