aboutsummaryrefslogtreecommitdiff
path: root/internal/postgres/versionstate.go
diff options
context:
space:
mode:
authorRob Findley <rfindley@google.com>2019-07-18 16:44:27 -0400
committerJulie Qiu <julie@golang.org>2020-03-27 16:46:40 -0400
commit4de3968c20ea65909ab9a6f9f5c0844089836127 (patch)
tree63093aebafaa0fd18952a3af177f97cb78b3609e /internal/postgres/versionstate.go
parenta2382caa20875804dda8672a96d4744228f0a176 (diff)
downloadgo-x-pkgsite-4de3968c20ea65909ab9a6f9f5c0844089836127.tar.xz
internal/postgres: fix a few places where rows were not closed
Updates b/137689600 Change-Id: Iaacee7a0b9ca50c4b665459f3f88bf503ff37bd4 Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/509283 Reviewed-by: Julie Qiu <julieqiu@google.com>
Diffstat (limited to 'internal/postgres/versionstate.go')
-rw-r--r--internal/postgres/versionstate.go2
1 files changed, 2 insertions, 0 deletions
diff --git a/internal/postgres/versionstate.go b/internal/postgres/versionstate.go
index 503b6a96..5d4741e6 100644
--- a/internal/postgres/versionstate.go
+++ b/internal/postgres/versionstate.go
@@ -179,6 +179,7 @@ func (db *DB) queryVersionStates(ctx context.Context, queryFormat string, args .
if err != nil {
return nil, fmt.Errorf("db.QueryContext(ctx, %q, %v): %v", query, args, err)
}
+ defer rows.Close()
var versions []*internal.VersionState
for rows.Next() {
@@ -284,6 +285,7 @@ func (db *DB) GetVersionStats(ctx context.Context) (*VersionStats, error) {
if err != nil {
return nil, fmt.Errorf("db.QueryContext(ctx, %q): %v", query, err)
}
+ defer rows.Close()
stats := &VersionStats{
VersionCounts: make(map[int]int),
}