diff options
| author | Julie Qiu <julie@golang.org> | 2020-11-23 16:19:05 -0500 |
|---|---|---|
| committer | Julie Qiu <julie@golang.org> | 2020-11-24 19:29:18 +0000 |
| commit | 5ae91b40136115b8d4587112fa253a6922e77500 (patch) | |
| tree | a3d6c76a66765d009365b9dd34cb058d2a2087ce /internal/postgres/unit_test.go | |
| parent | 4eb03ecca51b18dbfebd3f83e29431d33bac1878 (diff) | |
| download | go-x-pkgsite-5ae91b40136115b8d4587112fa253a6922e77500.tar.xz | |
internal/postgres: delete use of ExperimentUnitPage
ExperimentUnitPage is no longer used by internal/postgres.
Change-Id: I19a9f7953a87e559a4acdb5f4a3712f9b2a79f01
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/272609
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Diffstat (limited to 'internal/postgres/unit_test.go')
| -rw-r--r-- | internal/postgres/unit_test.go | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/internal/postgres/unit_test.go b/internal/postgres/unit_test.go index 9d81663d..68c797c9 100644 --- a/internal/postgres/unit_test.go +++ b/internal/postgres/unit_test.go @@ -161,16 +161,9 @@ func TestGetUnit(t *testing.T) { test.want.IsRedistributable, ) t.Run("unit page with one query", func(t *testing.T) { - checkUnit(ctx, t, um, test.want, internal.ExperimentUnitPage, internal.ExperimentGetUnitWithOneQuery) - }) - t.Run("unit page", func(t *testing.T) { - checkUnit(ctx, t, um, test.want, internal.ExperimentUnitPage) + checkUnit(ctx, t, um, test.want, internal.ExperimentGetUnitWithOneQuery) }) t.Run("no experiments", func(t *testing.T) { - test.want.Readme = &internal.Readme{ - Filepath: sample.ReadmeFilePath, - Contents: sample.ReadmeContents, - } checkUnit(ctx, t, um, test.want) }) }) @@ -208,8 +201,13 @@ func TestGetUnitFieldSet(t *testing.T) { defer ResetTestDB(testDB, t) + readme := &internal.Readme{ + Filepath: "a.com/m/dir/p/README.md", + Contents: "readme", + } // Add a module that has READMEs in a directory and a package. m := sample.Module("a.com/m", "v1.2.3", "dir/p") + m.Packages()[0].Readme = readme if err := testDB.InsertModule(ctx, m); err != nil { t.Fatal(err) } @@ -219,6 +217,9 @@ func TestGetUnitFieldSet(t *testing.T) { if fields&internal.WithDocumentation != 0 { u.Documentation = sample.Documentation } + if fields&internal.WithReadme != 0 { + u.Readme = readme + } if fields&internal.WithImports != 0 { u.Imports = sample.Imports u.NumImports = len(sample.Imports) @@ -252,10 +253,7 @@ func TestGetUnitFieldSet(t *testing.T) { name: "WithReadme", fields: internal.WithReadme, want: unit("a.com/m/dir/p", "a.com/m", "v1.2.3", "", - &internal.Readme{ - Filepath: "README.md", - Contents: "readme", - }, []string{}), + readme, []string{}), }, } { t.Run(test.name, func(t *testing.T) { |