diff options
| author | Jonathan Amsterdam <jba@google.com> | 2021-04-07 20:16:23 -0400 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2021-04-08 16:30:30 +0000 |
| commit | d025eb3c769441121bed31b2ad95f5ceea10ad4b (patch) | |
| tree | 6609eed1eb903662ca50f933d577d18167aadca5 /internal/postgres/insert_module_test.go | |
| parent | d189d9d19b2d6ec3358cc44d98c6354682aee052 (diff) | |
| download | go-x-pkgsite-d025eb3c769441121bed31b2ad95f5ceea10ad4b.tar.xz | |
internal/postgres,etc: finish MustInsertModule cleanup
Now that there are no callers of MustInsertModule, rename
MustInsertModuleLatest to MustInsertModule. We can
also remove MustInsertModuleLMV.
Change-Id: Ieb554ee32696c168be4cc0a14ecece9f4c6b91b4
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/308271
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Diffstat (limited to 'internal/postgres/insert_module_test.go')
| -rw-r--r-- | internal/postgres/insert_module_test.go | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/internal/postgres/insert_module_test.go b/internal/postgres/insert_module_test.go index ad6b3492..291bb4c3 100644 --- a/internal/postgres/insert_module_test.go +++ b/internal/postgres/insert_module_test.go @@ -80,9 +80,9 @@ func TestInsertModule(t *testing.T) { testDB, release := acquire(t) defer release() - MustInsertModuleLatest(ctx, t, testDB, test.module) + MustInsertModule(ctx, t, testDB, test.module) // Test that insertion of duplicate primary key won't fail. - MustInsertModuleLatest(ctx, t, testDB, test.module) + MustInsertModule(ctx, t, testDB, test.module) checkModule(ctx, t, testDB, test.module) }) } @@ -158,7 +158,7 @@ func TestInsertModuleLicenseCheck(t *testing.T) { mod.IsRedistributable = false mod.Units[0].IsRedistributable = false - MustInsertModuleLatest(ctx, t, db, mod) + MustInsertModule(ctx, t, db, mod) // New model u, err := db.GetUnit(ctx, newUnitMeta(mod.ModulePath, mod.ModulePath, mod.Version), internal.AllFields) @@ -190,7 +190,7 @@ func TestUpsertModule(t *testing.T) { m := sample.Module("upsert.org", "v1.2.3", "dir/p") // Insert the module. - MustInsertModuleLatest(ctx, t, testDB, m) + MustInsertModule(ctx, t, testDB, m) // Change the module, and re-insert. m.IsRedistributable = !m.IsRedistributable lic := *m.Licenses[0] @@ -198,7 +198,7 @@ func TestUpsertModule(t *testing.T) { sample.ReplaceLicense(m, &lic) m.Units[0].Readme.Contents += " and more" - MustInsertModuleLatest(ctx, t, testDB, m) + MustInsertModule(ctx, t, testDB, m) // The changes should have been saved. checkModule(ctx, t, testDB, m) } @@ -303,7 +303,7 @@ func TestInsertModuleNewCoverage(t *testing.T) { Contents: []byte(`Lorem Ipsum`), }, } - MustInsertModuleLatest(ctx, t, testDB, m) + MustInsertModule(ctx, t, testDB, m) u, err := testDB.GetUnit(ctx, newUnitMeta(m.ModulePath, m.ModulePath, m.Version), internal.AllFields) if err != nil { t.Fatal(err) @@ -338,7 +338,7 @@ func TestPostgres_ReadAndWriteModuleOtherColumns(t *testing.T) { seriesPath: "github.com/user/repo/path", } - MustInsertModuleLatest(ctx, t, testDB, v) + MustInsertModule(ctx, t, testDB, v) query := ` SELECT sort_version, series_path @@ -450,7 +450,7 @@ func TestDeleteModule(t *testing.T) { v := sample.DefaultModule() - MustInsertModuleLatest(ctx, t, testDB, v) + MustInsertModule(ctx, t, testDB, v) if _, err := testDB.GetModuleInfo(ctx, v.ModulePath, v.Version); err != nil { t.Fatal(err) } @@ -513,7 +513,7 @@ func TestPostgres_NewerAlternative(t *testing.T) { t.Fatal(err) } m := sample.Module(mvs.ModulePath, okVersion, "p") - MustInsertModuleLatest(ctx, t, testDB, m) + MustInsertModule(ctx, t, testDB, m) if _, _, found := GetFromSearchDocuments(ctx, t, testDB, m.Packages()[0].Path); found { t.Fatal("found package after inserting") } |