diff options
| author | Julie Qiu <julie@golang.org> | 2020-07-02 14:24:58 -0400 |
|---|---|---|
| committer | Julie Qiu <julie@golang.org> | 2020-07-06 15:32:32 +0000 |
| commit | 434abc0b2ea191b5f5650f811c4a4727ac08117e (patch) | |
| tree | b4fa1926b6758597e9ecc2bb2a40ce23737a498b /internal/postgres/insert_module_test.go | |
| parent | 083367e5a866819783cd0887bb9f86f5346cecc0 (diff) | |
| download | go-x-pkgsite-434abc0b2ea191b5f5650f811c4a4727ac08117e.tar.xz | |
internal/experiment: improve ergonomics for NewSet and NewContext
Previously, NewSet and NewContext required the caller to construct a set
that was passed in. The functions now accept experiment names, to make
them easier to use.
Change-Id: Id306902910d51483c48a6a3bc8205cf484694d6a
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/240857
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Diffstat (limited to 'internal/postgres/insert_module_test.go')
| -rw-r--r-- | internal/postgres/insert_module_test.go | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/internal/postgres/insert_module_test.go b/internal/postgres/insert_module_test.go index 4562ac39..dfda2233 100644 --- a/internal/postgres/insert_module_test.go +++ b/internal/postgres/insert_module_test.go @@ -28,10 +28,7 @@ import ( func TestInsertModule(t *testing.T) { ctx, cancel := context.WithTimeout(context.Background(), testTimeout*2) defer cancel() - ctx = experiment.NewContext(ctx, - experiment.NewSet(map[string]bool{ - internal.ExperimentInsertDirectories: true, - })) + ctx = experiment.NewContext(ctx, internal.ExperimentInsertDirectories) for _, test := range []struct { name string @@ -140,10 +137,7 @@ func checkModule(ctx context.Context, t *testing.T, want *internal.Module) { func TestUpsertModule(t *testing.T) { ctx, cancel := context.WithTimeout(context.Background(), testTimeout) defer cancel() - ctx = experiment.NewContext(ctx, - experiment.NewSet(map[string]bool{ - internal.ExperimentInsertDirectories: true, - })) + ctx = experiment.NewContext(ctx, internal.ExperimentInsertDirectories) m := sample.Module("upsert.org", "v1.2.3") p := &internal.LegacyPackage{ Name: "p", |