internal/postgres: enforce redistributability and allow bypass for search

- Unexport upsertSearchDocuments and verify that at its sole call
  site, non-redistributable data is removed unless the bypass flag is
  true. This "fixes" golang/go#40971, which was never actually broken.

- Remove non-redistributable data in
  GetPackagesForSearchDocumentUpsert. (This was a legitimate bug,
  although one that never had any effect.)

Fixes golang/go#40971
For golang/go#39602

Change-Id: I35493739de3a4ac0694ad3f07a371d9873f31b52
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/250637
Reviewed-by: Julie Qiu <julie@golang.org>

1 files changed, 1 insertions, 1 deletions

diff --git a/internal/postgres/insert_module.go b/internal/postgres/insert_module.go
index 2af86f90..931639c2 100644
--- a/internal/postgres/insert_module.go
+++ b/internal/postgres/insert_module.go
@@ -157,7 +157,7 @@ func (db *DB) saveModule(ctx context.Context, m *internal.Module) (err error) {
 			return err
 		}
 		// Insert the module's packages into search_documents.
-		return UpsertSearchDocuments(ctx, tx, m)
+		return upsertSearchDocuments(ctx, tx, m)
 	})
 }