diff options
| author | Jonathan Amsterdam <jba@google.com> | 2021-08-10 13:58:50 -0400 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2021-08-11 14:03:35 +0000 |
| commit | 2b0bc991dd9586ef979363d29dbc339d584f3d25 (patch) | |
| tree | 30e20a9cf4453c4757b5774de51d8ccda92f4c18 /internal/postgres/insert_module.go | |
| parent | 6589d1fa547521e4c760d9140c46557882496719 (diff) | |
| download | go-x-pkgsite-2b0bc991dd9586ef979363d29dbc339d584f3d25.tar.xz | |
internal/postgres: on insert, delete only old packages from search
Instead of deleting the entire module from search_documents on insert,
just delete packages that are not in the current version. That will
avoid resetting imported-by counts to zero when we reprocess the
latest version of a module.
For golang/go#47555
Change-Id: Ie2aedc920f0e840c20f4487ed10bf7801b43a3f8
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/341269
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Diffstat (limited to 'internal/postgres/insert_module.go')
| -rw-r--r-- | internal/postgres/insert_module.go | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/internal/postgres/insert_module.go b/internal/postgres/insert_module.go index ea58cd5d..ef71c464 100644 --- a/internal/postgres/insert_module.go +++ b/internal/postgres/insert_module.go @@ -149,10 +149,7 @@ func (db *DB) saveModule(ctx context.Context, m *internal.Module, lmv *internal. return err } - // Delete this module from search_documents completely. Below we'll - // insert the packages from this module. This will effectively remove - // packages from older module versions that are not in the latest one. - if err := deleteModuleFromSearchDocuments(ctx, tx, m.ModulePath, nil); err != nil { + if err := deleteOtherModulePackagesFromSearchDocuments(ctx, tx, m); err != nil { return err } |