diff options
| author | Jonathan Amsterdam <jba@google.com> | 2021-09-06 12:04:47 -0400 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2021-09-07 15:14:39 +0000 |
| commit | 7624e4766ea785e034eef99e45d5df11778722d0 (patch) | |
| tree | 0c090aa37e709743ba829e6bfdbd70c84ec6c37f /internal/middleware | |
| parent | a7412093f9cf2b3f8887269f53f0d6ece5e3ba2a (diff) | |
| download | go-x-pkgsite-7624e4766ea785e034eef99e45d5df11778722d0.tar.xz | |
many: replace most uses of strings.SplitN with Cut
In most cases Cut(s, sep) is clearer than strings.SplitN(s, sep, 2).
Change-Id: I375c15f778e43ff25b5b74c9ad0e96dac4615786
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/347889
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Diffstat (limited to 'internal/middleware')
| -rw-r--r-- | internal/middleware/quota.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/internal/middleware/quota.go b/internal/middleware/quota.go index a2601824..8fd6cd45 100644 --- a/internal/middleware/quota.go +++ b/internal/middleware/quota.go @@ -20,6 +20,7 @@ import ( "go.opencensus.io/stats" "go.opencensus.io/stats/view" "go.opencensus.io/tag" + "golang.org/x/pkgsite/internal" "golang.org/x/pkgsite/internal/config" "golang.org/x/pkgsite/internal/log" ) @@ -48,9 +49,9 @@ func recordQuotaMetric(ctx context.Context, blocked string) { } func ipKey(s string) string { - fields := strings.SplitN(s, ",", 2) + addr, _, _ := internal.Cut(s, ",") // First field is the originating IP address. - origin := strings.TrimSpace(fields[0]) + origin := strings.TrimSpace(addr) ip := net.ParseIP(origin) if ip == nil { return "" |