aboutsummaryrefslogtreecommitdiff
path: root/internal/database
diff options
context:
space:
mode:
authorJulie Qiu <julie@golang.org>2020-11-19 23:09:05 -0500
committerJulie Qiu <julie@golang.org>2020-11-20 17:06:53 +0000
commitff4efb1a4d232c4ac063ff38f5985661ea97b37e (patch)
tree0dfc86951e16ff791f5f7d5beba7b461b60a44ff /internal/database
parent6657ef22c5588415c202445532bd23498217f364 (diff)
downloadgo-x-pkgsite-ff4efb1a4d232c4ac063ff38f5985661ea97b37e.tar.xz
internal: rename tc to test
The variable tc is renamed to test when used to refer to a test case, for consistency throughout the rest of the codebase, which uses the variable test in most cases. Change-Id: I88a87aa020928af98e8579a299f3111718dfa044 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/271809 Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> Trust: Julie Qiu <julie@golang.org>
Diffstat (limited to 'internal/database')
-rw-r--r--internal/database/database_test.go26
1 files changed, 13 insertions, 13 deletions
diff --git a/internal/database/database_test.go b/internal/database/database_test.go
index 68a9090b..93ff1bfc 100644
--- a/internal/database/database_test.go
+++ b/internal/database/database_test.go
@@ -50,7 +50,7 @@ func TestMain(m *testing.M) {
func TestBulkInsert(t *testing.T) {
table := "test_bulk_insert"
- for _, tc := range []struct {
+ for _, test := range []struct {
name string
columns []string
values []interface{}
@@ -126,7 +126,7 @@ func TestBulkInsert(t *testing.T) {
wantCount: 1,
},
} {
- t.Run(tc.name, func(t *testing.T) {
+ t.Run(test.name, func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), testTimeout)
defer cancel()
@@ -147,10 +147,10 @@ func TestBulkInsert(t *testing.T) {
var err error
var returned []string
- if tc.wantReturned == nil {
- err = testDB.BulkInsert(ctx, table, tc.columns, tc.values, tc.conflictAction)
+ if test.wantReturned == nil {
+ err = testDB.BulkInsert(ctx, table, test.columns, test.values, test.conflictAction)
} else {
- err = testDB.BulkInsertReturning(ctx, table, tc.columns, tc.values, tc.conflictAction,
+ err = testDB.BulkInsertReturning(ctx, table, test.columns, test.values, test.conflictAction,
[]string{"colA"}, func(rows *sql.Rows) error {
var r string
if err := rows.Scan(&r); err != nil {
@@ -160,13 +160,13 @@ func TestBulkInsert(t *testing.T) {
return nil
})
}
- if tc.wantErr && err == nil || !tc.wantErr && err != nil {
- t.Errorf("got error %v, wantErr %t", err, tc.wantErr)
+ if test.wantErr && err == nil || !test.wantErr && err != nil {
+ t.Errorf("got error %v, wantErr %t", err, test.wantErr)
}
if err != nil {
return
}
- if tc.wantCount != 0 {
+ if test.wantCount != 0 {
var count int
query := "SELECT COUNT(*) FROM " + table
row := testDB.QueryRow(ctx, query)
@@ -174,14 +174,14 @@ func TestBulkInsert(t *testing.T) {
if err != nil {
t.Fatalf("testDB.queryRow(%q): %v", query, err)
}
- if count != tc.wantCount {
- t.Errorf("testDB.queryRow(%q) = %d; want = %d", query, count, tc.wantCount)
+ if count != test.wantCount {
+ t.Errorf("testDB.queryRow(%q) = %d; want = %d", query, count, test.wantCount)
}
}
- if tc.wantReturned != nil {
+ if test.wantReturned != nil {
sort.Strings(returned)
- if !cmp.Equal(returned, tc.wantReturned) {
- t.Errorf("returned: got %v, want %v", returned, tc.wantReturned)
+ if !cmp.Equal(returned, test.wantReturned) {
+ t.Errorf("returned: got %v, want %v", returned, test.wantReturned)
}
}
})