diff options
| author | Jonathan Amsterdam <jba@google.com> | 2020-06-09 07:17:17 -0400 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2020-06-09 15:02:07 +0000 |
| commit | 7e391c3fb7c3fc5ff8ff3366dfba0012fade1bcf (patch) | |
| tree | c639e7277e0ff7a74c7d61362385b7fca540d658 /internal/database/database_test.go | |
| parent | 465b4fd31d6406fa613cc74a27c4194927b77ea0 (diff) | |
| download | go-x-pkgsite-7e391c3fb7c3fc5ff8ff3366dfba0012fade1bcf.tar.xz | |
internal/database: BulkInsert: only prepare when necessary
We were preparing the full statement (of size stride) even if we never used
it, because the number of values to insert was less than stride.
Also, tweak TestLargeBulkInsert:
- the logging is no longer voluminous, so we don't have to turn it off;
- make the number of values not divisible by 1000, so we test the case
where rightBound > len(values).
Change-Id: I169130ab370b192a629025886173b1e33f5d158b
Reviewed-on: https://team-review.git.corp.google.com/c/golang/discovery/+/766240
CI-Result: Cloud Build <devtools-proctor-result-processor@system.gserviceaccount.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
Diffstat (limited to 'internal/database/database_test.go')
| -rw-r--r-- | internal/database/database_test.go | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/internal/database/database_test.go b/internal/database/database_test.go index 59e6a82b..2ff6f9da 100644 --- a/internal/database/database_test.go +++ b/internal/database/database_test.go @@ -188,12 +188,7 @@ func TestLargeBulkInsert(t *testing.T) { if _, err := testDB.Exec(ctx, `CREATE TEMPORARY TABLE test_large_bulk (i BIGINT);`); err != nil { t.Fatal(err) } - defer func(q bool) { - QueryLoggingDisabled = q - }(QueryLoggingDisabled) - QueryLoggingDisabled = true - - const size = 150000 + const size = 150001 vals := make([]interface{}, size) for i := 0; i < size; i++ { vals[i] = i + 1 |