diff options
| author | Jonathan Amsterdam <jba@google.com> | 2020-09-21 09:59:29 -0400 |
|---|---|---|
| committer | Jonathan Amsterdam <jba@google.com> | 2020-09-21 15:39:45 +0000 |
| commit | addf838532975c8a709e9051f615c7ea715cf00a (patch) | |
| tree | 4842074589b9191cf78aec95346e32ec0995dcfb /cmd | |
| parent | 04ec3b7c0d964e125da87276a683769bc392f561 (diff) | |
| download | go-x-pkgsite-addf838532975c8a709e9051f615c7ea715cf00a.tar.xz | |
middleware: report error to GCP on experiment load failure
If experiments can't be loaded, send the error to GCP's error
reporting service. This can be used to alert that there is a
problem with the experiment configuration.
For golang/go#41483
Change-Id: Ia4fd9047dafd2ddd3d1bce46d1acd26ee00b7113
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/256238
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/frontend/main.go | 5 | ||||
| -rw-r--r-- | cmd/worker/main.go | 3 |
2 files changed, 4 insertions, 4 deletions
diff --git a/cmd/frontend/main.go b/cmd/frontend/main.go index e0c93b52..453cb315 100644 --- a/cmd/frontend/main.go +++ b/cmd/frontend/main.go @@ -176,12 +176,13 @@ func main() { log.Fatal(ctx, err) } requestLogger := getLogger(ctx, cfg) - experimenter, err := middleware.NewExperimenter(ctx, 1*time.Minute, expg) + rc := reportingClient(ctx, cfg) + experimenter, err := middleware.NewExperimenter(ctx, 1*time.Minute, expg, rc) if err != nil { log.Fatal(ctx, err) } ermw := middleware.Identity() - if rc := reportingClient(ctx, cfg); rc != nil { + if rc != nil { ermw = middleware.ErrorReporting(rc.Report) } mw := middleware.Chain( diff --git a/cmd/worker/main.go b/cmd/worker/main.go index 2f503249..c042366b 100644 --- a/cmd/worker/main.go +++ b/cmd/worker/main.go @@ -143,8 +143,7 @@ func main() { log.Fatalf(ctx, "strconv.Atoi(%q): %v", timeout, err) } requestLogger := logger(ctx, cfg) - - experimenter, err := middleware.NewExperimenter(ctx, 1*time.Minute, func(context.Context) internal.ExperimentSource { return db }) + experimenter, err := middleware.NewExperimenter(ctx, 1*time.Minute, func(context.Context) internal.ExperimentSource { return db }, reportingClient) if err != nil { log.Fatal(ctx, err) } |